From: "Taylor Beebe" <taylor.d.beebe@gmail.com>
To: gaoliming <gaoliming@byosoft.com.cn>, devel@edk2.groups.io
Cc: 'Rebecca Cran' <rebecca@bsdio.com>,
'Bob Feng' <bob.c.feng@intel.com>,
'Yuwei Chen' <yuwei.chen@intel.com>
Subject: Re: 回复: [edk2-devel] [PATCH v2 0/2] Update BaseTools NULL Include and Library Matching
Date: Thu, 28 Mar 2024 17:28:19 -0700 [thread overview]
Message-ID: <968375d9-d671-491d-a544-3372089788a8@gmail.com> (raw)
In-Reply-To: <062501da80ab$62ddd8c0$28998a40$@byosoft.com.cn>
Hi Liming,
Each patch describes the issue being fixed with an example.
I created a bugzilla and assigned it to me for Patch 1:
https://bugzilla.tianocore.org/show_bug.cgi?id=4744
GitHub PR: https://github.com/tianocore/edk2/pull/5365
Thanks :)
-Taylor
On 3/27/24 6:00 PM, gaoliming wrote:
> Can you submit a Bugzilla for this problem?
>
> Can you give one example to explain the incorrect usage?
>
> Thanks
> Liming
>> -----邮件原件-----
>> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Taylor Beebe
>> 发送时间: 2024年3月23日 3:19
>> 收件人: devel@edk2.groups.io
>> 抄送: Rebecca Cran <rebecca@bsdio.com>; Liming Gao
>> <gaoliming@byosoft.com.cn>; Bob Feng <bob.c.feng@intel.com>; Yuwei Chen
>> <yuwei.chen@intel.com>
>> 主题: [edk2-devel] [PATCH v2 0/2] Update BaseTools NULL Include and
>> Library Matching
>>
>> v1:
>> - Initial patch series
>> v2:
>> - Simplified the check for if the currently evaluated inf is a module or
>> library.
>> - Added a commit to use stronger matching of NULL includes (check for
>> pattern "NULL<n>")
>>
>> Cc: Rebecca Cran <rebecca@bsdio.com>
>> Cc: Liming Gao <gaoliming@byosoft.com.cn>
>> Cc: Bob Feng <bob.c.feng@intel.com>
>> Cc: Yuwei Chen <yuwei.chen@intel.com>
>>
>> Taylor Beebe (2):
>> BaseTools: Don't Recurse NULL Includes Not Linked to Module
>> BaseTools: Use Stronger Matching for NULL Linked Libraries
>>
>> BaseTools/Source/Python/GenFds/FfsInfStatement.py | 4 ++--
>> BaseTools/Source/Python/Workspace/WorkspaceCommon.py | 8 +++++---
>> 2 files changed, 7 insertions(+), 5 deletions(-)
>>
>> --
>> 2.40.1.vfs.0.0
>>
>>
>>
>>
>>
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117218): https://edk2.groups.io/g/devel/message/117218
Mute This Topic: https://groups.io/mt/105189358/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2024-03-29 0:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-22 19:19 [edk2-devel] [PATCH v2 0/2] Update BaseTools NULL Include and Library Matching Taylor Beebe
2024-03-22 19:19 ` [edk2-devel] [PATCH v2 1/2] BaseTools: Don't Recurse NULL Includes Not Linked to Module Taylor Beebe
2024-03-22 19:19 ` [edk2-devel] [PATCH v2 2/2] BaseTools: Use Stronger Matching for NULL Linked Libraries Taylor Beebe
2024-03-28 1:00 ` 回复: [edk2-devel] [PATCH v2 0/2] Update BaseTools NULL Include and Library Matching gaoliming via groups.io
2024-03-29 0:28 ` Taylor Beebe [this message]
2024-04-02 1:37 ` 回复: " gaoliming via groups.io
2024-04-09 19:42 ` Taylor Beebe
2024-04-15 3:25 ` 回复: " gaoliming via groups.io
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=968375d9-d671-491d-a544-3372089788a8@gmail.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox