public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Laszlo Ersek <lersek@redhat.com>
To: Lars Kurth <lars.kurth@citrix.com>,
	Julien Grall <julien.grall@arm.com>,
	"Kinney, Michael D" <michael.d.kinney@intel.com>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
	"Ard Biesheuvel" <ard.biesheuvel@linaro.org>,
	"Jordan Justen" <jordan.l.justen@intel.com>,
	"Anthony Perard" <anthony.perard@citrix.com>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Stefan Berger" <stefanb@linux.ibm.com>
Subject: Re: PATCH] Change EDK II to BSD+Patent License
Date: Thu, 21 Mar 2019 18:41:25 +0100	[thread overview]
Message-ID: <9685496a-4ed0-6ac7-de46-ba60282b4f3d@redhat.com> (raw)
In-Reply-To: <8A1C7ED9-000A-4EBB-A196-10CE5B9B522F@citrix.com>

On 03/21/19 13:04, Lars Kurth wrote:
> 
> 
> On 20/03/2019, 18:25, "Laszlo Ersek" <lersek@redhat.com> wrote:
> 
>     But, again, this should be discussed in that separate BZ then.
>     
>     >     >            OvmfPkg/XenBusDxe/XenBus.c
> 
> This file is licensed under the BSD license, aka https://opensource.org/licenses/bsd-license.php
> 
>     >     >            OvmfPkg/XenBusDxe/XenStore.c
>     >     >            OvmfPkg/XenBusDxe/XenStore.h    
>     >I do not know where these files come from. The files do not appear to come from a Xen project repo. 
>     
>     See commit a9090a94bb4a ("OvmfPkg/XenBusDxe: Add XenStore client
>     implementation", 2014-10-29), by Anthony.
>     
>     https://github.com/tianocore/edk2/commit/a9090a94bb4a
>     
>     The commit message states,
>     
>     >Origin: FreeBSD 10.0
>     >License: This patch adds several files under the MIT licence.
>     
>     >So, unless you trust that the license in the headers are correct, the right thing would be to identify the source and check whether the license text has been imported unmodified
>     
>     We do trust that the license blocks, as they exist, are correct. Where
>     we need help & support is the mapping/replacement of those verbose
>     license blocks to/with SPDX-License-Identifier tags.
> 
> As I now understand what is needed, I had a look at the XenStore.* licenses. They are NOT a standard MIT license
> 
> The sources say:
> "Permission is hereby granted, free of charge, to any person obtaining a copy of this source file (the "Software")"
> The MIT license says
> "Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software")"
> 
> I would argue that replacing "source file" with "software and associated documentation files" is probably OK, but I am not an expert. I am pretty sure this type of issue has come up before when migrating to SPDX. It might be worthwhile reaching out to someone from SPDX.
> 
> Hope this helped

Thank you! We'll revisit this issue (and thread, I assume) later on.

Laszlo


  parent reply	other threads:[~2019-03-21 17:41 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-13 17:54 PATCH] Change EDK II to BSD+Patent License Kinney, Michael D
2019-03-14 10:55 ` Laszlo Ersek
2019-03-14 19:06   ` Julien Grall
     [not found]     ` <8F40F2BF-B40F-4338-A832-70AE84B26408@citrix.com>
2019-03-15  9:35       ` Julien Grall
     [not found]         ` <6FBC013D-4BC9-454C-9D4D-87C96F435704@citrix.com>
2019-03-15 17:18           ` Julien Grall
     [not found]             ` <C2A0176C-8197-421A-9CA9-2B416DF17EAB@citrix.com>
2019-03-20 12:09               ` Laszlo Ersek
2019-03-23  0:44                 ` Kinney, Michael D
2019-03-25 10:04                   ` Laszlo Ersek
     [not found]               ` <720E0EE9-2AED-4110-827D-B87DE5F52862@citrix.com>
2019-03-20 18:25                 ` Laszlo Ersek
2019-03-20 18:42                   ` Julien Grall
2019-03-20 20:03                     ` Laszlo Ersek
     [not found]                   ` <8A1C7ED9-000A-4EBB-A196-10CE5B9B522F@citrix.com>
2019-03-21 17:41                     ` Laszlo Ersek [this message]
2019-03-18 18:17   ` Kinney, Michael D
2019-03-14 18:03 ` Jordan Justen
2019-03-18 18:25   ` Kinney, Michael D
2019-03-18 19:42     ` Jordan Justen
2019-03-19 17:58     ` Leif Lindholm
2019-03-19 19:09       ` Kinney, Michael D
2019-03-19 19:57         ` Jordan Justen
2019-03-19 20:06         ` Leif Lindholm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9685496a-4ed0-6ac7-de46-ba60282b4f3d@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox