From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 296352194EB70 for ; Thu, 21 Mar 2019 10:41:34 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5E3A98124A; Thu, 21 Mar 2019 17:41:33 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-143.rdu2.redhat.com [10.10.120.143]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0F861101E840; Thu, 21 Mar 2019 17:41:25 +0000 (UTC) To: Lars Kurth , Julien Grall , "Kinney, Michael D" Cc: "edk2-devel@lists.01.org" , Ard Biesheuvel , Jordan Justen , Anthony Perard , =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= , Stefan Berger References: <6de07821-a05e-9446-7ef6-c178eaf2fdfb@arm.com> <8F40F2BF-B40F-4338-A832-70AE84B26408@citrix.com> <6FBC013D-4BC9-454C-9D4D-87C96F435704@citrix.com> <720E0EE9-2AED-4110-827D-B87DE5F52862@citrix.com> <2439277a-b103-50d4-4de2-f1d3e17c53a3@redhat.com> <8A1C7ED9-000A-4EBB-A196-10CE5B9B522F@citrix.com> From: Laszlo Ersek Message-ID: <9685496a-4ed0-6ac7-de46-ba60282b4f3d@redhat.com> Date: Thu, 21 Mar 2019 18:41:25 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <8A1C7ED9-000A-4EBB-A196-10CE5B9B522F@citrix.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Thu, 21 Mar 2019 17:41:33 +0000 (UTC) Subject: Re: PATCH] Change EDK II to BSD+Patent License X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Mar 2019 17:41:35 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 03/21/19 13:04, Lars Kurth wrote: > > > On 20/03/2019, 18:25, "Laszlo Ersek" wrote: > > But, again, this should be discussed in that separate BZ then. > > > > OvmfPkg/XenBusDxe/XenBus.c > > This file is licensed under the BSD license, aka https://opensource.org/licenses/bsd-license.php > > > > OvmfPkg/XenBusDxe/XenStore.c > > > OvmfPkg/XenBusDxe/XenStore.h > >I do not know where these files come from. The files do not appear to come from a Xen project repo. > > See commit a9090a94bb4a ("OvmfPkg/XenBusDxe: Add XenStore client > implementation", 2014-10-29), by Anthony. > > https://github.com/tianocore/edk2/commit/a9090a94bb4a > > The commit message states, > > >Origin: FreeBSD 10.0 > >License: This patch adds several files under the MIT licence. > > >So, unless you trust that the license in the headers are correct, the right thing would be to identify the source and check whether the license text has been imported unmodified > > We do trust that the license blocks, as they exist, are correct. Where > we need help & support is the mapping/replacement of those verbose > license blocks to/with SPDX-License-Identifier tags. > > As I now understand what is needed, I had a look at the XenStore.* licenses. They are NOT a standard MIT license > > The sources say: > "Permission is hereby granted, free of charge, to any person obtaining a copy of this source file (the "Software")" > The MIT license says > "Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software")" > > I would argue that replacing "source file" with "software and associated documentation files" is probably OK, but I am not an expert. I am pretty sure this type of issue has come up before when migrating to SPDX. It might be worthwhile reaching out to someone from SPDX. > > Hope this helped Thank you! We'll revisit this issue (and thread, I assume) later on. Laszlo