Re: [edk2-devel] AArch64 with HeapGuard: page allocations wrongly aligned

["Rebecca Cran via groups.io" <rebecca=os.amperecomputing.com@groups.io>]

On 1/19/2024 1:03 PM, Oliver Smith-Denny wrote:

> Thanks for trying. In lieu of being able to test myself, all I can offer
> is adding some more prints, when the memory gets allocated, making sure
> it is 64k aligned then. I'd be curious to see what the address is that
> is attempting to be freed.
> 
> My guess (as it was earlier) is that it is going to be aligned to
> 64k but + 4k. I.e the guard page at the front is throwing it off. There
> may have just been an error in my attempt to fix the check for that.
> 
> If however that address is not 64k + 4k aligned, then something else is
> afoot.
> 
> Happy to look at some more data if you get it or can engineer an example
> on an open source system (can you force the system to call this function
> twice even without the extra SMBIOS entries, etc.).

These are the addresses it's allocating with and without HeapGuard (with 
the original, upstream Page.c code).


Without HeapGuard:

SmbiosCreate64BitTable() re-allocate SMBIOS 64-bit table
Allocated 0x00000000EF110000 with gBS->AllocatePages (AllocateAnyPages, 
EfiRuntimeServicesData, EFI_SIZE_TO_PAGES (55), 0x00000000FB7C0000)
...
SmbiosCreate64BitTable() re-allocate SMBIOS 64-bit table
SmbiosCreate64BitTable: calling FreePages (0x00000000EF110000, 1)
Allocated 0x00000000EF110000 with gBS->AllocatePages (AllocateAnyPages, 
EfiRuntimeServicesData, EFI_SIZE_TO_PAGES (4153), 0x00000000FB8AEC8E)

------------------------------------------------------

WITH HeapGuard:

SmbiosCreate64BitTable() re-allocate SMBIOS 64-bit table
Allocated 0x00000000ED36F000 with gBS->AllocatePages (AllocateAnyPages, 
EfiRuntimeServicesData, EFI_SIZE_TO_PAGES (55), 0x00000000ED38F000)
...
SmbiosCreate64BitTable() re-allocate SMBIOS 64-bit table
SmbiosCreate64BitTable: calling FreePages (0x00000000ED36F000, 1)
<ASSERT>

-- 
Rebecca Cran


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#114150): https://edk2.groups.io/g/devel/message/114150
Mute This Topic: https://groups.io/mt/103810212/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-