From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 9FF3C74003A for ; Mon, 22 Jan 2024 22:06:54 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=l4JgwQzHWVo/ybl5CwBt26t9l+fQsS0U/VFiTNokwg0=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Message-ID:Date:User-Agent:Subject:To:Cc:References:From:In-Reply-To:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1705961213; v=1; b=Ax8vKShBprV/hHb2pch7xT1B/aecg51zHlAAXAUTs9y1MrJ/kOMnMDu36PNLex6YBOuEEguf D3Gtk9BSZZiOLQpR1ZY85juuy2dRyx85aKr8Y/xQCU8YpKcbRkPyGmndm4/Iolpu3tq1ilwq8kD BogY5WtSZIp0/hk6QGPip+Lc= X-Received: by 127.0.0.2 with SMTP id DMECYY7687511xvb6DWnE1v7; Mon, 22 Jan 2024 14:06:53 -0800 X-Received: from NAM12-MW2-obe.outbound.protection.outlook.com (NAM12-MW2-obe.outbound.protection.outlook.com [40.107.244.111]) by mx.groups.io with SMTP id smtpd.web10.6289.1705961212175002928 for ; Mon, 22 Jan 2024 14:06:52 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DviIkNZ8YYVL/Hxo7tZWYbfdNBpOyHMsj7S0v7+0igWBMGMeOLp9nE14v++AhS1+Dheq40+8dJBZ4A0/YNraBEpHbH8HCKA8LlPrgm+yLWtPBrkwUIL0WQdv12vK1q7rL4NkiY3VqsZ6rN5tnm/q2pF9Lk/bj7QeDXit0a5nRmCwE0MsLUTTQKloHg7CTWEvY9oOiM+76PSzvU7CoLFZxfuUDiEirADe6ShZ59JrmzCmD3RiIyU6KHtj99KASuvsMSByAW+8YoNYDh8oZvDSo+/LGiPBaaNuYx4tPdfxY813p4+wjwmGh+aLc2/VLF7we1aWOkdDCxjpn5qy/KNgng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TjqnbKBJELpL3r+Kn4HfucNdg/HQjuBQzs20RPXdPOs=; b=C5JFeXWLojOed826xixwNz2d4vMBXDyvxdN5KaB1kZf6XEHYHLRTMdPntCTAVoX3DMkCwi7cyK6OTytVW+u0s/U2M7/Ds+uJrF4i8XkQa7ExRuJjL/bS7XPTF8Z40rmH4zgZUxbbknhDUQg0ENvC72IYAOaoPHNkJX+qjqMoaQ9pk9gVFiBsO0u0Z9IoZrMZQdIolK0fUHMtdwIR+G3e/exWjgJ/BW+JypWsNOA4dqRN3ah9xB4k/b/t+ZuFglx7tjoAMz9iEwCOrAEkchWlQ3fApoXjWRDGHvPPrcLEUKcmgqvb6LGwsJi5nM6VRb42ZOn4e6nHJNARkOSh050I3A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none X-Received: from LV3PR01MB8464.prod.exchangelabs.com (2603:10b6:408:1a3::7) by BL1PR01MB7796.prod.exchangelabs.com (2603:10b6:208:39b::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7202.34; Mon, 22 Jan 2024 22:06:50 +0000 X-Received: from LV3PR01MB8464.prod.exchangelabs.com ([fe80::7748:d4a3:bcd9:14c1]) by LV3PR01MB8464.prod.exchangelabs.com ([fe80::7748:d4a3:bcd9:14c1%6]) with mapi id 15.20.7202.031; Mon, 22 Jan 2024 22:06:49 +0000 Message-ID: <9696df58-283c-447d-b801-c3bb57b3787d@os.amperecomputing.com> Date: Mon, 22 Jan 2024 15:06:45 -0700 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] AArch64 with HeapGuard: page allocations wrongly aligned To: Oliver Smith-Denny , devel@edk2.groups.io Cc: Leif Lindholm , Ard Biesheuvel , Jian J Wang , Liming Gao , Dandan Bi References: <05f6388b-155e-427d-8e34-0ac571e97fb8@os.amperecomputing.com> <24affef7-eb96-4a82-b9d4-b616eb90024d@os.amperecomputing.com> <17AB84FD31479E00.28523@groups.io> <0a589fed-02f1-4598-bbbc-98bad0e8b04f@linux.microsoft.com> <14dac152-dfea-4ad3-bd52-300990bd1be8@os.amperecomputing.com> <09a8622e-be60-46e2-8e96-447dacb8c12f@linux.microsoft.com> From: "Rebecca Cran via groups.io" In-Reply-To: <09a8622e-be60-46e2-8e96-447dacb8c12f@linux.microsoft.com> X-ClientProxiedBy: CH0PR04CA0089.namprd04.prod.outlook.com (2603:10b6:610:74::34) To LV3PR01MB8464.prod.exchangelabs.com (2603:10b6:408:1a3::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LV3PR01MB8464:EE_|BL1PR01MB7796:EE_ X-MS-Office365-Filtering-Correlation-Id: 82e98f9d-b739-4883-5707-08dc1b966ec7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: qwKJu8MIlliNleutXsJJKa7+gp8pzNAUdMcl60Hv/ARP8xuLr1zzcnUnnyuwH15wACUcSJUVBwLn/5Q4nMxYsiBm4M1zIEO7HWVlqI+WhvIirOk/+L5qxk3UiPr3a6Sx6qcWM0uTZp+N20JpGuGKAb8u9eVdjMy2rTb8svRZ2nhj4jUqixLxIOH36iuHd81OUip+OvfJPRUFNyZk+36NYNXzSeT9nQUI93nqICDcVuIyuAej4etzMhx4968aEf9cxbZnYfjdRMKlFf4rRHBYs4AhLOf1ZZlK1f3z3wze0y+ilxP/g3/I87bIUKbPI2GAS+/F7cGCofVQShD8+SS7kvH2CYzLFAcooltxTOGQqWM/gly8m0HknlswXm8t8JKDgBcML2ALXdGvNqhoIICLdKPO7ycNS14u9HxietgB96wTUkE74wW8StPisFG3ppde42UxWA8afeHCiDGVDK0GJgQQDOghMSMVupu5JiM872MVd8iYTBsnfMRFx88R3wBCNrRS5zEPCn9EoB9ympeJb+t+yA//KMNtM8s5lAiXa2Q0Nu26cwieaUyO+DmWYkvv71hHjE3mnorGpISrYsUY5DUYoz53WDMHZyGD+tjCqyS/LGrfIWa81XkQr23fi2iG X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YXhUa3pMWVF5RnFMZ2tkZFhMOEFZV093WmdjTFlrYStiT2JPdDlBVWVSWUxj?= =?utf-8?B?aGsrT0ZlaE1aK0F2dkNaaitiWStTV2ZkVi8rd1VETVdYdDJMNS9reTVqVXd3?= =?utf-8?B?dWY3L3p4S2RPNUxYMmJBQ2xzcmF4YjUrV1hKeVd4UnhGTnl2bDhBSW5DS0Vr?= =?utf-8?B?V3ZESjZ5S1pGSWplYzNwbmF0NUV6ZVNrcXBhZ1NNc3ArR3NjSnVTTTQ1TkhU?= =?utf-8?B?cEowYTJ4YThWNDFsSk1DS1dLOENka0xraGlZSnNEZTlDYjhXMndpaVllZlNu?= =?utf-8?B?UU9HNGVPZk1CaWdHdTRTTWRHMy90Tm5ZVzYraUJCSGRIczBjalFTVjQ2cFhU?= =?utf-8?B?c01oc2F3ZUhvSklGcHMvT01ZTlFhd3JtbUpRYndLNXhEejR6N0ZpN01EVmJa?= =?utf-8?B?c1VDajVvWEQ0R2EvU2JNWnFRQk5vd2thVU1PdjJUYmRuZXBTUFA0dVREU3R3?= =?utf-8?B?NU95UEhmQktUaTRlWUdSOHZvdnAzUFBFU2t6c1pHajJVd2RxQXNkYnhtMlZH?= =?utf-8?B?eGVuellXVzZ2RG4zeml0dHpHSGFlaCtLNFZFTE42Wm5qVVl2T1YxZWV5cjVq?= =?utf-8?B?SFl6cHNVWUlZS1FmRmlTM1NTYzZ5MGtaMmF1UThZSWZqYmd2bUFZQWNRQndO?= =?utf-8?B?SlZsZElNUXFYaVMvN3FEZS9jNkRzK1c5TFhkaXFUenk2SWpER3pJNVhSVUYy?= =?utf-8?B?aCtKR3hVcm9uKzN5V1FTVGsrY0Z3ZUJ1clZ6Tm5CRzRUcjdFekhiZ1FROEdR?= =?utf-8?B?VjJGMjRLQTdLR2FxNUJWR3Z6TUZ3RkhCZ3dVbEIwUXNoaHEvTzh4alVkZCtY?= =?utf-8?B?OVAxeFZDZkFoZWNTQU03N3hNTDdPZno2N1dOanU0NjIyTE5GSlZBK3BybW9l?= =?utf-8?B?aDRNcnlxQ1BZeDhkTmIxQ01qKy9IaVprR2gycHc3c1c5aTYva3hyYlNPbUNI?= =?utf-8?B?V1VOdnZYdmFDMy9Cb0lEbk11ZXhrVDdRMTdMWjlRZ2w2WHFQTU9FQ0E1MlRn?= =?utf-8?B?ZkVEbkV2R2Y5SkgvQmo3TVczYTN6SGoyVGo3cVZOOHVJN2V5aVVCVWtKVEtx?= =?utf-8?B?aDRralpXMmxOTXV3TkVXSWthMUltdUhPVkg5UER6dFlJTW9NRHpLSEpheUlJ?= =?utf-8?B?VEQ5OFFNa0RwWXlLVVpIMXFxSXFPRWIvdDNBVmpycHdXd2FkdjRoUUNPTDN3?= =?utf-8?B?eXRzbFUwdUZwREl1MFlVbFg2eGwzN1RwR0U3UXQ2U2VaSG9lVVkzbFg4WEtI?= =?utf-8?B?cjFuanplOGJ0TzhNczU4M242K04zY3lqeHU4Tzh4MlIxOHBGQWNjWng3N0lR?= =?utf-8?B?aEo1TlpzZ3U5U2RLUEhJRER4SWNVNE5yM0NKWnZkaDE1OGV1Mzlibm0wNSs4?= =?utf-8?B?bSt4OFpuMkNqMk8rNDNvek04ZzJGVkJMa3l4Qk90NHc0ZHVrdTFJdFM5UjJK?= =?utf-8?B?aE44VWg3aURLRkxMOHdrS251UXhBMndxenQzYm5uUzhnSEl3S0ZLOW5HbUE0?= =?utf-8?B?aXRCcklvcnMzenRtT01lbGF4NXZjQ2xLUFhldjltaXVLcVRHait4RmVXQnR2?= =?utf-8?B?Q3VrOVdkdlRxdUZwOEoyV3ZPUmhpNWZTd0NNcmNsWmJCOUM2UXlIanhoM2U3?= =?utf-8?B?b1hjQ2F5V2N1YVVOMk5lbmFidUhNWktZblpmNE80emwzdWhrRE00RlhJSUFm?= =?utf-8?B?THJmeDlOQlpXbkQ2M0ZuZHRGMnF2dTJCSGZuR2JMWHZWb1RZSDFpNUUwVWww?= =?utf-8?B?U3Q0TGdUcTZ4YTFBdXl2eHVJcDNqU2xMdHJMcUZvb0RzcURBNnZQZ1hicW50?= =?utf-8?B?TjdNejd4SjR5V2NrY0NsTkxoaGhvQzN5SmR6aEZoNnM2enNUODlUWENIeWdn?= =?utf-8?B?MFEvN0tuRWpNeStBWWwzM2lXSzFscEgrL1UrcE5LYjZIN0pVYW94c0xuNC9K?= =?utf-8?B?RkJNdEl6eWxPTGpwNEwzL2R2ZlJyaGRmcm9zZFJZOFc5My9NckFBbmthdDNz?= =?utf-8?B?NXo5b1BDckcrTE1NZXl6bUpMdGN5a0ZZOWdlMldDMzVvTXhnZVI3U0dZd2tu?= =?utf-8?B?WjQyWU1ZQ1VXaW0yWVZhYitQYklMZTVtaWUyVTBzZ2dYMmpBYmEzNUp1RGQx?= =?utf-8?B?L1ZMcURDdUFKQ2xFSGF1cGlEZjNEYXB1c1RwdU50T09KRkVNRWVpUUx5a0NP?= =?utf-8?Q?gixUGw8PH85YjCVl+SestQI=3D?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: 82e98f9d-b739-4883-5707-08dc1b966ec7 X-MS-Exchange-CrossTenant-AuthSource: LV3PR01MB8464.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jan 2024 22:06:49.8372 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mxnU0b1UDlzC75EkK9dlmM++tz0x2ZPWTDdwE90soZqNESl027gjmywagStT5boL1ZuKTGWoZd3zuPDaUJRnTWR8/rZVMhPOXqcCexm/BXxqm4KEIkPTvPg4JQcNL3Qk X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR01MB7796 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,rebecca@os.amperecomputing.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: ElPHqkxZ1HjvOJNRlpdpkebCx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=Ax8vKShB; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") On 1/19/2024 1:03 PM, Oliver Smith-Denny wrote: > Thanks for trying. In lieu of being able to test myself, all I can offer > is adding some more prints, when the memory gets allocated, making sure > it is 64k aligned then. I'd be curious to see what the address is that > is attempting to be freed. >=20 > My guess (as it was earlier) is that it is going to be aligned to > 64k but + 4k. I.e the guard page at the front is throwing it off. There > may have just been an error in my attempt to fix the check for that. >=20 > If however that address is not 64k + 4k aligned, then something else is > afoot. >=20 > Happy to look at some more data if you get it or can engineer an example > on an open source system (can you force the system to call this function > twice even without the extra SMBIOS entries, etc.). These are the addresses it's allocating with and without HeapGuard (with=20 the original, upstream Page.c code). Without HeapGuard: SmbiosCreate64BitTable() re-allocate SMBIOS 64-bit table Allocated 0x00000000EF110000 with gBS->AllocatePages (AllocateAnyPages,=20 EfiRuntimeServicesData, EFI_SIZE_TO_PAGES (55), 0x00000000FB7C0000) ... SmbiosCreate64BitTable() re-allocate SMBIOS 64-bit table SmbiosCreate64BitTable: calling FreePages (0x00000000EF110000, 1) Allocated 0x00000000EF110000 with gBS->AllocatePages (AllocateAnyPages,=20 EfiRuntimeServicesData, EFI_SIZE_TO_PAGES (4153), 0x00000000FB8AEC8E) ------------------------------------------------------ WITH HeapGuard: SmbiosCreate64BitTable() re-allocate SMBIOS 64-bit table Allocated 0x00000000ED36F000 with gBS->AllocatePages (AllocateAnyPages,=20 EfiRuntimeServicesData, EFI_SIZE_TO_PAGES (55), 0x00000000ED38F000) ... SmbiosCreate64BitTable() re-allocate SMBIOS 64-bit table SmbiosCreate64BitTable: calling FreePages (0x00000000ED36F000, 1) --=20 Rebecca Cran -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114150): https://edk2.groups.io/g/devel/message/114150 Mute This Topic: https://groups.io/mt/103810212/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-