From: "Laszlo Ersek" <lersek@redhat.com>
To: devel@edk2.groups.io, oleksiyy@ami.com
Cc: liming.gao@intel.com, michael.d.kinney@intel.com,
dandan.bi@intel.com, ray.ni@intel.com, rahul1.kumar@intel.com,
Felixp@ami.com
Subject: Re: [edk2-devel] [PATCH V3 1/4] MdePkg: Add New Memory Attributes
Date: Mon, 6 Jul 2020 11:11:20 +0200 [thread overview]
Message-ID: <9698ee63-3113-0b81-d4d8-3551d6e7e00a@redhat.com> (raw)
In-Reply-To: <20200702205039.52400-2-oleksiyy@ami.com>
Hi Oleksiy,
On 07/02/20 22:50, Oleksiy Yakovlev wrote:
> Add usage of EFI_MEMORY_SP and EFI_MEMORY_CPU_CRYPTO
> attributes introduced in UEFI 2.8
> (UEFI 2.8, mantis 1919 and 1872)
> Fix typos in EFI_MEMORY_CPU_CRYPTO description.
> Add attributes bitmasks, grouped by type.
>
> Signed-off-by: Oleksiy Yakovlev <oleksiyy@ami.com>
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
> Reviewed-by: Liming Gao <liming.gao@intel.com>
> ---
> MdePkg/Include/Uefi/UefiSpec.h | 10 ++++++++--
> 1 file changed, 8 insertions(+), 2 deletions(-)
I think you forgot to pick up Zhiguang Liu's "Reviewed-by" from
<https://edk2.groups.io/g/devel/message/61627> (i.e., under the v2 thread).
Of course I think that can be remedied by the maintainer that merges
this series in the end. (I can help with that too, but the series isn't
fully reviewed yet -- patches v3 #2 through #4 still need maintainer
approval.)
Thanks,
Laszlo
>
> diff --git a/MdePkg/Include/Uefi/UefiSpec.h b/MdePkg/Include/Uefi/UefiSpec.h
> index 558e1bc..05b82e0 100644
> --- a/MdePkg/Include/Uefi/UefiSpec.h
> +++ b/MdePkg/Include/Uefi/UefiSpec.h
> @@ -96,9 +96,9 @@ typedef enum {
> #define EFI_MEMORY_SP 0x0000000000040000ULL
> //
> // If this flag is set, the memory region is capable of being
> -// protected with the CPU?s memory cryptographic
> +// protected with the CPU's memory cryptographic
> // capabilities. If this flag is clear, the memory region is not
> -// capable of being protected with the CPU?s memory
> +// capable of being protected with the CPU's memory
> // cryptographic capabilities or the CPU does not support CPU
> // memory cryptographic capabilities.
> //
> @@ -109,6 +109,12 @@ typedef enum {
> //
> #define EFI_MEMORY_RUNTIME 0x8000000000000000ULL
>
> +//
> +// Attributes bitmasks, grouped by type
> +//
> +#define EFI_CACHE_ATTRIBUTE_MASK (EFI_MEMORY_UC | EFI_MEMORY_WC | EFI_MEMORY_WT | EFI_MEMORY_WB | EFI_MEMORY_UCE | EFI_MEMORY_WP)
> +#define EFI_MEMORY_ATTRIBUTE_MASK (EFI_MEMORY_RP | EFI_MEMORY_XP | EFI_MEMORY_RO | EFI_MEMORY_SP | EFI_MEMORY_CPU_CRYPTO)
> +
> ///
> /// Memory descriptor version number.
> ///
>
next prev parent reply other threads:[~2020-07-06 9:11 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-02 20:50 [PATCH V3 0/4] Add New Memory Attributes Oleksiy Yakovlev
2020-07-02 20:50 ` [PATCH V3 1/4] MdePkg: " Oleksiy Yakovlev
2020-07-06 9:11 ` Laszlo Ersek [this message]
2020-07-02 20:50 ` [PATCH V3 2/4] MdeModulePkg: " Oleksiy Yakovlev
2020-07-06 9:13 ` [edk2-devel] " Laszlo Ersek
2020-07-13 16:12 ` Laszlo Ersek
2020-07-02 20:50 ` [PATCH V3 3/4] UefiCpuPkg: Update EFI_MEMORY_CACHETYPE_MASK definition Oleksiy Yakovlev
2020-07-06 9:16 ` [edk2-devel] " Laszlo Ersek
2020-07-13 16:13 ` Laszlo Ersek
2020-07-14 0:13 ` Dong, Eric
2020-07-02 20:50 ` [PATCH V3 4/4] UefiCpuPkg: Add New Memory Attributes Oleksiy Yakovlev
2020-07-13 16:14 ` [edk2-devel] " Laszlo Ersek
2020-07-14 0:16 ` Dong, Eric
2020-07-06 9:57 ` [edk2-devel] [PATCH V3 0/4] " Laszlo Ersek
2020-07-15 15:07 ` Laszlo Ersek
2023-11-17 8:07 ` Dhaval Sharma
2023-11-17 8:25 ` Laszlo Ersek
2023-11-20 4:59 ` Dhaval Sharma
2023-11-21 15:03 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9698ee63-3113-0b81-d4d8-3551d6e7e00a@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox