From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from rn-mailsvcp-ppex-lapp44.apple.com (rn-mailsvcp-ppex-lapp44.apple.com [17.179.253.48]) by mx.groups.io with SMTP id smtpd.web08.1080.1636483979196913982 for ; Tue, 09 Nov 2021 10:52:59 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@apple.com header.s=20180706 header.b=eBiv8gWa; spf=pass (domain: apple.com, ip: 17.179.253.48, mailfrom: afish@apple.com) Received: from pps.filterd (rn-mailsvcp-ppex-lapp44.rno.apple.com [127.0.0.1]) by rn-mailsvcp-ppex-lapp44.rno.apple.com (8.16.1.2/8.16.1.2) with SMTP id 1A9Im9I9015517; Tue, 9 Nov 2021 10:52:57 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=apple.com; h=from : message-id : content-type : mime-version : subject : date : in-reply-to : cc : to : references; s=20180706; bh=6NYj3lYe53mL4L3OJn27qxZWvOwkGRGlm7Zoy7p94cI=; b=eBiv8gWaaN0ZiaDpuYbXnKRAAjJq/rYDz7Lk2CeZV9ivS/qGhfO6Yr3jSK4sTRvJBDSJ cSxTov72eahqrDqR9MdoMHY8jSeToMz4DiRKLo2TVBeUdbCtUdiUKDVo03OgTwxOnynz tWeiHwfXuGfVHNBXdQxr2MtwCJjpLWGI9KDl1rjpezXoDI8/gzOkhCsMnK6qCW5iLNCF h/v9b0aRuEtUTJC1L/odoLeCLNsbWNY1juhAvI6YbEm2xq76iHlXhDfAx0sxyGuBfD9h UlMgcGTiDC/C4GhjXdWMKxk6sSTXlrdfMnnWwdyHIwkNYvIBXhDmR0mZ7hKxEDOJGWHW 9A== Received: from rn-mailsvcp-mta-lapp01.rno.apple.com (rn-mailsvcp-mta-lapp01.rno.apple.com [10.225.203.149]) by rn-mailsvcp-ppex-lapp44.rno.apple.com with ESMTP id 3c7hdmk34p-8 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO); Tue, 09 Nov 2021 10:52:57 -0800 Received: from rn-mailsvcp-mmp-lapp03.rno.apple.com (rn-mailsvcp-mmp-lapp03.rno.apple.com [17.179.253.16]) by rn-mailsvcp-mta-lapp01.rno.apple.com (Oracle Communications Messaging Server 8.1.0.12.20210903 64bit (built Sep 3 2021)) with ESMTPS id <0R2B0058EJ487080@rn-mailsvcp-mta-lapp01.rno.apple.com>; Tue, 09 Nov 2021 10:52:56 -0800 (PST) Received: from process_milters-daemon.rn-mailsvcp-mmp-lapp03.rno.apple.com by rn-mailsvcp-mmp-lapp03.rno.apple.com (Oracle Communications Messaging Server 8.1.0.12.20210903 64bit (built Sep 3 2021)) id <0R2B00J00IT26X00@rn-mailsvcp-mmp-lapp03.rno.apple.com>; Tue, 09 Nov 2021 10:52:56 -0800 (PST) X-Va-A: X-Va-T-CD: da3a4df698400084da27c6ab403bcb35 X-Va-E-CD: 574fda742400e238a02c5048d028c5dd X-Va-R-CD: b4e96f8f3d52136df210f2e6a101920e X-Va-CD: 0 X-Va-ID: 52e30713-32d8-4691-aea7-559356f710a0 X-V-A: X-V-T-CD: da3a4df698400084da27c6ab403bcb35 X-V-E-CD: 574fda742400e238a02c5048d028c5dd X-V-R-CD: b4e96f8f3d52136df210f2e6a101920e X-V-CD: 0 X-V-ID: 645786a7-abdf-4331-abb8-b8c0e6684a9e X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.425,18.0.790 definitions=2021-11-09_05:2021-11-08,2021-11-09 signatures=0 Received: from smtpclient.apple (unknown [17.235.8.214]) by rn-mailsvcp-mmp-lapp03.rno.apple.com (Oracle Communications Messaging Server 8.1.0.12.20210903 64bit (built Sep 3 2021)) with ESMTPSA id <0R2B00X47J470O00@rn-mailsvcp-mmp-lapp03.rno.apple.com>; Tue, 09 Nov 2021 10:52:56 -0800 (PST) From: "Andrew Fish" Message-id: <96B9F324-D206-4074-8C39-EAB9D392AB9C@apple.com> MIME-version: 1.0 (Mac OS X Mail 15.0 \(3693.20.0.1.32\)) Subject: Re: [edk2-devel] Progress on getting Uncrustify working for EDK2? Date: Tue, 09 Nov 2021 10:52:54 -0800 In-reply-to: Cc: edk2-devel-groups-io , Leif Lindholm , Gerd Hoffmann , =?utf-8?Q?Marvin_H=C3=A4user?= , Michael Kubacki , "mikuback@linux.microsoft.com" , "rebecca@nuviainc.com" , Bret Barkelew To: Mike Kinney References: <2679bfa3-b4ec-d8e9-7e56-54ebe42d9001@posteo.de> <9fe0f984-db9d-9aec-0b44-5d30791a2855@linux.microsoft.com> <20211007104813.wa4rmfsqgcpvnzwt@leviathan> <07d5c8bc-40b2-4e99-3b3d-4c8ac4e14220@posteo.de> <438B4D66-2CFB-45E3-AF75-42342F0B1E67@apple.com> <20211109084002.wywzc5cnwhhlzktc@sirius.home.kraxel.org> <20211109123630.j7ropheao337m7rf@leviathan> X-Mailer: Apple Mail (2.3693.20.0.1.32) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.425,18.0.790 definitions=2021-11-09_05:2021-11-08,2021-11-09 signatures=0 Content-type: multipart/alternative; boundary="Apple-Mail=_C853E39B-1C68-4787-802E-81DCDC90E891" --Apple-Mail=_C853E39B-1C68-4787-802E-81DCDC90E891 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Nov 9, 2021, at 10:26 AM, Kinney, Michael D wrote: >=20 > Andrew, > =20 > Agree that we want it to be very simple and walk up and use. > =20 > There is no requirement to use Visual Studio Code. > =20 > There are multiple ways available for use by developers > Visual Studio Code plugin. > Run uncrustify tool from command line. > Implement a githook that automatically runs uncrustify as part of local c= ommit. > If you look at bottom of this readme it describe how to integrate with Vi= m and IntelliJ > https://github.com/uncrustify/uncrustify > =20 > What is critical at this stage is identifying specific work items to comp= lete the source style conversion. Defining exactly =E2=80=9Chow we do it= =E2=80=9D is important for success. Looks like your suggestion for the deve= loper use case is a download page that auto picks the right installer. > =20 I=E2=80=99d be OK if to start it just listed the various options, if making= the button smart is too much work.=20 Thanks, Andrew Fish > Best regards, > =20 > Mike > =20 > From: Andrew Fish =20 > Sent: Tuesday, November 9, 2021 10:14 AM > To: edk2-devel-groups-io ; Kinney, Michael D > Cc: Leif Lindholm ; Gerd Hoffmann ;= Marvin H=C3=A4user ; Michael Kubacki ; mikuback@linux.microsoft.com; rebecca@nuviainc.com; Bret Ba= rkelew > Subject: Re: [edk2-devel] Progress on getting Uncrustify working for EDK2= ? > =20 > Mike, > =20 > My main concern is there is an easy path for the developers. I don=E2=80= =99t want to have developers have to learn new development technologies jus= t to run a =E2=80=9Crequired=E2=80=9D tool. I=E2=80=99m not as concerned on= how we do it. Hosting binaries from a webpage that auto picks what to down= load would be fine with me.=20 > =20 > I think the important thing is we make this walkup an use, and we write u= p the instructions not assuming =E2=80=9Cother knowledge=E2=80=9D.=20 > =20 > My use case is probably uncommon. We don=E2=80=99t use brew, but there is= an internal brew we can use. So we generally just install build tools into= our repo. We are more flexible on personal productivity tools so I=E2=80= =99d probably consider switching to Visual Studio Code, especially if there= was an Extension in the Marketplace I could just click on to configure Cod= e for edk2 development. On the other hand nothing inspires hate like asking= people to switch their editor, so I don=E2=80=99t think we can depend on C= ode as the solution.=20 > =20 > Thanks, > =20 > Andrew Fish >=20 >=20 > On Nov 9, 2021, at 7:08 AM, Michael D Kinney > wrote: > =20 > Submodule within which repo? What would be the proposed location? >=20 > Would a fork of uncrustify maintained as a repo under TianoCore work as w= ell? >=20 > There are CI checks (including extensive unit tests) and release generati= on that are built into uncrustify repo and I do not know if those will be f= unctional if it is maintained as a submodule. >=20 > Thanks, >=20 > Mike >=20 >=20 > -----Original Message----- > From: Leif Lindholm > > Sent: Tuesday, November 9, 2021 4:37 AM > To: Gerd Hoffmann > > Cc: devel@edk2.groups.io ; Kinney, Michael D= >; Andrew F= ish >; Marvin H=C3=A4user > >; Michael Kubacki >; mikuback@l= inux.microsoft.com ; rebecca@nuviainc.= com ; > Bret Barkelew > > Subject: Re: [edk2-devel] Progress on getting Uncrustify working for EDK2= ? >=20 > On Tue, Nov 09, 2021 at 09:40:02 +0100, Gerd Hoffmann wrote: >=20 > Hi, >=20 >=20 > 3. Require use of uncrustify tool before submitting patch review emails= or PRs. > * The required version would be a formally released version from t= he fork maintained by Michael Kubacki until > the changes can be upstreamed. >=20 > * https://dev.azure.com/projectmu/Uncrustify >=20 > Can we please *first* get the changes merged to upstream uncrustify? >=20 > That'll make the whole process much less painful because the usual > software repositories (linux distro packages, macos homebrew, ...) > can be used to install uncrustify then, and it's also less confusing if > developers don't have to juggle with different uncrustify variants > (upstream vs. edk2). >=20 > Whilst I agree in principle... >=20 > This means postponing automated coding style changes until 2023 > (Debian stable), 2025 (Ubuntu LTS), ??? (RHEL10), or even later > ... and I'd rather not. >=20 > I like Marvin's suggestion of a submodule. Which we could drop once > no longer needed. >=20 > / > Leif >=20 >=20 >=20 --Apple-Mail=_C853E39B-1C68-4787-802E-81DCDC90E891 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8

On Nov 9, 202= 1, at 10:26 AM, Kinney, Michael D <michael.d.kinney@intel.com> wrote:

Andrew,
 
Agree that we want it to be very simple a= nd walk up and use.
 
There is no requirement to use Visual Studio Code.=
 
There are multiple ways av= ailable for use by developers
  1. Visual Studio Code plugin.<= o:p class=3D"">
  2. Run uncrustify tool from command line.
  3. Implement a githook that automatically runs uncrustify as part of local commit.
  4. = If you look at bottom of this readme it describe how to integrate with Vim = and IntelliJ
https://github.com/uncrustify/uncrustify=
 
What is critical at this stage i= s identifying specific work items to complete the source style conversion.<= span class=3D"">  Defining exactly =E2=80=9Chow we do it=E2=80=9D is important for succe= ss. Looks like your suggestion for the develop= er use case is a download page that auto picks the right installer.
=  

I=E2=80=99d be OK if to start it just listed the various options, if = making the button smart is too much work. 

Thanks,

Andrew Fish

Best regards,
 
Mike
 
From: Andrew Fish <afish@apple.com> 
Sent: Tuesday, November 9, 2021 10:14 AM
To: <= /span>edk2-devel-groups-io <devel@edk2.groups.io>; Kinney, Michael D <michael.d.kinney@intel.com>=
Cc:&= nbsp;Leif Lindholm <leif@nuviainc.com>; Gerd Hoffmann <kraxel@redhat.com>; Marvin H=C3=A4user <mhaeuser@posteo.de>; Mi= chael Kubacki <Michael.Kubacki@microsoft.com>; mikuback@linux.microsoft.com; rebecca@nuviainc.com; Bret Barkelew= <Bret.Barkele= w@microsoft.com>
Subject: Re: [edk2-devel] Progress on gettin= g Uncrustify working for EDK2?
 
Mike,
 
My main concern is there is an e= asy path for the developers. I don=E2=80=99t want to have developers have t= o learn new development technologies just to run a =E2=80=9Crequired=E2=80= =9D tool. I=E2=80=99m not as concerned on how we do it. Hosting binaries fr= om a webpage that auto picks what to download would be fine with me. <= o:p class=3D"">
 
I think the important thing is we make thi= s walkup an use, and we write up the instructions not assuming =E2=80=9Coth= er knowledge=E2=80=9D. 
 
My use case i= s probably uncommon. We don=E2=80=99t use brew, but there is an internal br= ew we can use. So we generally just install build tools into our repo. We &= nbsp;are more flexible on personal productivity tools so I=E2=80=99d probab= ly consider switching to Visual Studio Code, especially if there was an Ext= ension in the Marketplace I could just click on to configure Code for edk2 = development. On the other hand nothing inspires hate like asking people to = switch their editor, so I don=E2=80=99t think we can depend on Code as the = solution. 
 
Thanks,
 
Andrew Fish


On Nov = 9, 2021, at 7:08 AM, Michael D Kinney <michael.d.kinney@intel.com> wrote:
 
Submodule within which repo? &nbs= p;What would be the proposed location?

Would a= fork of uncrustify maintained as a repo under TianoCore work as well?

There are CI checks (including extensive unit test= s) and release generation that are built into uncrustify repo and I do not = know if those will be functional if it is maintained as a submodule.

Thanks,

Mike


<= /div>
=
-----Original Message-----
From: Leif Lind= holm <leif@nuviainc.com>
= Sent: Tuesday, November 9, 2021 4:37 AM
To: Gerd Hoffmann <= ;kraxel@redhat.com>
Cc: = devel@edk2.groups.io; Kinney, Michael D <michael.d.kinney@intel.com>; Andrew Fish <afish@apple.com>; Marvin H=C3=A4user
<mhaeuser@posteo.de>; Michael Kubacki <Michael.Kubacki@microsoft.com>; mikuback@linux.microsoft.com; rebecca@nuviainc.com;Bret Barkelew <Bret.Bar= kelew@microsoft.com>
Subject: Re: [edk2-devel] Progres= s on getting Uncrustify working for EDK2?

On T= ue, Nov 09, 2021 at 09:40:02 +0100, Gerd Hoffmann wrote:

 Hi,


<= blockquote style=3D"margin-top: 5pt; margin-bottom: 5pt;" class=3D"">
 3.  Require use of uncrustify tool before submittin= g patch review emails or PRs.
    *  = ; The required version would be a formally released version  from= the fork maintained by Michael Kubacki until<= /div>
the changes can be upstre= amed.

=     *   https://dev.azure.com/projectmu/Uncrustify=

Can we pl= ease *first* get the changes merged to upstream uncrustify?
<= br class=3D"">That'll make the whole process much less painful because the = usual
software repositories (linux distro packages, macos hom= ebrew, ...)
can be used to install uncrustify then, and it's = also less confusing if
developers don't have to juggle with d= ifferent uncrustify variants
(upstream vs. edk2).

Whi= lst I agree in principle...

This means postpon= ing automated coding style changes until 2023
(Debian stable)= , 2025 (Ubuntu LTS), ??? (RHEL10), or even later
... and I'd = rather not.

I like Marvin's suggestion of a su= bmodule. Which we could drop once
no longer needed.

/
   Leif=



--Apple-Mail=_C853E39B-1C68-4787-802E-81DCDC90E891--