From: Andrew Fish <afish@apple.com>
To: edk2-devel <edk2-devel@lists.01.org>
Subject: UefiCpuPkg CpuDxe GDT init question?
Date: Thu, 07 Mar 2019 14:37:57 -0800 [thread overview]
Message-ID: <96DCE1C9-B02B-4520-A483-F72BBAAAB3B8@apple.com> (raw)
I'm trying to understand why gdtPtr.Base is casting to (UINT32)?
1) gdtPtr.Base is a a UINTN
2) It is legal for AllocateRuntimePool() to return an address > 4GB
It seems like the code should just cast to (UINTN)?
https://github.com/tianocore/edk2/blob/master/UefiCpuPkg/CpuDxe/CpuGdt.c#L151
VOID
InitGlobalDescriptorTable (
VOID
)
{
GDT_ENTRIES *gdt;
IA32_DESCRIPTOR gdtPtr;
//
// Allocate Runtime Data for the GDT
//
gdt = AllocateRuntimePool (sizeof (GdtTemplate) + 8);
ASSERT (gdt != NULL);
gdt = ALIGN_POINTER (gdt, 8);
//
// Initialize all GDT entries
//
CopyMem (gdt, &GdtTemplate, sizeof (GdtTemplate));
//
// Write GDT register
//
gdtPtr.Base = (UINT32)(UINTN)(VOID*) gdt;
gdtPtr.Limit = (UINT16) (sizeof (GdtTemplate) - 1);
AsmWriteGdtr (&gdtPtr);
Thanks,
Andrew Fish
next reply other threads:[~2019-03-07 22:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-07 22:37 Andrew Fish [this message]
2019-03-08 5:02 ` UefiCpuPkg CpuDxe GDT init question? Andrew Fish
2019-03-08 7:59 ` Laszlo Ersek
2019-03-08 14:13 ` Yao, Jiewen
2019-03-08 15:08 ` Laszlo Ersek
2019-03-09 3:10 ` Andrew Fish
2019-03-11 15:59 ` Andrew Fish
2019-03-11 16:04 ` Yao, Jiewen
2019-03-11 16:30 ` Andrew Fish
2019-03-11 21:04 ` Yao, Jiewen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=96DCE1C9-B02B-4520-A483-F72BBAAAB3B8@apple.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox