From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by mx.groups.io with SMTP id smtpd.web11.27197.1629134064138727525 for ; Mon, 16 Aug 2021 10:14:24 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@suse.com header.s=mimecast20200619 header.b=ifcxbmtu; spf=pass (domain: suse.com, ip: 194.104.109.102, mailfrom: jfehlig@suse.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1629134061; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=viYWeMkpPnPH4jtBZnXzMvl3o9wy/xcSJV9x56uk79U=; b=ifcxbmtuMl8EmmnoH6CCYXC2vpIwU6e+Di+FjdQfxtTH5wARymbqwz50nYWRHdbqVFCBlt LJ+HHMozNUzFEBKBYp3Y9S4jiUjgjDcdzDkn/QvpbuG64xzkufDUbsb7640K+ug3+CtemQ IKzNFb9RoS/0nQSogKqk/nL/2/jLO8E= Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05lp2107.outbound.protection.outlook.com [104.47.18.107]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-11-ff5H78FaOZWAqJjzln7inA-1; Mon, 16 Aug 2021 19:14:20 +0200 X-MC-Unique: ff5H78FaOZWAqJjzln7inA-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kSJgUrf0JUwBA2AMfAl/Pp5EDWIkGeNO+3XJmxFK5gROrilXvTapdEm8d/ViGAkJPD7Z/EOHDhSDqLOSzSyrKIBN02wswa04hNm7evWPjX+xL7MfHa7hX44KDtgr6X4Ghz5s7STBsCICPO/UFDVRbk3h0huwiNJIMCQ4HLyWI0lgL+cgNx6ThEk1cQA09tHb6gcPsnDQ1crb4WOR+I2tnnWpONrJAcBMdv4TqAQo+bWlMC4msuMm3YrpFhYVtsbJmuGHywbiDVehItkhTnxK7lKMTDRtq0GW46IqXpMc2Z4g8LkgKDH1XMTlKNh/DuQ7eGqs6SlaTjczQYipkMOAQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=viYWeMkpPnPH4jtBZnXzMvl3o9wy/xcSJV9x56uk79U=; b=Kx2CTTqD/3mY0XKhBQ98c+uSq2b11mddtgdZppr7n78p5UvDLS9Xp0nrEIJISeaqqU5yb8PftG3kS83dEtzaFTj09qwr2OPywhAgJFRC1hRFxWIGOotMREVTbxEcNpRbhY8tZyO3X+G6exVYTzWgs6Kimo94RHgDBzeg5XqJjLjFhvmNS4D487KpJOrSsVUgA23oppddHE3os7GMIaZM5srmUIU09mtK4VktiHWV1yrReWxdt9biVLjqvmaabDNv7BcgJLuuCXGyEdW52NwLI6vkL006iEASY8tcxDHF03mdorcGWSE0PN8vUviXEZtgJJ55Xn5QkSZw/bpXYZ3f/A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=suse.com; Received: from AM8PR04MB7970.eurprd04.prod.outlook.com (2603:10a6:20b:24f::9) by AM9PR04MB8356.eurprd04.prod.outlook.com (2603:10a6:20b:3b4::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4415.13; Mon, 16 Aug 2021 17:14:18 +0000 Received: from AM8PR04MB7970.eurprd04.prod.outlook.com ([fe80::5d01:f91d:8ffa:b5c3]) by AM8PR04MB7970.eurprd04.prod.outlook.com ([fe80::5d01:f91d:8ffa:b5c3%6]) with mapi id 15.20.4415.023; Mon, 16 Aug 2021 17:14:18 +0000 Subject: Re: [edk2-devel] [PATCH v2 0/5] Fix OvmfXen HVM Direct kernel boot failure To: "Gary Lin (HPS OE-Linux TDC)" , "Yao, Jiewen" Cc: "devel@edk2.groups.io" References: <20210813061305.17519-1-gary.lin@hpe.com> From: Jim Fehlig Message-ID: <96e5e737-f6b0-bb41-7779-c4891d2dd66e@suse.com> Date: Mon, 16 Aug 2021 11:14:14 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 In-Reply-To: X-ClientProxiedBy: FR0P281CA0080.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1e::14) To AM8PR04MB7970.eurprd04.prod.outlook.com (2603:10a6:20b:24f::9) Return-Path: jfehlig@suse.com MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.1.166] (192.150.158.56) by FR0P281CA0080.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1e::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4436.12 via Frontend Transport; Mon, 16 Aug 2021 17:14:17 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 07319cb3-aa0b-450e-9ee0-08d960d9485b X-MS-TrafficTypeDiagnostic: AM9PR04MB8356: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: nFFMmPwVcaMwRtPKUUk11kuduj0esq6PqdGwq0x4C/purfoDzheEDAbG2Q210B0bLXexYNrfw7oFLwyH1liZZY9/AX5IGuW1IyIJjuYyYVCZ87uo3uEcfLWMmoJgnMX29y4yMWSnW9DS/XGFdn0ACDRq1LCBJ3W/40oseOIQTpD3Z+T4Xa78Vx7gildDR0L8fkley/OLBDECJEyPRVyEPrilQ1yBDCUJkPDueWP4KQEvGj28yL0UNgcN9N2t2jC+NdPMLcWbKtC1AvR1fxDqSHxpbXy0HhyvxdJhu97cmyEfkwMMA4EINup8Dm9G0sToKjYWcMDijB6Td1SjQuMMODNJgLpcCw8HgtyU/2IyCnVKffw7iCv3gAqpzwCK8a1MOAcUJgu11M7FyG/8ksYV0AAwga7SYJdNire/MgoTiPXIv2xonQHNOs3tWHIWkd57MWnAfQBfP7H8K961tN8obTwH2yURbAXLO62ddjmzqTsa4GsYpPEEHNhbE89kj7PQ85FqBsZRq+gIaMiNonLHFPK3WIg/Ae+HkA6cxRu1zw8Yyg7wT3Z7X/iModUlUQWNZFRrMoOU7K0cXTEXz/5XzitZGjV7N0oLrNIfcK4APEYKIyeqYLDSviMPtDv9V6U8QZtRnxMt3WpPsA0MCYrodawgF/miX/qYz/C59gmfbC3XSoww3eBA3kx3kn+JVFj6BM9JxmtdArziJEg8hXs38BbGpZETI0ClOfGJnDqjqiA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM8PR04MB7970.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(376002)(136003)(39850400004)(366004)(396003)(346002)(8676002)(110136005)(186003)(83380400001)(36756003)(53546011)(6486002)(4326008)(956004)(66476007)(2616005)(316002)(8936002)(38100700002)(86362001)(2906002)(26005)(16576012)(31686004)(6666004)(478600001)(66556008)(31696002)(66946007)(5660300002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bVgrbUdOTjQyekJRVXVMekRlc3NiZW9qYjVTODNJcWNUSmU3MzZlWTh6VVUz?= =?utf-8?B?NUx6ck15Qi9HT0NyWTNhblRueWdkUWQ3amUyRmdEME5tN1dyTjhHd3RHN3JJ?= =?utf-8?B?OGY0dEF2cUNOQWxuMnhraUZhRXNlTjFvUExVWWE1NjBJT1dNNmJVOUpDK29U?= =?utf-8?B?R0svREZQWUdWbm4vODBwVnFmYkVadGxsTkVqWDdqQkZ2WnZsZW9QeHUwYkIz?= =?utf-8?B?T2Y2cGxWT1liNm9qZWx3ZERHTUlTU0xSdGkvMmtXK3FWRXlHeVRuVHlXdlJZ?= =?utf-8?B?YkZ2Y21YRHM4L3FuRVZic1diM0xiUFJWSktEWGpGNmg1azZWTlVTTlNrckF2?= =?utf-8?B?MnRjQWEyeFdwR2lTcjF1OHc4cU1jcFhLaHhTS3kyRVdFaUhsQk5uQkJsUUcx?= =?utf-8?B?Qlc4ZWRRdGNSaXNMZ21naXB3YmcrTUZhZzRoc0FDbTBabzMrcnAvT0Z6T1Q4?= =?utf-8?B?UU5mTFRraTZXbHlGMTBiQllYM1p0RTh2OHlCU2E5WDBCNitOTlFNZDcrdjh4?= =?utf-8?B?RmhDSU9HNm1tRUJRSjdIQllEUG5TejRLWnMxekhKaWE0eTVsem1tUlRvZTRS?= =?utf-8?B?SXNoblYwd3gyMUFjS3pMUzg0OW5vMnZPejQzMlRVOGV0M1REVVV0UmsvWTdz?= =?utf-8?B?R1BQS2YzODdaSXlXQXorV0JJaEVaT2FReXEvQVlrL3E3MzQrbUtUN1ZVUFY5?= =?utf-8?B?NWFvSld2eEs3TmZyZFVhR3N6bVNIQnVGZFVITVpqa3lSc29MdXVFa2paRkFV?= =?utf-8?B?bXV6V0hOMUhOZGQxTkE1b0gvdjlrMm5jeDZpclUyWVNGYm9kUk1hNDU2U1Y4?= =?utf-8?B?bUt6dkFQUk0ySFl5WXQ3NUtiOUhKYmdtR0h4Ryt6SXkrTlp1bWVnVEJZaGRt?= =?utf-8?B?VjREcnhLQnpHZ3Z6ajQ3b1IzNjlQQjl2b2hxN2tpRGhRU0s5TXhnNmJVSHk5?= =?utf-8?B?WDVNRXR0Q2luUm5qZ3l6ZjhhK2pNUWNSQW9mTVJJVjRFTEpaWHdLd2pGRTE3?= =?utf-8?B?M1VxS2ZCNmNONkwrNVRHVHNudHdyQWtGWmxtMkQ1bWljc2R2R3dzL0tsYjBv?= =?utf-8?B?amR3ZGVlZjR4N1hhRnRRTDVuZFZ4b2w4VkpZTUx2ZzcvakV6RngrWUR2YUo2?= =?utf-8?B?M3BZRGVFOVdJUzBKcUUxbllxUDQzUS9FZWlXZ3oxa1dNbFFETytqY241RGxZ?= =?utf-8?B?ZVBQdmRvTnpUSGZ3dkU3UGh2eHk4Z3ArZk9kSjFEekVlREtzaFFaSm1pbXNr?= =?utf-8?B?R2ZkS0dnNXVRNDE0VGQzYnlsZ3FYb250RjFTOHd4ck0wYUYra1JkczVBbzI0?= =?utf-8?B?RDJyNUlobHBwSkpMaXBkV3N5eW9TbEg5VnRqOHRtdjNxMm1xU25BVHUxN2t4?= =?utf-8?B?VG1wWE1hblA1VUx2UjN1eWhMUWhSdkJNRTJrUVpkZ3FxYkZsbUR0ZzBXdCtC?= =?utf-8?B?U3dZSzF4S2dYTmdrUk9lRHJVWGxHYjYyNGtjZVE2a2lVWjV5UjFyaHowaGlW?= =?utf-8?B?K3VDVVNlM2NpS1BmTzRVZ0xqcUpnODRDRWd1aE5ZZit1Nlc0MEJOYVZFL2ln?= =?utf-8?B?dXpZVWdiSi9sSGpTQmZ0Q0YyZlYwc3daemxjSGdUeW0ydXZFeEIyQW95V3hi?= =?utf-8?B?MitmbHd1VkFPVjczejZEbkdWTmNqVG1sQlIrSjJVbnVQa0tGWmU5SGEydVl2?= =?utf-8?B?N3ByaFJ2eUNGb2d5bi9pTnBqTUozODJha0NRSDZtVnJwQ3RSeG1VeTFXSnI5?= =?utf-8?Q?6t7lHDUJyBpmAZEGOrLuL5+xjjhrhFi5nFLe9b0?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 07319cb3-aa0b-450e-9ee0-08d960d9485b X-MS-Exchange-CrossTenant-AuthSource: AM8PR04MB7970.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Aug 2021 17:14:18.8814 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: SUyxCnCOwH1Dyrvo02pM+dWmp7xI3mb3vY8S/kXRP3fcewvWKB4MrBmYGDSomYjjMLmzbJRAKNfwRLGcYAnirg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8356 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 8/15/21 7:34 PM, Gary Lin (HPS OE-Linux TDC) wrote: > On Fri, Aug 13, 2021 at 09:55:48AM +0000, Yao, Jiewen wrote: >> HI Gary > Hi Jiewen, > >> Several comment: >> >> 1) According to our process, we need a Bugzilla. Would you please file it? >> > Okay, will create a bugzilla entry to track the issue. > >> 2) I do not understand how HVM direct kernel boot is related to S3 enabling. >> It seems 1/3/4/5 are for S3, while 2 is for missing driver. >> Should we split them to 2 patch set? >> > Actually the inconsistency between QemuFwCfgS3Enabled() and > PcdAcpiS3Enable casued the boot failure of HVM direct kernel boot. > S3SaveStateDxe checked PcdAcpiS3Enable(=FALSE) and skipped S3BootScript. > On the other hand, PlatformBootManagerBeforeConsole() invoked > QemuFwCfgS3Enabled()(=TRUE) and tried to locate S3BootScript. Since > S3BootScript wasn't installed, it failed with EFI_NOT_FOUND and stopped > the booting. So Patch 1 and 2 are mainly for the booting issues in > OvmfXen. For Patch 3~5, I just try to eliminate the inconsistency to > avoid the potential problems. > > I can split them into 2 or 3 patch sets if necessary. > >> 3) Does the S3 issue only happen in direct kernel boot? Or is it a generic issue. >> >> 4) Have you validated non direct kernel boot to ensure it still works? >> > Jim, > > Did you encounter any problem with non direct kernel boot VM? No problems encountered, works fine in my testing. Although I did not test these patches specifically, only the ones in the openSUSE Factory ovmf package. Regards, Jim