From: "Sinha, Ankit" <ankit.sinha@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"Kubacki, Michael A" <michael.a.kubacki@intel.com>
Cc: "Desimone, Nathaniel L" <nathaniel.l.desimone@intel.com>
Subject: Re: [edk2-devel] [edk2-platforms][PATCH V1 1/1] ClevoOpenBoardPkg/N1xxWU: Enable Synaptics touchpad support in OS
Date: Mon, 23 Sep 2019 20:27:08 +0000 [thread overview]
Message-ID: <972926FCCE2F9141BF8AD787AAA02EFF51338A74@ORSMSX109.amr.corp.intel.com> (raw)
In-Reply-To: <20190920021538.27096-1-michael.a.kubacki@intel.com>
Reviewed-by: Ankit Sinha <ankit.sinha@intel.com>
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Kubacki, Michael A
Sent: Thursday, September 19, 2019 7:16 PM
To: devel@edk2.groups.io
Cc: Sinha, Ankit <ankit.sinha@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>
Subject: [edk2-devel] [edk2-platforms][PATCH V1 1/1] ClevoOpenBoardPkg/N1xxWU: Enable Synaptics touchpad support in OS
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2068
Adds the ACPI device for the Synaptics touchpad. With this change, the touchpad device is functional in the OS.
Cc: Ankit Sinha <ankit.sinha@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Signed-off-by: Michael Kubacki <michael.a.kubacki@intel.com>
---
Platform/Intel/ClevoOpenBoardPkg/N1xxWU/Library/BoardAcpiLib/DxeN1xxWUAcpiTableLib.c | 2 +-
Platform/Intel/ClevoOpenBoardPkg/Acpi/BoardAcpiDxe/Dsdt/LpcB.asl | 6 +++---
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/Library/BoardAcpiLib/DxeN1xxWUAcpiTableLib.c b/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/Library/BoardAcpiLib/DxeN1xxWUAcpiTableLib.c
index 96a3232fe5..d309bf4e1d 100644
--- a/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/Library/BoardAcpiLib/DxeN1xxWUAcpiTableLib.c
+++ b/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/Library/BoardAcpiLib/DxeN1
+++ xxWUAcpiTableLib.c
@@ -54,7 +54,7 @@ N1xxWUUpdateGlobalNvs (
//
mGlobalNvsArea.Area->LowPowerS0Idle = PcdGet8 (PcdLowPowerS0Idle);
- mGlobalNvsArea.Area->Ps2MouseEnable = FALSE;
+ mGlobalNvsArea.Area->Ps2MouseEnable = PcdGet8 (PcdPs2KbMsEnable);
mGlobalNvsArea.Area->Ps2KbMsEnable = PcdGet8 (PcdPs2KbMsEnable);
}
diff --git a/Platform/Intel/ClevoOpenBoardPkg/Acpi/BoardAcpiDxe/Dsdt/LpcB.asl b/Platform/Intel/ClevoOpenBoardPkg/Acpi/BoardAcpiDxe/Dsdt/LpcB.asl
index 6fbaf3a97f..3ef9aed1e6 100644
--- a/Platform/Intel/ClevoOpenBoardPkg/Acpi/BoardAcpiDxe/Dsdt/LpcB.asl
+++ b/Platform/Intel/ClevoOpenBoardPkg/Acpi/BoardAcpiDxe/Dsdt/LpcB.asl
@@ -55,10 +55,10 @@ scope (\_SB.PCI0.LPCB) {
}
- Device(PS2M) // PS/2 Mouse
+ Device(SYNM) // Synaptics Mouse
{
- Name(_HID,"MSFT0003")
- Name(_CID,EISAID("PNP0F03"))
+ Name(_HID,"SYN1221")
+ Name(_CID,EISAID("PNP0F13"))
Method(_STA)
{
--
2.16.2.windows.1
next prev parent reply other threads:[~2019-09-23 20:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-20 2:15 [edk2-platforms][PATCH V1 1/1] ClevoOpenBoardPkg/N1xxWU: Enable Synaptics touchpad support in OS Kubacki, Michael A
2019-09-23 7:41 ` [edk2-devel] " Nate DeSimone
2019-09-23 20:27 ` Sinha, Ankit [this message]
2019-09-23 22:34 ` Jeremy Soller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=972926FCCE2F9141BF8AD787AAA02EFF51338A74@ORSMSX109.amr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox