* [edk2-platforms][PATCH V1 1/1] ClevoOpenBoardPkg/N1xxWU: Enable Synaptics touchpad support in OS
@ 2019-09-20 2:15 Kubacki, Michael A
2019-09-23 7:41 ` [edk2-devel] " Nate DeSimone
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Kubacki, Michael A @ 2019-09-20 2:15 UTC (permalink / raw)
To: devel; +Cc: Ankit Sinha, Nate DeSimone
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2068
Adds the ACPI device for the Synaptics touchpad. With this change,
the touchpad device is functional in the OS.
Cc: Ankit Sinha <ankit.sinha@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Signed-off-by: Michael Kubacki <michael.a.kubacki@intel.com>
---
Platform/Intel/ClevoOpenBoardPkg/N1xxWU/Library/BoardAcpiLib/DxeN1xxWUAcpiTableLib.c | 2 +-
Platform/Intel/ClevoOpenBoardPkg/Acpi/BoardAcpiDxe/Dsdt/LpcB.asl | 6 +++---
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/Library/BoardAcpiLib/DxeN1xxWUAcpiTableLib.c b/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/Library/BoardAcpiLib/DxeN1xxWUAcpiTableLib.c
index 96a3232fe5..d309bf4e1d 100644
--- a/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/Library/BoardAcpiLib/DxeN1xxWUAcpiTableLib.c
+++ b/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/Library/BoardAcpiLib/DxeN1xxWUAcpiTableLib.c
@@ -54,7 +54,7 @@ N1xxWUUpdateGlobalNvs (
//
mGlobalNvsArea.Area->LowPowerS0Idle = PcdGet8 (PcdLowPowerS0Idle);
- mGlobalNvsArea.Area->Ps2MouseEnable = FALSE;
+ mGlobalNvsArea.Area->Ps2MouseEnable = PcdGet8 (PcdPs2KbMsEnable);
mGlobalNvsArea.Area->Ps2KbMsEnable = PcdGet8 (PcdPs2KbMsEnable);
}
diff --git a/Platform/Intel/ClevoOpenBoardPkg/Acpi/BoardAcpiDxe/Dsdt/LpcB.asl b/Platform/Intel/ClevoOpenBoardPkg/Acpi/BoardAcpiDxe/Dsdt/LpcB.asl
index 6fbaf3a97f..3ef9aed1e6 100644
--- a/Platform/Intel/ClevoOpenBoardPkg/Acpi/BoardAcpiDxe/Dsdt/LpcB.asl
+++ b/Platform/Intel/ClevoOpenBoardPkg/Acpi/BoardAcpiDxe/Dsdt/LpcB.asl
@@ -55,10 +55,10 @@ scope (\_SB.PCI0.LPCB) {
}
- Device(PS2M) // PS/2 Mouse
+ Device(SYNM) // Synaptics Mouse
{
- Name(_HID,"MSFT0003")
- Name(_CID,EISAID("PNP0F03"))
+ Name(_HID,"SYN1221")
+ Name(_CID,EISAID("PNP0F13"))
Method(_STA)
{
--
2.16.2.windows.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [edk2-devel] [edk2-platforms][PATCH V1 1/1] ClevoOpenBoardPkg/N1xxWU: Enable Synaptics touchpad support in OS
2019-09-20 2:15 [edk2-platforms][PATCH V1 1/1] ClevoOpenBoardPkg/N1xxWU: Enable Synaptics touchpad support in OS Kubacki, Michael A
@ 2019-09-23 7:41 ` Nate DeSimone
2019-09-23 20:27 ` Sinha, Ankit
2019-09-23 22:34 ` Jeremy Soller
2 siblings, 0 replies; 4+ messages in thread
From: Nate DeSimone @ 2019-09-23 7:41 UTC (permalink / raw)
To: devel@edk2.groups.io, Kubacki, Michael A; +Cc: Sinha, Ankit
Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Kubacki, Michael A
Sent: Thursday, September 19, 2019 7:16 PM
To: devel@edk2.groups.io
Cc: Sinha, Ankit <ankit.sinha@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>
Subject: [edk2-devel] [edk2-platforms][PATCH V1 1/1] ClevoOpenBoardPkg/N1xxWU: Enable Synaptics touchpad support in OS
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2068
Adds the ACPI device for the Synaptics touchpad. With this change, the touchpad device is functional in the OS.
Cc: Ankit Sinha <ankit.sinha@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Signed-off-by: Michael Kubacki <michael.a.kubacki@intel.com>
---
Platform/Intel/ClevoOpenBoardPkg/N1xxWU/Library/BoardAcpiLib/DxeN1xxWUAcpiTableLib.c | 2 +-
Platform/Intel/ClevoOpenBoardPkg/Acpi/BoardAcpiDxe/Dsdt/LpcB.asl | 6 +++---
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/Library/BoardAcpiLib/DxeN1xxWUAcpiTableLib.c b/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/Library/BoardAcpiLib/DxeN1xxWUAcpiTableLib.c
index 96a3232fe5..d309bf4e1d 100644
--- a/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/Library/BoardAcpiLib/DxeN1xxWUAcpiTableLib.c
+++ b/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/Library/BoardAcpiLib/DxeN1
+++ xxWUAcpiTableLib.c
@@ -54,7 +54,7 @@ N1xxWUUpdateGlobalNvs (
//
mGlobalNvsArea.Area->LowPowerS0Idle = PcdGet8 (PcdLowPowerS0Idle);
- mGlobalNvsArea.Area->Ps2MouseEnable = FALSE;
+ mGlobalNvsArea.Area->Ps2MouseEnable = PcdGet8 (PcdPs2KbMsEnable);
mGlobalNvsArea.Area->Ps2KbMsEnable = PcdGet8 (PcdPs2KbMsEnable);
}
diff --git a/Platform/Intel/ClevoOpenBoardPkg/Acpi/BoardAcpiDxe/Dsdt/LpcB.asl b/Platform/Intel/ClevoOpenBoardPkg/Acpi/BoardAcpiDxe/Dsdt/LpcB.asl
index 6fbaf3a97f..3ef9aed1e6 100644
--- a/Platform/Intel/ClevoOpenBoardPkg/Acpi/BoardAcpiDxe/Dsdt/LpcB.asl
+++ b/Platform/Intel/ClevoOpenBoardPkg/Acpi/BoardAcpiDxe/Dsdt/LpcB.asl
@@ -55,10 +55,10 @@ scope (\_SB.PCI0.LPCB) {
}
- Device(PS2M) // PS/2 Mouse
+ Device(SYNM) // Synaptics Mouse
{
- Name(_HID,"MSFT0003")
- Name(_CID,EISAID("PNP0F03"))
+ Name(_HID,"SYN1221")
+ Name(_CID,EISAID("PNP0F13"))
Method(_STA)
{
--
2.16.2.windows.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [edk2-devel] [edk2-platforms][PATCH V1 1/1] ClevoOpenBoardPkg/N1xxWU: Enable Synaptics touchpad support in OS
2019-09-20 2:15 [edk2-platforms][PATCH V1 1/1] ClevoOpenBoardPkg/N1xxWU: Enable Synaptics touchpad support in OS Kubacki, Michael A
2019-09-23 7:41 ` [edk2-devel] " Nate DeSimone
@ 2019-09-23 20:27 ` Sinha, Ankit
2019-09-23 22:34 ` Jeremy Soller
2 siblings, 0 replies; 4+ messages in thread
From: Sinha, Ankit @ 2019-09-23 20:27 UTC (permalink / raw)
To: devel@edk2.groups.io, Kubacki, Michael A; +Cc: Desimone, Nathaniel L
Reviewed-by: Ankit Sinha <ankit.sinha@intel.com>
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Kubacki, Michael A
Sent: Thursday, September 19, 2019 7:16 PM
To: devel@edk2.groups.io
Cc: Sinha, Ankit <ankit.sinha@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>
Subject: [edk2-devel] [edk2-platforms][PATCH V1 1/1] ClevoOpenBoardPkg/N1xxWU: Enable Synaptics touchpad support in OS
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2068
Adds the ACPI device for the Synaptics touchpad. With this change, the touchpad device is functional in the OS.
Cc: Ankit Sinha <ankit.sinha@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Signed-off-by: Michael Kubacki <michael.a.kubacki@intel.com>
---
Platform/Intel/ClevoOpenBoardPkg/N1xxWU/Library/BoardAcpiLib/DxeN1xxWUAcpiTableLib.c | 2 +-
Platform/Intel/ClevoOpenBoardPkg/Acpi/BoardAcpiDxe/Dsdt/LpcB.asl | 6 +++---
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/Library/BoardAcpiLib/DxeN1xxWUAcpiTableLib.c b/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/Library/BoardAcpiLib/DxeN1xxWUAcpiTableLib.c
index 96a3232fe5..d309bf4e1d 100644
--- a/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/Library/BoardAcpiLib/DxeN1xxWUAcpiTableLib.c
+++ b/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/Library/BoardAcpiLib/DxeN1
+++ xxWUAcpiTableLib.c
@@ -54,7 +54,7 @@ N1xxWUUpdateGlobalNvs (
//
mGlobalNvsArea.Area->LowPowerS0Idle = PcdGet8 (PcdLowPowerS0Idle);
- mGlobalNvsArea.Area->Ps2MouseEnable = FALSE;
+ mGlobalNvsArea.Area->Ps2MouseEnable = PcdGet8 (PcdPs2KbMsEnable);
mGlobalNvsArea.Area->Ps2KbMsEnable = PcdGet8 (PcdPs2KbMsEnable);
}
diff --git a/Platform/Intel/ClevoOpenBoardPkg/Acpi/BoardAcpiDxe/Dsdt/LpcB.asl b/Platform/Intel/ClevoOpenBoardPkg/Acpi/BoardAcpiDxe/Dsdt/LpcB.asl
index 6fbaf3a97f..3ef9aed1e6 100644
--- a/Platform/Intel/ClevoOpenBoardPkg/Acpi/BoardAcpiDxe/Dsdt/LpcB.asl
+++ b/Platform/Intel/ClevoOpenBoardPkg/Acpi/BoardAcpiDxe/Dsdt/LpcB.asl
@@ -55,10 +55,10 @@ scope (\_SB.PCI0.LPCB) {
}
- Device(PS2M) // PS/2 Mouse
+ Device(SYNM) // Synaptics Mouse
{
- Name(_HID,"MSFT0003")
- Name(_CID,EISAID("PNP0F03"))
+ Name(_HID,"SYN1221")
+ Name(_CID,EISAID("PNP0F13"))
Method(_STA)
{
--
2.16.2.windows.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [edk2-devel] [edk2-platforms][PATCH V1 1/1] ClevoOpenBoardPkg/N1xxWU: Enable Synaptics touchpad support in OS
2019-09-20 2:15 [edk2-platforms][PATCH V1 1/1] ClevoOpenBoardPkg/N1xxWU: Enable Synaptics touchpad support in OS Kubacki, Michael A
2019-09-23 7:41 ` [edk2-devel] " Nate DeSimone
2019-09-23 20:27 ` Sinha, Ankit
@ 2019-09-23 22:34 ` Jeremy Soller
2 siblings, 0 replies; 4+ messages in thread
From: Jeremy Soller @ 2019-09-23 22:34 UTC (permalink / raw)
To: devel, Michael A Kubacki; +Cc: Ankit Sinha, Nathaniel L Desimone
Reviewed-by: Jeremy Soller <jeremy@system76.com>
On Thu, Sep 19, 2019, at 8:15 PM, Kubacki, Michael A wrote:
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2068
>
> Adds the ACPI device for the Synaptics touchpad. With this change,
> the touchpad device is functional in the OS.
>
> Cc: Ankit Sinha <ankit.sinha@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Signed-off-by: Michael Kubacki <michael.a.kubacki@intel.com>
> ---
>
> Platform/Intel/ClevoOpenBoardPkg/N1xxWU/Library/BoardAcpiLib/DxeN1xxWUAcpiTableLib.c | 2 +-
> Platform/Intel/ClevoOpenBoardPkg/Acpi/BoardAcpiDxe/Dsdt/LpcB.asl
> | 6 +++---
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git
> a/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/Library/BoardAcpiLib/DxeN1xxWUAcpiTableLib.c b/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/Library/BoardAcpiLib/DxeN1xxWUAcpiTableLib.c
> index 96a3232fe5..d309bf4e1d 100644
> ---
> a/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/Library/BoardAcpiLib/DxeN1xxWUAcpiTableLib.c
> +++
> b/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/Library/BoardAcpiLib/DxeN1xxWUAcpiTableLib.c
> @@ -54,7 +54,7 @@ N1xxWUUpdateGlobalNvs (
> //
> mGlobalNvsArea.Area->LowPowerS0Idle = PcdGet8 (PcdLowPowerS0Idle);
>
> - mGlobalNvsArea.Area->Ps2MouseEnable = FALSE;
> + mGlobalNvsArea.Area->Ps2MouseEnable = PcdGet8 (PcdPs2KbMsEnable);
> mGlobalNvsArea.Area->Ps2KbMsEnable = PcdGet8 (PcdPs2KbMsEnable);
> }
>
> diff --git
> a/Platform/Intel/ClevoOpenBoardPkg/Acpi/BoardAcpiDxe/Dsdt/LpcB.asl
> b/Platform/Intel/ClevoOpenBoardPkg/Acpi/BoardAcpiDxe/Dsdt/LpcB.asl
> index 6fbaf3a97f..3ef9aed1e6 100644
> --- a/Platform/Intel/ClevoOpenBoardPkg/Acpi/BoardAcpiDxe/Dsdt/LpcB.asl
> +++ b/Platform/Intel/ClevoOpenBoardPkg/Acpi/BoardAcpiDxe/Dsdt/LpcB.asl
> @@ -55,10 +55,10 @@ scope (\_SB.PCI0.LPCB) {
>
> }
>
> - Device(PS2M) // PS/2 Mouse
> + Device(SYNM) // Synaptics Mouse
> {
> - Name(_HID,"MSFT0003")
> - Name(_CID,EISAID("PNP0F03"))
> + Name(_HID,"SYN1221")
> + Name(_CID,EISAID("PNP0F13"))
>
> Method(_STA)
> {
> --
> 2.16.2.windows.1
>
>
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-09-23 22:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-09-20 2:15 [edk2-platforms][PATCH V1 1/1] ClevoOpenBoardPkg/N1xxWU: Enable Synaptics touchpad support in OS Kubacki, Michael A
2019-09-23 7:41 ` [edk2-devel] " Nate DeSimone
2019-09-23 20:27 ` Sinha, Ankit
2019-09-23 22:34 ` Jeremy Soller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox