From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com)
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by groups.io with SMTP; Tue, 23 Jul 2019 00:44:09 -0700
Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mx1.redhat.com (Postfix) with ESMTPS id B217358569;
	Tue, 23 Jul 2019 07:44:08 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-117-52.ams2.redhat.com [10.36.117.52])
	by smtp.corp.redhat.com (Postfix) with ESMTP id 9D4505B684;
	Tue, 23 Jul 2019 07:44:07 +0000 (UTC)
Subject: Re: [edk2-devel] [PATCH] OvmfPkg: enable multiprocessor builds when using build.sh
To: Rebecca Cran <rebecca@bsdio.com>,
 Jordan Justen <jordan.l.justen@intel.com>,
 Ard Biesheuvel <ard.biesheuvel@linaro.org>, devel@edk2.groups.io
References: <20190722005816.96146-1-rebecca@bsdio.com>
 <156377947230.31344.9139528030621143554@jljusten-skl>
 <5313f05d-cd57-3fd0-9a44-4290b64db5a9@redhat.com>
 <156383729562.19762.9432602825677327108@jljusten-skl>
 <db45b3b0-fd89-a0ce-fcd7-6c360e80da44@bsdio.com>
From: "Laszlo Ersek" <lersek@redhat.com>
Message-ID: <9733a473-7dc0-c8e4-18e5-0a1d0f80f3e0@redhat.com>
Date: Tue, 23 Jul 2019 09:44:06 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <db45b3b0-fd89-a0ce-fcd7-6c360e80da44@bsdio.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Tue, 23 Jul 2019 07:44:08 +0000 (UTC)
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 07/23/19 02:00, Rebecca Cran wrote:
> On 2019-07-22 17:14, Jordan Justen wrote:
>>
>> I was suggesting that if they didn't specify -n as a param to
>> build.sh, then build.sh should not send -n to the edk2 build command.
>> The effect would be for the edk2 build command to check
>> Conf/target.txt. By default, I think target.txt will not set
>> THREADNUMBER, so "0" would still be the result.
>>
>> Yet, it would give them the option to set it in Conf/target.txt.
>> Today, since we always use the -n param, target.txt is always ignored
>> for this parameter.
> 
> 
> On a related topic, I wonder if we should add a "-j" parameter if we
> build BaseTools for users (e.g. "make -j4 -C BaseTools")? I've found
> that it can be pretty slow without it: on my system adding -j4 reduces
> build time from 55 seconds to 15. Going higher doesn't seem to produce
> much more benefit: -j32 (on a ThreadRipper system) reduces it to 12 seconds.
> 
> 

Passing

  -j $(getconf _NPROCESSORS_ONLN)

to "make" (for building BaseTools) makes sense, IMO.

Thanks
Laszlo