Re: [edk2-devel] [PATCH 0/4] Auto configure Fsp*BaseAddress PCD

["Laszlo Ersek" <lersek@redhat.com>]

On 07/29/19 13:07, Chiu, Chasel wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1863
> 
> PcdFsp*BaseAddress now will be updated in FDF basing
> on flash map.
> DSC will only define types of those PCDs and always
> having 0 as default.
> New script added to only rebase FSP binary without
> patching DSC file.
> 
> Test: interanl platform booted with this patch.
> 
> Cc: Michael Kubacki <michael.a.kubacki@intel.com>
> Cc: Ankit Sinha <ankit.sinha@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Signed-off-by: Chasel Chiu <chasel.chiu@intel.com>
> 
> Chasel Chiu (4):
>   MinPlatformPkg: Auto configure Fsp*BaseAddress PCD
>   Platform/Intel: Auto configure Fsp*BaseAddress PCD
>   KabylakeOpenBoardPkg: Auto configure Fsp*BaseAddress PCD
>   ClevoOpenBoardPkg: Auto configure Fsp*BaseAddress PCD
> 
>  Platform/Intel/ClevoOpenBoardPkg/N1xxWU/OpenBoardPkg.fdf             |  3 +++
>  Platform/Intel/ClevoOpenBoardPkg/N1xxWU/OpenBoardPkgPcd.dsc          | 12 +++++++++---
>  Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.fdf    |  3 +++
>  Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd.dsc | 12 +++++++++---
>  Platform/Intel/MinPlatformPkg/Tools/Fsp/RebaseFspBinBaseAddress.py   | 96 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  Platform/Intel/build_bios.py                                         |  7 ++-----
>  6 files changed, 122 insertions(+), 11 deletions(-)
>  create mode 100644 Platform/Intel/MinPlatformPkg/Tools/Fsp/RebaseFspBinBaseAddress.py
> 

I think the classification on TianoCore BZ#1863 is wrong. It should be
"EDK2 Platforms", probably. Please update the BZ.


Accordingly, the subject prefix on this patch series should not be
"PATCH", but "edk2-platforms PATCH". No need to resend the v1 patch
series just for this, but if you send a v2, please set the correct
subject prefix:

  git format-patch -v2 --subject-prefix='edk2-platforms PATCH' ...

Thanks
Laszlo