From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com)
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by groups.io with SMTP; Mon, 29 Jul 2019 06:47:07 -0700
Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mx1.redhat.com (Postfix) with ESMTPS id 80083308FB9D;
	Mon, 29 Jul 2019 13:47:06 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-117-240.ams2.redhat.com [10.36.117.240])
	by smtp.corp.redhat.com (Postfix) with ESMTP id 1CC325DAA4;
	Mon, 29 Jul 2019 13:47:04 +0000 (UTC)
Subject: Re: [edk2-devel] [PATCH 0/4] Auto configure Fsp*BaseAddress PCD
To: devel@edk2.groups.io, chasel.chiu@intel.com
Cc: Michael Kubacki <michael.a.kubacki@intel.com>,
 Ankit Sinha <ankit.sinha@intel.com>,
 Nate DeSimone <nathaniel.l.desimone@intel.com>,
 Liming Gao <liming.gao@intel.com>
References: <20190729110715.2312-1-chasel.chiu@intel.com>
From: "Laszlo Ersek" <lersek@redhat.com>
Message-ID: <9737c4be-9667-ddd5-5267-a0c27412a3be@redhat.com>
Date: Mon, 29 Jul 2019 15:47:04 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20190729110715.2312-1-chasel.chiu@intel.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.43]); Mon, 29 Jul 2019 13:47:06 +0000 (UTC)
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 07/29/19 13:07, Chiu, Chasel wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1863
> 
> PcdFsp*BaseAddress now will be updated in FDF basing
> on flash map.
> DSC will only define types of those PCDs and always
> having 0 as default.
> New script added to only rebase FSP binary without
> patching DSC file.
> 
> Test: interanl platform booted with this patch.
> 
> Cc: Michael Kubacki <michael.a.kubacki@intel.com>
> Cc: Ankit Sinha <ankit.sinha@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Signed-off-by: Chasel Chiu <chasel.chiu@intel.com>
> 
> Chasel Chiu (4):
>   MinPlatformPkg: Auto configure Fsp*BaseAddress PCD
>   Platform/Intel: Auto configure Fsp*BaseAddress PCD
>   KabylakeOpenBoardPkg: Auto configure Fsp*BaseAddress PCD
>   ClevoOpenBoardPkg: Auto configure Fsp*BaseAddress PCD
> 
>  Platform/Intel/ClevoOpenBoardPkg/N1xxWU/OpenBoardPkg.fdf             |  3 +++
>  Platform/Intel/ClevoOpenBoardPkg/N1xxWU/OpenBoardPkgPcd.dsc          | 12 +++++++++---
>  Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.fdf    |  3 +++
>  Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd.dsc | 12 +++++++++---
>  Platform/Intel/MinPlatformPkg/Tools/Fsp/RebaseFspBinBaseAddress.py   | 96 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  Platform/Intel/build_bios.py                                         |  7 ++-----
>  6 files changed, 122 insertions(+), 11 deletions(-)
>  create mode 100644 Platform/Intel/MinPlatformPkg/Tools/Fsp/RebaseFspBinBaseAddress.py
> 

I think the classification on TianoCore BZ#1863 is wrong. It should be
"EDK2 Platforms", probably. Please update the BZ.


Accordingly, the subject prefix on this patch series should not be
"PATCH", but "edk2-platforms PATCH". No need to resend the v1 patch
series just for this, but if you send a v2, please set the correct
subject prefix:

  git format-patch -v2 --subject-prefix='edk2-platforms PATCH' ...

Thanks
Laszlo