public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Liming Gao" <liming.gao@intel.com>
To: "Liu, Zhiguang" <zhiguang.liu@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Kinney, Michael D" <michael.d.kinney@intel.com>
Subject: Re: [PATCH 2/2] MdePkg: Use the same VA function for both CLANGPDB and CLANG38
Date: Mon, 3 Feb 2020 13:17:38 +0000	[thread overview]
Message-ID: <975980fc3d1849c2933e218e11cd0c41@intel.com> (raw)
In-Reply-To: <20200203081511.371848-2-zhiguang.liu@intel.com>

Reviewed-by: Liming Gao <liming.gao@intel.com>

> -----Original Message-----
> From: Liu, Zhiguang <zhiguang.liu@intel.com>
> Sent: Monday, February 3, 2020 4:15 PM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming <liming.gao@intel.com>
> Subject: [PATCH 2/2] MdePkg: Use the same VA function for both CLANGPDB and CLANG38
> 
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2415
> 
> For CLANGPDB tool chain and X64, use MS ABI version of GCC built-in macros for
> variable argument lists to be align with CLANG38 tool chain.
> 
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> 
> Signed-off-by: Zhiguang Liu <zhiguang.liu@intel.com>
> ---
>  MdePkg/Include/Base.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/MdePkg/Include/Base.h b/MdePkg/Include/Base.h
> index e0bcd0ae67..33211b96f7 100644
> --- a/MdePkg/Include/Base.h
> +++ b/MdePkg/Include/Base.h
> @@ -623,7 +623,7 @@ typedef char* VA_LIST;
> 
>  #elif defined(__GNUC__) || defined(__clang__)
> 
> -#if defined(MDE_CPU_X64) && !defined(NO_MSABI_VA_FUNCS) && !defined(__clang__)
> +#if defined(MDE_CPU_X64) && !defined(NO_MSABI_VA_FUNCS)
>  //
>  // X64 only. Use MS ABI version of GCC built-in macros for variable argument lists.
>  //
> --
> 2.16.2.windows.1


  reply	other threads:[~2020-02-03 13:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-03  8:15 [PATCH 1/2] BaseTools: append -DNO_MSABI_VA_FUNCS option in CLANGPDB tool chain Zhiguang Liu
2020-02-03  8:15 ` [PATCH 2/2] MdePkg: Use the same VA function for both CLANGPDB and CLANG38 Zhiguang Liu
2020-02-03 13:17   ` Liming Gao [this message]
2020-02-03 13:17 ` [PATCH 1/2] BaseTools: append -DNO_MSABI_VA_FUNCS option in CLANGPDB tool chain Liming Gao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=975980fc3d1849c2933e218e11cd0c41@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox