From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 3F3C2AC0DB2 for ; Tue, 12 Dec 2023 15:28:37 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=MYAAVf1nhR2L3W01o3P92KIZ9sgPIQ+AMCLOMd9gOoI=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1702394915; v=1; b=sO+ttD0iAEfydIS/x3eO/O+PYUycsKmK+ZFDpl9qlPVtyUKTW8XITnQorhuLqBmtwhpaMOfJ JGzTXtJ4GynSpf1Ay5KNyf3tohAnBSF7hy1lM8KGnuzew15EP/lrQbJdlMmhtOBnrf904S9LwGZ Ksds7rKldCfg35zGIc2CYmT0= X-Received: by 127.0.0.2 with SMTP id kvTSYY7687511xGLmhH8gFRS; Tue, 12 Dec 2023 07:28:35 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web11.4418.1702394915140068914 for ; Tue, 12 Dec 2023 07:28:35 -0800 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-439-BTfGhHxQPsyYYcgE2oC6Cw-1; Tue, 12 Dec 2023 10:28:31 -0500 X-MC-Unique: BTfGhHxQPsyYYcgE2oC6Cw-1 X-Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id CFBE385A58C; Tue, 12 Dec 2023 15:28:30 +0000 (UTC) X-Received: from [10.39.192.120] (unknown [10.39.192.120]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 20DAD492BE6; Tue, 12 Dec 2023 15:28:29 +0000 (UTC) Message-ID: <979a081a-eb98-2c08-4119-fcdce5552ca0@redhat.com> Date: Tue, 12 Dec 2023 16:28:29 +0100 MIME-Version: 1.0 Subject: Re: [edk2-devel] [PATCH] DebugLib: Allow -Wunneeded-internal-declaration with clang To: Mike Beaton , Ard Biesheuvel Cc: devel@edk2.groups.io, ardb@google.com References: <20231212084856.118099-1-mjsbeaton@gmail.com> From: "Laszlo Ersek" In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: RPV5HVXHPCkns65nXTMREwAvx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=sO+ttD0i; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 12/12/23 13:57, Mike Beaton wrote: >> You failed to mention where you found this patch. > > It's from https://github.com/acidanthera/audk/commit/dcd0a768b0f > (which actually contains the code described in its commit message, but > I believe some other code, including this specific part, which got > squashed in at some point, and I believe is from the committer, not > the alleged author actually!). > > Would it work to just add that origin commit to the commit message > (given the licensing, which is the same as EDK-II, ofc), or would you > prefer/need an additional Signed-off-by:? (Instead?) > I believe one way to approach it would be to (a) amend the patch with --author="Marvin Häuser " and (b) have S-o-b's from both Marvin and you at the end of the commit message. Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112449): https://edk2.groups.io/g/devel/message/112449 Mute This Topic: https://groups.io/mt/103126777/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-