From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by mx.groups.io with SMTP id smtpd.web10.37589.1679929577991214940 for ; Mon, 27 Mar 2023 08:06:18 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@citrix.com header.s=securemail header.b=DCwCca5f; spf=pass (domain: citrix.com, ip: 216.71.145.142, mailfrom: prvs=44343e547=anthony.perard@citrix.com) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1679929577; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=t0+KHeqS3bSH3y+dRo3UbC1GrGHjukQ2vuT3t0KQ4kk=; b=DCwCca5fK/dBNYZrlzDl6ooisrjoDu9M+dHAZAUruIbKPwlztCja4kOy FsM6REP+o2OyclsWRliudObLTtFqUlVcFs5H69E0fToIM0FHJzX1rAWrW X5n9TchGJF8Yz8Tk6LuRGHeSdoqS+nLaVBL3Uo4H+Y7ZxZ7ANDiKEH6Rr I=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 4.0 X-MesageID: 103429729 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.123 X-Policy: $RELAYED IronPort-Data: A9a23:i4l1MKyTYMfhvsB4mp96t+dYwSrEfRIJ4+MujC+fZmUNrF6WrkUGm jZJC23TMqvbazekco9yYY6/80gBuZXczoBgT1c4riAxQypGp/SeCIXCJC8cHc8wwu7rFxs7s ppEOrEsCOhuExcwcz/0auCJQUFUjP3OHfykTrafYEidfCc8IA85kxVvhuUltYBhhNm9Emult Mj75sbSIzdJ4RYtWo4vw//F+UMHUMja4mtC5QRlP68T5TcyqlFOZH4hDfDpR5fHatE88t6SH 47r0Ly/92XFyBYhYvvNfmHTKxBirhb6ZGBiu1IOM0SQqkEqSh8ai87XAME0e0ZP4whlqvgqo Dl7WT5cfi9yVkHEsLx1vxC1iEiSN4UekFPMCSDXXcB+UyQq2pYjqhljJBheAGEWxgp4KUVz+ 84keAIsVxea2tyU+vW7bdFSu+12eaEHPKtH0p1h5TTQDPJgSpHfWaTao9Rf2V/chOgXQ6yYP ZBAL2MyMlKZOUYn1lQ/UfrSmM+hgGX/dDtJ7kqYv6Mt70DYzRBr0airO93QEjCPbZwNxRrC9 z2crgwVBDkXCI3A1xGo/UiQrcjigT3pV8U9Kbm3o6sCbFq7mTVIVUx+uUGAifqjg16zX/pFJ kAU8zZopq83nGSnQ8fwWzW1rH3e+BEGXMdICKs772ml1qrT5g+CQGwJSDJIY983nMYzSXoh0 Vrht9HoCCNitvuEQHW197GIoDf0Mi8QRUcPfyMJSAIG/9D4iI40iR3LQ5BoF6vdpt/yAz35x XaO6iojnKkei+YK0bm2+RbMhDfEjp/SUgM76AjRdnio4gNweMiuYInAwV3a67BFapaEZliHo HUA3cOZ6YgmCJCGlCWARKMXG62pz/+APHvXhlsHN5ss9T6F/3+lYJAW4Tt7YkxuN64sYSfuZ EbMogB5/pJfPHK2K6RwZuqZAt4mx+v8FN3jUfvTdNdmYZVrcgKDuiZ0aia43X3pkUUqubEyP 9Gca8nEJX8CBL5u1jaeW+YX2rhtzSc7rV4/XriikU7hi+DHIifIF/FcagDmgv0FAL2shDjbw eoPBeqzzAwCbs/EJSnwybAuBAVfRZQkPqwau/C7Z8bafFU3Rj98UaSJqV8yU9c7xvoIz48k6 ln4AxYFkwSn2BUrPC3QMhhehKXTsYGTRJ7RFQglJh6W1ncqeu5DB49PJsJsLdHLGAGOpMOYr sXpmO3aWJyjshydp1wggWDV9eSOjiiDiwOUJDaCazMiZZNmTAGh0oa6IVq/qXRQX3Dv5JRWT 1icOuTzH/I+q/lKVp6KOJpDMXvo1ZTipA6CdxSReYQCEKkd2INrNzbwnpcKHi34Ej2anmHy/ 1/PUX8lSRzl/9ddHC/h2frV8O9E0oJWQiJnIoUsxerpZXKKojbynuetko+gJFjgaY89w436D c098h02GKZf9LqWm+KQy4pW8J8= IronPort-HdrOrdr: A9a23:YXo3O6ri59V1+wwR8My9ds0aV5rseYIsimQD101hICG8cqSj5q aTdZUgtSMc7Qx7ZJhOo7G90cW7MBbhHP1OkPAs1NWZLXHbUQKTRekMg7cKqweQYBEWndQtsZ uIHZIOb+HYPBxWt+u/xi+SeuxN/DCAysqVrNab9VtWCStNTI5BwTtDIju6NGozfiV6bKBJd6 a0145Jpz+tY3QFYt7TPBQ4duLevcDMkJ78QTNuPW9E1DWz X-IronPort-AV: E=Sophos;i="5.98,294,1673931600"; d="scan'208";a="103429729" Date: Mon, 27 Mar 2023 16:06:03 +0100 From: "Anthony PERARD" To: Gerd Hoffmann CC: , Tom Lendacky , Jiewen Yao , Erdem Aktas , Jordan Justen , Oliver Steffen , Min Xu , Michael Roth , James Bottomley , Pawel Polawski , Ard Biesheuvel , Julien Grall Subject: Re: [PATCH v2 2/3] OvmfPkg/PlatformInitLib: move mmconfig to 0xe0000000 Message-ID: <979ed389-56f4-4fc4-8a2b-7cbfa93143eb@perard> References: <20230307065454.1434251-1-kraxel@redhat.com> <20230307065454.1434251-3-kraxel@redhat.com> MIME-Version: 1.0 In-Reply-To: <20230307065454.1434251-3-kraxel@redhat.com> Return-Path: anthony.perard@citrix.com Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline On Tue, Mar 07, 2023 at 07:54:53AM +0100, Gerd Hoffmann wrote: > Also swap the ordering of 32bit PCI MMIO window on q35, i.e. use the > room between end of low memory and the start of the mmconfig bar. > > With a typical configuration on modern qemu with gigabyte-aligned memory > the MMIO window start at 0x8000000, sized 1532 MB. In case there is > memory present above 0x80000000 the window will start at 0xc0000000 > instead, with 512 MB size. > > This depends on qemu commit 4a4418369d6d ("q35: fix mmconfig and > PCI0._CRS"), so it raises the bar for the lowest supported version > to qemu 4.1 (released Aug 2019). Maybe this new version requirement should be noted in OvmfPkg/README, but I'm not sure were as it affect only machine started with Q35. > diff --git a/OvmfPkg/OvmfXen.dsc b/OvmfPkg/OvmfXen.dsc > index c328987e8432..18144d9a6d94 100644 > --- a/OvmfPkg/OvmfXen.dsc > +++ b/OvmfPkg/OvmfXen.dsc > @@ -434,7 +434,7 @@ [PcdsFixedAtBuild] > # > # On Q35 machine types that QEMU intends to support in the long term, QEMU > # never lets the RAM below 4 GB exceed 2816 MB. > - gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress|0xB0000000 > + gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress|0xE0000000 Could you remove this change? OvmfXen doesn't use PlatformInitLib, and we still have worked to do to be able to use Q35 in Xen guest. I think the rest looks fine, so: Reviewed-by: Anthony PERARD Thanks, -- Anthony PERARD