From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 16CF4D800D7 for ; Fri, 22 Dec 2023 01:14:39 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=eLT2sbJmcwN5jj+abM07Cv29aYU02NCd8N4fgjhcLDM=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20140610; t=1703207678; v=1; b=RjGzExW5VQ2HWj6OBkp0iLnIwGqHkj67UHj5e5dYdWlAXzHdMHWH21WC9BEO3Hj0CESZOYPq xzlOYJh50Z8A0nNWPuh2c2PTAaV300/haCb0OL8VHmI/szSo5Qe2kHFqEj2fy2bsf6yWz9YM6hx pJBDwqanP9K5fJemdoBkYFr0= X-Received: by 127.0.0.2 with SMTP id xRBxYY7687511xuV60iFbLjn; Thu, 21 Dec 2023 17:14:38 -0800 X-Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by mx.groups.io with SMTP id smtpd.web11.10005.1703207676878185511 for ; Thu, 21 Dec 2023 17:14:37 -0800 X-Received: from loongson.cn (unknown [10.40.24.149]) by gateway (Coremail) with SMTP id _____8DxBOv44oRl060DAA--.14605S3; Fri, 22 Dec 2023 09:14:32 +0800 (CST) X-Received: from [10.40.24.149] (unknown [10.40.24.149]) by localhost.localdomain (Coremail) with SMTP id AQAAf8Bxbb724oRlqb8EAA--.16998S3; Fri, 22 Dec 2023 09:14:30 +0800 (CST) Message-ID: <97c6da30-758d-48cd-a3c9-558262144f77@loongson.cn> Date: Fri, 22 Dec 2023 09:14:30 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH v4 19/37] UefiCpuPkg: Add MMIO method in CpuIo2Dxe To: devel@edk2.groups.io, ardb@kernel.org, "Ni, Ray" Cc: "Kumar, Rahul R" , Gerd Hoffmann , Leif Lindholm , Ard Biesheuvel , Sami Mujawar References: <20231212130932.2467028-1-lichao@loongson.cn> <17A017C201FEB90D.32321@groups.io> <9014a7b3-095c-42b1-a9ef-5a388818385d@loongson.cn> <0a00f876-0bc5-4cf7-9252-b21520463034@loongson.cn> From: "Chao Li" In-Reply-To: X-CM-TRANSID: AQAAf8Bxbb724oRlqb8EAA--.16998S3 X-CM-SenderInfo: xolfxt3r6o00pqjv00gofq/1tbiAQANCGWDoK4QTwABsy X-Coremail-Antispam: 1Uk129KBj93XoWrtF4Duw1ftF47tFy5uw1xJFc_yoW8Jr4xp3 y7tr90yr1jgr1jv3yUGw1UZa1I9wsavF98Xw1DA340vFn7GFZ2qFyxG3yDX3yUGr1rZa1U XF4Fvw4kJFWjgagCm3ZEXasCq-sJn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7KY7ZEXa sCq-sGcSsGvfJ3UbIjqfuFe4nvWSU5nxnvy29KBjDU0xBIdaVrnRJUUUymb4IE77IF4wAF F20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r 1Y6r17M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAF wI0_JFI_Gr1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Gr0_Cr1l84ACjcxK6I8E87Iv67 AKxVW8JVWxJwA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_Gr0_Gr1UM2AIxVAIcxkEcVAq07x2 0xvEncxIr21l57IF6xkI12xvs2x26I8E6xACxx1lYx0E2Ix0cI8IcVAFwI0_JrI_JrylYx 0Ex4A2jsIE14v26r1j6r4UMcvjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvEwIxGrwCjr7xv wVCIw2I0I7xG6c02F41l42xK82IYc2Ij64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2 IqxVAqx4xG67AKxVWUGVWUWwC20s026x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v2 6r1q6r43MIIYrxkI7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2 IY6xkF7I0E14v26r1j6r4UMIIF0xvE42xK8VAvwI8IcIk0rVWUJVWUCwCI42IY6I8E87Iv 67AKxVWUJVW8JwCI42IY6I8E87Iv6xkF7I0E14v26r1j6r4UYxBIdaVFxhVjvjDU0xZFpf 9x07UAWrXUUUUU= Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lichao@loongson.cn List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: EfW6p426vkJa0BOeEmgXH3bdx7686176AA= Content-Type: multipart/alternative; boundary="------------Q2uqlx078RzusSZ4rTlMBiiV" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=RjGzExW5; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=none --------------Q2uqlx078RzusSZ4rTlMBiiV Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Thanks, Chao On 2023/12/21 21:59, Ard Biesheuvel wrote: > On Thu, 21 Dec 2023 at 13:41, Chao Li wrote: > ... >> A given platform will either be able to use port IO, or it will need >> to use MMIO translation. So a driver that can do both based on a PCD >> is not very useful, it makes more sense to have two different drivers, >> and the platform incorporates the one it can use. >> >> Ok, I get it, I think you are more inclined to move the ArmCpuIo2Dxe to = a new place and rename it, maybe: CpuMmio2Dxe, while some platforms choose = the different CpuIo2 drvier by themselves when building FW, right? >> > Yes. Ok, I agree. If there are no issues with Ray, I will adjust this patch=20 in V5. I tund is move it under UefiCpuPkg and name it CpuMmio2Dxe, it=20 will be in the same directory as CpuIo2Dxe, is that OK? Ray, what do you think of this plan? > > >=20 > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112823): https://edk2.groups.io/g/devel/message/112823 Mute This Topic: https://groups.io/mt/103261693/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --------------Q2uqlx078RzusSZ4rTlMBiiV Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable



=
Thanks,
Chao
On 2023/12/21 21:59, Ard Biesheuvel wrote:
On Thu, 21 Dec 2023 at 13:41, =
Chao Li <lichao@loongson.cn> wrote:


      

      
...


      

        
A given platform will either=
 be able to use port IO, or it will need
to use MMIO translation. So a driver that can do both based on a PCD
is not very useful, it makes more sense to have two different drivers,
and the platform incorporates the one it can use.

Ok, I get it, I think you are more inclined to move the ArmCpuIo2Dxe to a n=
ew place and rename it, maybe: CpuMmio2Dxe, while some platforms choose the=
 different CpuIo2 drvier by themselves when building FW, right?



      

      
Yes.

    

    
Ok, I agree. If there are no issues with Ray, I will adjust this
      patch in V5. I tund is move it under UefiCpuPkg and name it
      CpuMmio2Dxe, it will be in the same directory as CpuIo2Dxe, is
      that OK?

    

    
Ray, what do you think of this plan?

    

    

      






    

  




_._,_._,_





Groups.io Links:



 =20
    You receive all messages sent to this group.
 =20
 =20




View/Reply Online (#112823) |


 =20

|

  Mute=
 This Topic


| New Topic







Your Subscriptio=
n |
Contact Group Owner |

Unsubscribe

 [rebecca@openfw.io]


_._,_._,_



--------------Q2uqlx078RzusSZ4rTlMBiiV--