From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.158.5]) by mx.groups.io with SMTP id smtpd.web11.5902.1648557164766470157 for ; Tue, 29 Mar 2022 05:32:45 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@ibm.com header.s=pp1 header.b=mTYNDxwX; spf=pass (domain: linux.ibm.com, ip: 148.163.158.5, mailfrom: dovmurik@linux.ibm.com) Received: from pps.filterd (m0098420.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 22TAtwaf021595; Tue, 29 Mar 2022 12:32:42 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=jKMGAuPAK3Cdyyg6Dt6rWmaGKWOXOkNUgpXzhjt0HLY=; b=mTYNDxwX9Plnz/vyiz038xSrHhVdcqBw1iXdKjFV+mCuYdF1W9bCbpCj/kRrMyZjlFUj 3VyN13OhtQRld8NqJhcMbXDq013Y1AYeKkTpijncZI+ja1NkaFd8HADRkJb9C+keI0tR g12ANLTbR9Lg3FTTLDD7ALWJqa9gyfKb0chQ4HXHQiKRkFK/qCx2O+wykDPLeewy+laC ak4V0C5XyLsb5F9dLXuEWBk9bM0HoEDP6BuKATQRQrKsfYF1mLCtk7B0tmdhuKLrow9L Hs7Y/aTTSQ/ylw8eilpfhG5rbvDvuXISGEa82aI0RRugxKYU2CFlx4Xl+JG6sM1PWBgp pg== Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-001b2d01.pphosted.com with ESMTP id 3f40swhy93-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 29 Mar 2022 12:32:42 +0000 Received: from m0098420.ppops.net (m0098420.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 22TBSXQl008996; Tue, 29 Mar 2022 12:32:42 GMT Received: from ppma05wdc.us.ibm.com (1b.90.2fa9.ip4.static.sl-reverse.com [169.47.144.27]) by mx0b-001b2d01.pphosted.com with ESMTP id 3f40swhy8u-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 29 Mar 2022 12:32:41 +0000 Received: from pps.filterd (ppma05wdc.us.ibm.com [127.0.0.1]) by ppma05wdc.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 22TCS7PJ016813; Tue, 29 Mar 2022 12:32:41 GMT Received: from b01cxnp23033.gho.pok.ibm.com (b01cxnp23033.gho.pok.ibm.com [9.57.198.28]) by ppma05wdc.us.ibm.com with ESMTP id 3f1tf9vdx3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 29 Mar 2022 12:32:41 +0000 Received: from b01ledav004.gho.pok.ibm.com (b01ledav004.gho.pok.ibm.com [9.57.199.109]) by b01cxnp23033.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 22TCWeCp45023518 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 29 Mar 2022 12:32:40 GMT Received: from b01ledav004.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 84CA311206F; Tue, 29 Mar 2022 12:32:40 +0000 (GMT) Received: from b01ledav004.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5D220112062; Tue, 29 Mar 2022 12:32:38 +0000 (GMT) Received: from [9.160.79.229] (unknown [9.160.79.229]) by b01ledav004.gho.pok.ibm.com (Postfix) with ESMTP; Tue, 29 Mar 2022 12:32:38 +0000 (GMT) Message-ID: <97d772ff-d247-cd08-a08f-b9e0137b63fe@linux.ibm.com> Date: Tue, 29 Mar 2022 15:32:36 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH 1/2] OvmfPkg/AmdSev: Reorder MEMFD pages to match the order in OvmfPkgX64.fdf To: Gerd Hoffmann Cc: devel@edk2.groups.io, Ard Biesheuvel , Jiewen Yao , Jordan Justen , Brijesh Singh , Erdem Aktas , James Bottomley , Min Xu , Tom Lendacky , Tobin Feldman-Fitzthum , Dov Murik References: <20220328184530.86797-1-dovmurik@linux.ibm.com> <20220328184530.86797-2-dovmurik@linux.ibm.com> <20220329113610.cbbj3iigjimnsska@sirius.home.kraxel.org> From: "Dov Murik" In-Reply-To: <20220329113610.cbbj3iigjimnsska@sirius.home.kraxel.org> X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: w03XbEdsJjeRAc4Ykq1NoEDXNszUQKce X-Proofpoint-GUID: fuIbM5X4NEHugPS9nIY-xwmgKSb43bcB X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.850,Hydra:6.0.425,FMLib:17.11.64.514 definitions=2022-03-29_04,2022-03-29_01,2022-02-23_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 phishscore=0 bulkscore=0 impostorscore=0 mlxlogscore=999 clxscore=1015 malwarescore=0 spamscore=0 lowpriorityscore=0 priorityscore=1501 mlxscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000 definitions=main-2203290076 Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Thanks Gerd for reviewing. On 29/03/2022 14:36, Gerd Hoffmann wrote: > On Mon, Mar 28, 2022 at 06:45:29PM +0000, Dov Murik wrote: >> Reorder the pages in the MEMFD section of AmdSevX64.fdf so that it >> matches the same order used in OvmfPkgX64.fdf. > > Makes sense. > > Acked-by: Gerd Hoffmann Thanks. > > Maybe also move this to a common include file, so it is less likely that > they run out of sync again? > I was contemplating that, but wasn't sure (I only use OvmfPkgX64 and AmdSevX64 in my testing). Is it common in edk2? Would it apply to other OvmfPkg targets? I see similar MEMFD in CloudHvX64.fdf . -Dov