From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mx.groups.io with SMTP id smtpd.web10.79422.1679591189424670117 for ; Thu, 23 Mar 2023 10:06:29 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="signature has expired" header.i=@bsdio.com header.s=fm3 header.b=jcj5mmLQ; spf=pass (domain: bsdio.com, ip: 66.111.4.29, mailfrom: rebecca@bsdio.com) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 6990B5C0058; Thu, 23 Mar 2023 13:06:28 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Thu, 23 Mar 2023 13:06:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdio.com; h=cc :content-transfer-encoding:content-type:content-type:date:date :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1679591188; x=1679677588; bh=COHWGSB0gk+0s/zq2GoHn7wbxKd21eiKkCM wQ9kuCZI=; b=jcj5mmLQ/mQTA2UVcQlI7A8mKWmZ9iyDlxBEeLzNZjpRE96AjO4 ZEHxzmLgtdKHasOk99HIvuH3mjPUoQ4pTQOp5ByqYwZ6onH93LlI7sUG38k/Nrkw dGWDwO5Q2FXdP4kbe3wJNKZsSXpKpeiZd7nQW0tFmLkulwjm4NnMMEnzI/VMNa1w vNNoZWp1NVwt1RoK5sU0uuOYrjITmrMC70w1lY/Ft5hnU84uPAmPztbjDouDkpP5 0y8/xRklSdaCcS0waaDDit/yl6ZSYabGMaVtDkW0Dwb84Br90YDZ9edEy5H+/4Hc JnZXYLXPeGRT83sCTyhrTxJ1d/qMnv+MlAg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1679591188; x= 1679677588; bh=COHWGSB0gk+0s/zq2GoHn7wbxKd21eiKkCMwQ9kuCZI=; b=l ATVpW0bw/sYtV0oAncnmUDxMoYIuHzzhT6JRUkwdEnDpry+nhaGBDmMY929OKVBj bT4gpi7PK/bekpveXtk1YVd9ahA7Dd8Ket613ipsYL/HlneEVbVVTThyGsbSG+tU 586M1xYymThmD9t+cPEhUnpuTRuXzUP9jaCB6HlGHYu/nyL4tcIh6p7OzlvZPm+S RxjGU0xCQj0bLNjlAycTAJKKenITpJBz/y5UuSYM6s2E1f3KofYyjnQwAZVObtNG R4AYu+/W7kPEs8WcvlVow4foetVi6S4Qji7Phlp52ymso0GYRXxjdT/JvOVzfTQ4 if7NZEGkW8d4+5soTSrYw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdeggedgleehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvfhfhjggtgfesthejredttdefjeenucfhrhhomheptfgvsggv tggtrgcuvehrrghnuceorhgvsggvtggtrgessghsughiohdrtghomheqnecuggftrfgrth htvghrnhepleduvedtledtvedvuedugeeuudeiiedtueduvdffueekfeejffduvdetjeev ffdvnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprh gvsggvtggtrgessghsughiohdrtghomh X-ME-Proxy: Feedback-ID: i5b994698:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 23 Mar 2023 13:06:27 -0400 (EDT) Message-ID: <97e19157-da2e-918b-b384-e59288010602@bsdio.com> Date: Thu, 23 Mar 2023 11:06:26 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH 2/3] BaseTools: Replace duplicate __PcdSet prototype with __PcdGet To: devel@edk2.groups.io, Bob Feng , Liming Gao , Yuwei Chen References: <20230225005431.12173-1-rebecca@bsdio.com> <20230225005431.12173-3-rebecca@bsdio.com> From: "Rebecca Cran" In-Reply-To: <20230225005431.12173-3-rebecca@bsdio.com> Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Liming, Could you review this patch please? I've dropped the 3rd patch which was running Uncrustify over the code, so this is the only one left before I can merge the series. Thanks. Rebecca Cran On 2/24/23 5:54 PM, Rebecca Cran wrote: > Replace the duplicate __PcdSet prototype in PcdValueCommon.h > with the prototype for __PcdGet. > > Signed-off-by: Rebecca Cran > --- > BaseTools/Source/C/Common/PcdValueCommon.h | 13 ++++++------- > 1 file changed, 6 insertions(+), 7 deletions(-) > > diff --git a/BaseTools/Source/C/Common/PcdValueCommon.h b/BaseTools/Source/C/Common/PcdValueCommon.h > index 02ef803be479..7dac5bd92dbc 100644 > --- a/BaseTools/Source/C/Common/PcdValueCommon.h > +++ b/BaseTools/Source/C/Common/PcdValueCommon.h > @@ -78,13 +78,12 @@ __PcdSet ( > > @return PCD value > **/ > -VOID > -__PcdSet ( > - CHAR8 *SkuName OPTIONAL, > - CHAR8 *DefaultValueName OPTIONAL, > - CHAR8 *TokenSpaceGuidName, > - CHAR8 *TokenName, > - UINT64 Value > +UINT64 > +__PcdGet ( > + CHAR8 *SkuName OPTIONAL, > + CHAR8 *DefaultValueName OPTIONAL, > + CHAR8 *TokenSpaceGuidName, > + CHAR8 *TokenName > ) > ; >