[PATCH] UefiPayloadPkg: Boot mode in PHIT HOB will not be updated

public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed

* [PATCH] UefiPayloadPkg: Boot mode in PHIT HOB will not be updated
@ 2022-11-03  9:11 victorx.hsu
  2022-11-03  9:14 ` Guo, Gua
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: victorx.hsu @ 2022-11-03  9:11 UTC (permalink / raw)
  To: devel; +Cc: VictorX Hsu, Guo Dong, Ray Ni, James Lu, Gua Guo

From: VictorX Hsu <victorx.hsu@intel.com>

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4136

System will depend on Boot Mode value to do different behavior
Update during Capsule Update process. So UPL need to support
update boot mode.

Cc: Guo Dong <guo.dong@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: James Lu <james.lu@intel.com>
Cc: Gua Guo <gua.guo@intel.com>
Signed-off-by: VictorX Hsu <victorx.hsu@intel.com>
---
 UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.c b/UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.c
index edb3c20471..2ae6b088ab 100644
--- a/UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.c
+++ b/UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.c
@@ -309,6 +309,7 @@ BuildHobs (
   EFI_HOB_FIRMWARE_VOLUME       *FvHob;
   UNIVERSAL_PAYLOAD_ACPI_TABLE  *AcpiTable;
   ACPI_BOARD_INFO               *AcpiBoardInfo;
+  EFI_HOB_HANDOFF_INFO_TABLE    *HobInfo;
 
   Hob.Raw           = (UINT8 *)BootloaderParameter;
   MinimalNeededSize = FixedPcdGet32 (PcdSystemMemoryUefiRegionSize);
@@ -368,7 +369,8 @@ BuildHobs (
     MemoryTop        = FreeMemoryTop;
   }
 
-  HobConstructor ((VOID *)(UINTN)MemoryBottom, (VOID *)(UINTN)MemoryTop, (VOID *)(UINTN)FreeMemoryBottom, (VOID *)(UINTN)FreeMemoryTop);
+  HobInfo = HobConstructor ((VOID *)(UINTN)MemoryBottom, (VOID *)(UINTN)MemoryTop, (VOID *)(UINTN)FreeMemoryBottom, (VOID *)(UINTN)FreeMemoryTop);
+  HobInfo->BootMode = Hob.HandoffInformationTable->BootMode;
   //
   // From now on, mHobList will point to the new Hob range.
   //
-- 
2.28.0.windows.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] UefiPayloadPkg: Boot mode in PHIT HOB will not be updated
  2022-11-03  9:11 [PATCH] UefiPayloadPkg: Boot mode in PHIT HOB will not be updated victorx.hsu
@ 2022-11-03  9:14 ` Guo, Gua
  2022-11-03 10:12 ` Lu, James
  2022-11-03 14:09 ` Guo Dong
  2 siblings, 0 replies; 4+ messages in thread
From: Guo, Gua @ 2022-11-03  9:14 UTC (permalink / raw)
  To: Hsu, VictorX, devel@edk2.groups.io; +Cc: Dong, Guo, Ni, Ray, Lu, James

Give + 1, it can help to unlock Capsule Update through have correct Boot Mode value.

Reviewed-by: Gua Guo <gua.guo@intel.com>
-----Original Message-----
From: Hsu, VictorX <victorx.hsu@intel.com> 
Sent: Thursday, November 3, 2022 5:11 PM
To: devel@edk2.groups.io
Cc: Hsu, VictorX <victorx.hsu@intel.com>; Dong, Guo <guo.dong@intel.com>; Ni, Ray <ray.ni@intel.com>; Lu, James <james.lu@intel.com>; Guo, Gua <gua.guo@intel.com>
Subject: [PATCH] UefiPayloadPkg: Boot mode in PHIT HOB will not be updated

From: VictorX Hsu <victorx.hsu@intel.com>

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4136

System will depend on Boot Mode value to do different behavior Update during Capsule Update process. So UPL need to support update boot mode.

Cc: Guo Dong <guo.dong@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: James Lu <james.lu@intel.com>
Cc: Gua Guo <gua.guo@intel.com>
Signed-off-by: VictorX Hsu <victorx.hsu@intel.com>
---
 UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.c b/UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.c
index edb3c20471..2ae6b088ab 100644
--- a/UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.c
+++ b/UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.c
@@ -309,6 +309,7 @@ BuildHobs (
   EFI_HOB_FIRMWARE_VOLUME       *FvHob;   UNIVERSAL_PAYLOAD_ACPI_TABLE  *AcpiTable;   ACPI_BOARD_INFO               *AcpiBoardInfo;+  EFI_HOB_HANDOFF_INFO_TABLE    *HobInfo;    Hob.Raw           = (UINT8 *)BootloaderParameter;   MinimalNeededSize = FixedPcdGet32 (PcdSystemMemoryUefiRegionSize);@@ -368,7 +369,8 @@ BuildHobs (
     MemoryTop        = FreeMemoryTop;   } -  HobConstructor ((VOID *)(UINTN)MemoryBottom, (VOID *)(UINTN)MemoryTop, (VOID *)(UINTN)FreeMemoryBottom, (VOID *)(UINTN)FreeMemoryTop);+  HobInfo = HobConstructor ((VOID *)(UINTN)MemoryBottom, (VOID *)(UINTN)MemoryTop, (VOID *)(UINTN)FreeMemoryBottom, (VOID *)(UINTN)FreeMemoryTop);+  HobInfo->BootMode = Hob.HandoffInformationTable->BootMode;   //   // From now on, mHobList will point to the new Hob range.   //-- 
2.28.0.windows.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] UefiPayloadPkg: Boot mode in PHIT HOB will not be updated
  2022-11-03  9:11 [PATCH] UefiPayloadPkg: Boot mode in PHIT HOB will not be updated victorx.hsu
  2022-11-03  9:14 ` Guo, Gua
@ 2022-11-03 10:12 ` Lu, James
  2022-11-03 14:09 ` Guo Dong
  2 siblings, 0 replies; 4+ messages in thread
From: Lu, James @ 2022-11-03 10:12 UTC (permalink / raw)
  To: Hsu, VictorX, devel@edk2.groups.io; +Cc: Dong, Guo, Ni, Ray, Guo, Gua

Reviewed-by: James Lu <james.lu@intel.com>

-----Original Message-----
From: Hsu, VictorX <victorx.hsu@intel.com> 
Sent: Thursday, November 3, 2022 5:11 PM
To: devel@edk2.groups.io
Cc: Hsu, VictorX <victorx.hsu@intel.com>; Dong, Guo <guo.dong@intel.com>; Ni, Ray <ray.ni@intel.com>; Lu, James <james.lu@intel.com>; Guo, Gua <gua.guo@intel.com>
Subject: [PATCH] UefiPayloadPkg: Boot mode in PHIT HOB will not be updated

From: VictorX Hsu <victorx.hsu@intel.com>

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4136

System will depend on Boot Mode value to do different behavior Update during Capsule Update process. So UPL need to support update boot mode.

Cc: Guo Dong <guo.dong@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: James Lu <james.lu@intel.com>
Cc: Gua Guo <gua.guo@intel.com>
Signed-off-by: VictorX Hsu <victorx.hsu@intel.com>
---
 UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.c b/UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.c
index edb3c20471..2ae6b088ab 100644
--- a/UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.c
+++ b/UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.c
@@ -309,6 +309,7 @@ BuildHobs (
   EFI_HOB_FIRMWARE_VOLUME       *FvHob;   UNIVERSAL_PAYLOAD_ACPI_TABLE  *AcpiTable;   ACPI_BOARD_INFO               *AcpiBoardInfo;+  EFI_HOB_HANDOFF_INFO_TABLE    *HobInfo;    Hob.Raw           = (UINT8 *)BootloaderParameter;   MinimalNeededSize = FixedPcdGet32 (PcdSystemMemoryUefiRegionSize);@@ -368,7 +369,8 @@ BuildHobs (
     MemoryTop        = FreeMemoryTop;   } -  HobConstructor ((VOID *)(UINTN)MemoryBottom, (VOID *)(UINTN)MemoryTop, (VOID *)(UINTN)FreeMemoryBottom, (VOID *)(UINTN)FreeMemoryTop);+  HobInfo = HobConstructor ((VOID *)(UINTN)MemoryBottom, (VOID *)(UINTN)MemoryTop, (VOID *)(UINTN)FreeMemoryBottom, (VOID *)(UINTN)FreeMemoryTop);+  HobInfo->BootMode = Hob.HandoffInformationTable->BootMode;   //   // From now on, mHobList will point to the new Hob range.   //-- 
2.28.0.windows.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] UefiPayloadPkg: Boot mode in PHIT HOB will not be updated
  2022-11-03  9:11 [PATCH] UefiPayloadPkg: Boot mode in PHIT HOB will not be updated victorx.hsu
  2022-11-03  9:14 ` Guo, Gua
  2022-11-03 10:12 ` Lu, James
@ 2022-11-03 14:09 ` Guo Dong
  2 siblings, 0 replies; 4+ messages in thread
From: Guo Dong @ 2022-11-03 14:09 UTC (permalink / raw)
  To: Hsu, VictorX, devel@edk2.groups.io; +Cc: Ni, Ray, Lu, James, Guo, Gua


Reviewed-by: Guo Dong <guo.dong@intel.com>

-----Original Message-----
From: Hsu, VictorX <victorx.hsu@intel.com> 
Sent: Thursday, November 3, 2022 2:11 AM
To: devel@edk2.groups.io
Cc: Hsu, VictorX <victorx.hsu@intel.com>; Dong, Guo <guo.dong@intel.com>; Ni, Ray <ray.ni@intel.com>; Lu, James <james.lu@intel.com>; Guo, Gua <gua.guo@intel.com>
Subject: [PATCH] UefiPayloadPkg: Boot mode in PHIT HOB will not be updated

From: VictorX Hsu <victorx.hsu@intel.com>

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4136

System will depend on Boot Mode value to do different behavior Update during Capsule Update process. So UPL need to support update boot mode.

Cc: Guo Dong <guo.dong@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: James Lu <james.lu@intel.com>
Cc: Gua Guo <gua.guo@intel.com>
Signed-off-by: VictorX Hsu <victorx.hsu@intel.com>
---
 UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.c b/UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.c
index edb3c20471..2ae6b088ab 100644
--- a/UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.c
+++ b/UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.c
@@ -309,6 +309,7 @@ BuildHobs (
   EFI_HOB_FIRMWARE_VOLUME       *FvHob;   UNIVERSAL_PAYLOAD_ACPI_TABLE  *AcpiTable;   ACPI_BOARD_INFO               *AcpiBoardInfo;+  EFI_HOB_HANDOFF_INFO_TABLE    *HobInfo;    Hob.Raw           = (UINT8 *)BootloaderParameter;   MinimalNeededSize = FixedPcdGet32 (PcdSystemMemoryUefiRegionSize);@@ -368,7 +369,8 @@ BuildHobs (
     MemoryTop        = FreeMemoryTop;   } -  HobConstructor ((VOID *)(UINTN)MemoryBottom, (VOID *)(UINTN)MemoryTop, (VOID *)(UINTN)FreeMemoryBottom, (VOID *)(UINTN)FreeMemoryTop);+  HobInfo = HobConstructor ((VOID *)(UINTN)MemoryBottom, (VOID *)(UINTN)MemoryTop, (VOID *)(UINTN)FreeMemoryBottom, (VOID *)(UINTN)FreeMemoryTop);+  HobInfo->BootMode = Hob.HandoffInformationTable->BootMode;   //   // From now on, mHobList will point to the new Hob range.   //-- 
2.28.0.windows.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-11-03 14:15 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-03  9:11 [PATCH] UefiPayloadPkg: Boot mode in PHIT HOB will not be updated victorx.hsu
2022-11-03  9:14 ` Guo, Gua
2022-11-03 10:12 ` Lu, James
2022-11-03 14:09 ` Guo Dong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox