public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ni, Ruiyu" <ruiyu.ni@Intel.com>
To: "Duran, Leo" <leo.duran@amd.com>,
	Laszlo Ersek <lersek@redhat.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Dong, Eric" <eric.dong@intel.com>
Subject: Re: [PATCH] UefiCpuPkg/MtrrLib: Add flag to skip disabling MTRRs prior to MTRR change.
Date: Fri, 14 Sep 2018 12:44:12 +0800	[thread overview]
Message-ID: <981751ac-68a0-ea2c-7985-2562d1916560@Intel.com> (raw)
In-Reply-To: <CY4PR12MB18154B5CBEC051A27DB77164F91A0@CY4PR12MB1815.namprd12.prod.outlook.com>

On 9/14/2018 3:31 AM, Duran, Leo wrote:
> 
> 
>> -----Original Message-----
>> From: Ni, Ruiyu <ruiyu.ni@intel.com>
>> Sent: Wednesday, September 12, 2018 9:39 PM
>> To: Duran, Leo <leo.duran@amd.com>; Laszlo Ersek <lersek@redhat.com>;
>> edk2-devel@lists.01.org
>> Cc: Dong, Eric <eric.dong@intel.com>
>> Subject: RE: [PATCH] UefiCpuPkg/MtrrLib: Add flag to skip disabling MTRRs
>> prior to MTRR change.
>>
>> Leo,
>> Sorry I was in leave yesterday so didn't see the mail.
>> Which MSRs are shared? Only the MSR_IA32_MTRR_DEF_TYPE_REGISTER?
>> Or all the MSRs that configures the CPU MTRR setting?
>>
> 
> Hi Ray,
> The MTTR config MSRs are also shared by threads within a core.
> 

Hi Leo,
Do you think that fixing the caller is more proper?

>> I also agree with Laszlo's comments to fix the caller if all MSRs relating to
>> MTRR are shared.
>> That will be to fix MpInitLib and CpuDxe driver.
>>
>> Thanks/Ray
>>


  reply	other threads:[~2018-09-14  4:43 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-11 15:41 [PATCH] Add flag to skip disabling MTRRs Leo Duran
2018-09-11 15:41 ` [PATCH] UefiCpuPkg/MtrrLib: Add flag to skip disabling MTRRs prior to MTRR change Leo Duran
2018-09-11 18:49   ` Laszlo Ersek
2018-09-11 19:47     ` Duran, Leo
2018-09-12  9:54       ` Laszlo Ersek
2018-09-12 15:17         ` Duran, Leo
2018-09-12 17:59           ` Laszlo Ersek
2018-09-12 18:21             ` Duran, Leo
2018-09-13  2:39               ` Ni, Ruiyu
2018-09-13 19:31                 ` Duran, Leo
2018-09-14  4:44                   ` Ni, Ruiyu [this message]
2018-09-17 16:20                     ` Duran, Leo
2018-09-17 16:38                       ` Laszlo Ersek
2018-09-18  8:34                         ` Ni, Ruiyu
2018-09-18 14:57                           ` Duran, Leo
2018-09-19  8:58                             ` Ni, Ruiyu
2018-09-21 16:52                               ` Duran, Leo
2018-09-21 17:13                                 ` Duran, Leo
2018-09-25 14:29                                   ` Duran, Leo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=981751ac-68a0-ea2c-7985-2562d1916560@Intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox