From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.24; helo=mga09.intel.com; envelope-from=ruiyu.ni@intel.com; receiver=edk2-devel@lists.01.org Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 204AE21130707 for ; Thu, 13 Sep 2018 21:43:21 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Sep 2018 21:43:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,372,1531810800"; d="scan'208";a="91627789" Received: from ray-dev.ccr.corp.intel.com (HELO [10.239.9.8]) ([10.239.9.8]) by orsmga002.jf.intel.com with ESMTP; 13 Sep 2018 21:43:19 -0700 To: "Duran, Leo" , Laszlo Ersek , "edk2-devel@lists.01.org" Cc: "Dong, Eric" References: <1536680498-6554-1-git-send-email-leo.duran@amd.com> <1536680498-6554-2-git-send-email-leo.duran@amd.com> <17c6d6d1-2655-fe06-a8b9-f48141bfb0d7@redhat.com> <610eaa55-c87b-5e0c-4f87-5c1e79ffc5ba@redhat.com> <12abd990-3b08-9159-e7a9-ffd7eb7282b3@redhat.com> <734D49CCEBEEF84792F5B80ED585239D5BE07168@SHSMSX104.ccr.corp.intel.com> From: "Ni, Ruiyu" Message-ID: <981751ac-68a0-ea2c-7985-2562d1916560@Intel.com> Date: Fri, 14 Sep 2018 12:44:12 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Subject: Re: [PATCH] UefiCpuPkg/MtrrLib: Add flag to skip disabling MTRRs prior to MTRR change. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Sep 2018 04:43:21 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 9/14/2018 3:31 AM, Duran, Leo wrote: > > >> -----Original Message----- >> From: Ni, Ruiyu >> Sent: Wednesday, September 12, 2018 9:39 PM >> To: Duran, Leo ; Laszlo Ersek ; >> edk2-devel@lists.01.org >> Cc: Dong, Eric >> Subject: RE: [PATCH] UefiCpuPkg/MtrrLib: Add flag to skip disabling MTRRs >> prior to MTRR change. >> >> Leo, >> Sorry I was in leave yesterday so didn't see the mail. >> Which MSRs are shared? Only the MSR_IA32_MTRR_DEF_TYPE_REGISTER? >> Or all the MSRs that configures the CPU MTRR setting? >> > > Hi Ray, > The MTTR config MSRs are also shared by threads within a core. > Hi Leo, Do you think that fixing the caller is more proper? >> I also agree with Laszlo's comments to fix the caller if all MSRs relating to >> MTRR are shared. >> That will be to fix MpInitLib and CpuDxe driver. >> >> Thanks/Ray >>