From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web08.1035.1625680993742861797 for ; Wed, 07 Jul 2021 11:03:13 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=CMgSwQdi; spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1625680992; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RGIxv1jU1BHUS8Q4vVAKfiNRla5U9KkH37Fz9D4hAbg=; b=CMgSwQdigUlVpHD+t7siZR1Q+v+7H4Rv5p4p+Hq6rzeU2idkJ9h6W44WbFznAx+ZbXFyEb MPrJBYFPAGFhF2Qn0KDO5YolSD+xEbrWS3Ll/fBF5Bu4h5pAz28rtpgCukmp/jRM9LMeLY PLZoJLCoqOnhC+I4ppkcrDoM/Z4g6ig= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-522-q1bsY7TDN6Wl9Vi4C7OGIg-1; Wed, 07 Jul 2021 14:03:09 -0400 X-MC-Unique: q1bsY7TDN6Wl9Vi4C7OGIg-1 Received: by mail-wr1-f72.google.com with SMTP id m9-20020a0560000089b02901362e1cd6a3so1037788wrx.13 for ; Wed, 07 Jul 2021 11:03:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=RGIxv1jU1BHUS8Q4vVAKfiNRla5U9KkH37Fz9D4hAbg=; b=hQDGHQ5reV7msqnmflIzlD4fNHNWXJoIQLgUXCvbl+jiIfaR+gIEjDTpUdYUo0wvB2 d8CFX9DAw2QEM/XVFLSQuu33REiGIKl8paljDQvR8FxCMyvtuNwk6EubCHGz2iNIZ0bR RZemMlplRwhN8r7Fvm4rqHItk2NfPnkP+Dbpbt+rqUX9C2N0cNrdKlR8H41CV/1KwAg3 9+ipyrmwnPxFkspq0n8EmiHEkRNNVmyn0+N7LbLBzP9x5XrMBx6/i0cn9oqp1BZlulIU 64d62/7QFTuL485E5ijrVzkXg9VsKCEVVT6F72DFUfrsPGnH6OVRse+vmKfD7OP7Zs1H K2vQ== X-Gm-Message-State: AOAM531o811nKoKkcsd1zIHSBnymg9I6sipau5cW9R7+VtPYcxcamoIX c+8o47snHordtBoj6pcRKBG5uYvdFmk3giH1YvGEEY413o2vzOom1UQSFELCd+F/wvUyI3ufmf4 hjNgx8Fmp8XReig== X-Received: by 2002:a5d:598d:: with SMTP id n13mr12460475wri.246.1625680988508; Wed, 07 Jul 2021 11:03:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzgq9qryuYZc7jgomPCgFzpCHRJm62PxzoOC7wXdXb4tkr7fApAuT+6ykmJotehz5UhsWFcIQ== X-Received: by 2002:a5d:598d:: with SMTP id n13mr12460458wri.246.1625680988384; Wed, 07 Jul 2021 11:03:08 -0700 (PDT) Return-Path: Received: from [192.168.1.36] (93.red-83-35-24.dynamicip.rima-tde.net. [83.35.24.93]) by smtp.gmail.com with ESMTPSA id z4sm19523938wmf.9.2021.07.07.11.03.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 07 Jul 2021 11:03:07 -0700 (PDT) Subject: Re: [PATCH v2] OvmfPkg: Remove unused print service driver (PrintDxe) To: devel@edk2.groups.io Cc: Laszlo Ersek , Ard Biesheuvel , Jordan Justen , Brijesh Singh , Erdem Aktas , James Bottomley , Jiewen Yao , Min Xu , Tom Lendacky References: <20210707180146.1489706-1-philmd@redhat.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Message-ID: <98199171-a1d9-d25b-592b-31b80589749f@redhat.com> Date: Wed, 7 Jul 2021 20:03:07 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210707180146.1489706-1-philmd@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 7/7/21 8:01 PM, Philippe Mathieu-Daudé wrote: > From: Philippe Mathieu-Daude > > PrintDxe produces gEfiPrint2ProtocolGuid and gEfiPrint2SProtocolGuid, > and those are consumed by the following PrintLib instance: > > MdeModulePkg/Library/DxePrintLibPrint2Protocol/DxePrintLibPrint2Protocol.inf > > However, none of the OVMF DSC files contain such a PrintLib class > resolution, so none of the OVMF platforms need PrintDxe. > > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Cc: Jordan Justen > Cc: Brijesh Singh > Cc: Erdem Aktas > Cc: James Bottomley > Cc: Jiewen Yao > Cc: Min Xu > Cc: Tom Lendacky > Suggested-by: Laszlo Ersek > Signed-off-by: Philippe Mathieu-Daude > --- > OvmfPkg/AmdSev/AmdSevX64.dsc | 1 - > OvmfPkg/OvmfPkgIa32.dsc | 1 - > OvmfPkg/OvmfPkgIa32X64.dsc | 1 - > OvmfPkg/OvmfPkgX64.dsc | 1 - > OvmfPkg/AmdSev/AmdSevX64.fdf | 1 - > OvmfPkg/OvmfPkgIa32.fdf | 1 - > OvmfPkg/OvmfPkgIa32X64.fdf | 1 - > OvmfPkg/OvmfPkgX64.fdf | 1 - > 8 files changed, 8 deletions(-) > > diff --git a/OvmfPkg/AmdSev/AmdSevX64.dsc b/OvmfPkg/AmdSev/AmdSevX64.dsc > index 1d487befae08..d1974b4a6873 100644 > --- a/OvmfPkg/AmdSev/AmdSevX64.dsc > +++ b/OvmfPkg/AmdSev/AmdSevX64.dsc > @@ -722,7 +722,6 @@ [Components] > DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf > PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf > } > - MdeModulePkg/Universal/PrintDxe/PrintDxe.inf > MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf > MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf > MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf > diff --git a/OvmfPkg/OvmfPkgIa32.dsc b/OvmfPkg/OvmfPkgIa32.dsc > index f53efeae7986..dff4b97b37c0 100644 > --- a/OvmfPkg/OvmfPkgIa32.dsc > +++ b/OvmfPkg/OvmfPkgIa32.dsc > @@ -816,7 +816,6 @@ [Components] > DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf > PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf > } > - MdeModulePkg/Universal/PrintDxe/PrintDxe.inf > MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf > MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf > MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf > diff --git a/OvmfPkg/OvmfPkgIa32X64.dsc b/OvmfPkg/OvmfPkgIa32X64.dsc > index b3662e17f256..f3df655c990e 100644 > --- a/OvmfPkg/OvmfPkgIa32X64.dsc > +++ b/OvmfPkg/OvmfPkgIa32X64.dsc > @@ -830,7 +830,6 @@ [Components.X64] > DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf > PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf > } > - MdeModulePkg/Universal/PrintDxe/PrintDxe.inf > MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf > MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf > MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf > diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc > index 0a237a905866..dc9a2720f9b2 100644 > --- a/OvmfPkg/OvmfPkgX64.dsc > +++ b/OvmfPkg/OvmfPkgX64.dsc > @@ -828,7 +828,6 @@ [Components] > DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf > PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf > } > - MdeModulePkg/Universal/PrintDxe/PrintDxe.inf > MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf > MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf > MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf > diff --git a/OvmfPkg/AmdSev/AmdSevX64.fdf b/OvmfPkg/AmdSev/AmdSevX64.fdf > index 9977b0f00a18..42f120d016e1 100644 > --- a/OvmfPkg/AmdSev/AmdSevX64.fdf > +++ b/OvmfPkg/AmdSev/AmdSevX64.fdf > @@ -234,7 +234,6 @@ [FV.DXEFV] > INF MdeModulePkg/Application/UiApp/UiApp.inf > INF OvmfPkg/QemuKernelLoaderFsDxe/QemuKernelLoaderFsDxe.inf > INF MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf > -INF MdeModulePkg/Universal/PrintDxe/PrintDxe.inf > INF MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf > INF MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf > INF MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf > diff --git a/OvmfPkg/OvmfPkgIa32.fdf b/OvmfPkg/OvmfPkgIa32.fdf > index 04b41445ca34..031eb4225c53 100644 > --- a/OvmfPkg/OvmfPkgIa32.fdf > +++ b/OvmfPkg/OvmfPkgIa32.fdf > @@ -254,7 +254,6 @@ [FV.DXEFV] > INF MdeModulePkg/Application/UiApp/UiApp.inf > INF OvmfPkg/QemuKernelLoaderFsDxe/QemuKernelLoaderFsDxe.inf > INF MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf > -INF MdeModulePkg/Universal/PrintDxe/PrintDxe.inf > INF MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf > INF MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf > INF MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf > diff --git a/OvmfPkg/OvmfPkgIa32X64.fdf b/OvmfPkg/OvmfPkgIa32X64.fdf > index 02fd8f0c413e..7194f08e6024 100644 > --- a/OvmfPkg/OvmfPkgIa32X64.fdf > +++ b/OvmfPkg/OvmfPkgIa32X64.fdf > @@ -255,7 +255,6 @@ [FV.DXEFV] > INF MdeModulePkg/Application/UiApp/UiApp.inf > INF OvmfPkg/QemuKernelLoaderFsDxe/QemuKernelLoaderFsDxe.inf > INF MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf > -INF MdeModulePkg/Universal/PrintDxe/PrintDxe.inf > INF MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf > INF MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf > INF MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf > diff --git a/OvmfPkg/OvmfPkgX64.fdf b/OvmfPkg/OvmfPkgX64.fdf > index 5fa8c0895808..b304e3149d4f 100644 > --- a/OvmfPkg/OvmfPkgX64.fdf > +++ b/OvmfPkg/OvmfPkgX64.fdf > @@ -267,7 +267,6 @@ [FV.DXEFV] > INF MdeModulePkg/Application/UiApp/UiApp.inf > INF OvmfPkg/QemuKernelLoaderFsDxe/QemuKernelLoaderFsDxe.inf > INF MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf > -INF MdeModulePkg/Universal/PrintDxe/PrintDxe.inf > INF MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf > INF MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf > INF MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf > Please discard v2... v3 posted.