Re: [PATCH] Check return status on calls to GetTime()

[Grant Likely <grant.likely@arm.com>]

On 01/08/2020 14:54, Heinrich Schuchardt wrote:
> On 7/31/20 7:19 PM, Grant Likely wrote:
[...]>> diff --git 
a/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/MiscBootServices/BlackBoxTest/MiscBootServicesBBTestFunction.c 
b/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/MiscBootServices/BlackBoxTest/MiscBootServicesBBTestFunction.c
>> index 1d231d8c..3a530282 100644
>> --- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/MiscBootServices/BlackBoxTest/MiscBootServicesBBTestFunction.c
>> +++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/MiscBootServices/BlackBoxTest/MiscBootServicesBBTestFunction.c
>> @@ -27,6 +27,8 @@ Abstract:
>>   #include "SctLib.h"
> 
> I tried to apply your patch with 'git am --keep-cr'. This chunk has a
> problem.
> 
> While all other lines in the file have CR LF line endings this very line
> has only LF in EDK2 master. But your patch has CR LF for the line.
> 
> Did you use Windows and not Linux to create the patch?

Hahaha! No, I did not use Windows. From what I can tell, that file 
already had inconsisten line endings. Most of the file is crlf, but the 
"#include "SctLib.h" line is lf only. This confuses vim which interprets 
it as a unix file and shows the ^M on every line, which in turn allowed 
me to add additional lines with unix line endings.

> I could apply your patch after removing the extraneous CR.
> 
> With your patch applied if GetTime() returns EFI_UNSUPPORTED, the test
> log is not garbled anymore:
> 
> SetVariable_Conf:
> Test Finished: 01/01/70  12:00a
> Elapsed Time: 00 Days 00:00:00
> 
> If GetTime() is available:
> 
> SetVariable_Conf:
> Test Finished: 08/01/20  01:52p
> Elapsed Time: 00 Days 00:00:04
> 
> Except for the line-endings:
> 
> Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de>

Ace! Thanks.

g.