From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (EUR04-HE1-obe.outbound.protection.outlook.com [40.107.7.85]) by mx.groups.io with SMTP id smtpd.web10.8206.1596555989265407846 for ; Tue, 04 Aug 2020 08:46:30 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=PvsXDtEz; spf=pass (domain: arm.com, ip: 40.107.7.85, mailfrom: grant.likely@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3UOoHnwZe/gK9Bjk53HrdroDKmrjJx10W29DaggnVOM=; b=PvsXDtEzP99ROBQ7VvBJcPErWm7vxsezEdGm34ACx2+d1xNQXLJovrxEeKOZaSTU7hkr7zTCkWrytb8I/2H6MB8oDxxuu65TGTB9rHX6WVbWXI/BTFavwgtpsFi4lw5EuiTH0Ari0DBl2MTDpN4se47eFbURlpsBUBIrbOS5j4g= Received: from AM6P191CA0088.EURP191.PROD.OUTLOOK.COM (2603:10a6:209:8a::29) by DB6PR0801MB1637.eurprd08.prod.outlook.com (2603:10a6:4:3a::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3239.18; Tue, 4 Aug 2020 15:46:26 +0000 Received: from AM5EUR03FT014.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:8a:cafe::d8) by AM6P191CA0088.outlook.office365.com (2603:10a6:209:8a::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3239.17 via Frontend Transport; Tue, 4 Aug 2020 15:46:26 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT014.mail.protection.outlook.com (10.152.16.130) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3239.17 via Frontend Transport; Tue, 4 Aug 2020 15:46:25 +0000 Received: ("Tessian outbound 8f96107a8ecd:v64"); Tue, 04 Aug 2020 15:46:25 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 87bb28fdd56bde20 X-CR-MTA-TID: 64aa7808 Received: from 01e590aaac99.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id C1260DE0-45C9-4236-B242-E6ED827E7815.1; Tue, 04 Aug 2020 15:46:19 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 01e590aaac99.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 04 Aug 2020 15:46:19 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BMqkIai3yjBvmxBebgHrMrWMbAffIm6HguPGIaE+Jw1UlteY4NclA2qFm0QgUfnRNL98kq9V1oh5uQMSM+XRlZlGRnnkib70ij5Kh4Uvh2+xavaPTr5YtsOGbDlP05bwJhl6C5EDQkmcH42GU5OwQHKSvJi/2lITZEEzU82gYdyxC7cOLXWIvp0MlrjqhAIr/6lf1Wckgv0f6X1Hp6vk0NmJynt644Rn5tbG4Gmt5Ob0rYhHtOOHzAywblAz7extve52RP3U5UOqeyDG9BkAVt4q/tob7E8pfYrT0RyStFxkC0nl2PUB7K9IRgvqtqabrZD0VjM0Wbwz8qtwzEp96Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3UOoHnwZe/gK9Bjk53HrdroDKmrjJx10W29DaggnVOM=; b=AvnHrBR7ihwUWHisgBMPVjeRvflQIJEdNCpkYfUW5Tq+aNAJ1XmiMmttctib90Jyhp8hGmf4+XsV70cv+TvBceCaY1zw5XAW8xPSg7y1XpP2szza0vAFSCEkzsjwQVgj8ylYJi2VQh9XROkpxjAJUHImpw9OmKQaYQ9iKMI5TrF8ch4gG1AQ3MjZwTq+Z+KxEM5kV4dPP/WSvr2xlEMS8QMWemBZ3HzfwQUlplfme6TnVbI7Zybc5LhS1apfXw40iODeTpgGQLZTHoWk2kJC4vAAqs4DqwY35619eYDBFENhk5YMCsD0MDJbCzHj7n2KpDLc7bHkD22fIVhwtInUlg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3UOoHnwZe/gK9Bjk53HrdroDKmrjJx10W29DaggnVOM=; b=PvsXDtEzP99ROBQ7VvBJcPErWm7vxsezEdGm34ACx2+d1xNQXLJovrxEeKOZaSTU7hkr7zTCkWrytb8I/2H6MB8oDxxuu65TGTB9rHX6WVbWXI/BTFavwgtpsFi4lw5EuiTH0Ari0DBl2MTDpN4se47eFbURlpsBUBIrbOS5j4g= Authentication-Results-Original: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=arm.com; Received: from DB8PR08MB4010.eurprd08.prod.outlook.com (2603:10a6:10:ab::15) by DB8PR08MB5402.eurprd08.prod.outlook.com (2603:10a6:10:11b::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3239.17; Tue, 4 Aug 2020 15:46:18 +0000 Received: from DB8PR08MB4010.eurprd08.prod.outlook.com ([fe80::cde5:14f:5af0:8e44]) by DB8PR08MB4010.eurprd08.prod.outlook.com ([fe80::cde5:14f:5af0:8e44%6]) with mapi id 15.20.3239.021; Tue, 4 Aug 2020 15:46:18 +0000 Subject: Re: [PATCH] Check return status on calls to GetTime() To: Heinrich Schuchardt , devel@edk2.groups.io Cc: nd@arm.com, G Edhaya Chandran , Samer El-Haj-Mahmoud , Eric Jin References: <20200731171949.15748-1-grant.likely@arm.com> <117e027c-3389-1b0c-4fb3-33418bf7976f@gmx.de> From: Grant Likely Message-ID: <9820fdd3-680d-69f2-a7bd-47bf5043227d@arm.com> Date: Tue, 4 Aug 2020 16:46:15 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 In-Reply-To: <117e027c-3389-1b0c-4fb3-33418bf7976f@gmx.de> X-ClientProxiedBy: LO2P265CA0088.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:8::28) To DB8PR08MB4010.eurprd08.prod.outlook.com (2603:10a6:10:ab::15) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.16.147] (188.28.130.137) by LO2P265CA0088.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:8::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3239.17 via Frontend Transport; Tue, 4 Aug 2020 15:46:17 +0000 X-Originating-IP: [188.28.130.137] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 903c35f2-e3fd-4606-e9ec-08d8388d8ba4 X-MS-TrafficTypeDiagnostic: DB8PR08MB5402:|DB6PR0801MB1637: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:9508;OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: f3ejbUf4sM56/c5JHxTtFHSRvfZG8poKm4a9gJ5+y1E0j79xzkpSsBOaiMpty8bcZcGkQcsC6yYrYRtyLIZyYXy93s47X0XWU/RQLx7D1Hp/yz63hQ1R4WhwpUi9yo3epv7vmfK+ljW4rdU0KxjmHKdj7TB6MDsT7N/jvpqKgMQvqXm9fUVxRGs87sJ3+F20xh1luVF8OFCxX8+tCE2k2L1DUgninkatc1Xa277N77527PlcVEWVHd4gpsZTY8P+tANHGgZ7Efy+RBDyT3qyZW7+u2ZLgqIYlFpFjXHuSNPArODD7kQW83beaSTtyGF8/1C2CQQl2mSPFqsmgMINpuaHMTmQ4WiGVxyNHa3tsxYAzIUg2cwL2mPHI8qSAjHg X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB8PR08MB4010.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(346002)(376002)(136003)(366004)(396003)(39860400002)(44832011)(5660300002)(8676002)(86362001)(31686004)(8936002)(2906002)(16576012)(316002)(54906003)(186003)(55236004)(36756003)(4326008)(31696002)(66476007)(66946007)(52116002)(66556008)(53546011)(26005)(956004)(478600001)(2616005)(6486002)(16526019)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: bHbGlY3uZ/d2TEJOU8rGTPvm9uMc8Rk+8vP5pV4UHEJTGH/zlEIuhVYlhZN2+5I6BjnjFX3tSBN7MM6L0cv3FSxQs8KqVEJV0iiER0yZqmn7wOPO+qVi/jI2QQONSdTGJrPCL+d7NEnml9Z8Tiq5REgVUKI1D7N7THj56xMtBkeCLny1TfsbaRwLhiuxqMrZyVatX9bmWXLkNPVRZShVpsEKi/tDp/mpOcyuM4mFDmT9xkCLU8ld5GfIl4E9xe176UCmmfSQhr3HJkzWVwWgxG2CRfAWq19UzAMKq8DD36hDwZd1iIs0ks4DeJJRnPayVGetdVfDcyKE9X+Yv3+v/fqHbclg2v9z6zhbyon0fUqLnjVncbAWP0rs0gZIyPzGM7xClz4eYgx3e1Rgtj3yWyD2w+85eWdloI/W3jsksVeDstgDaOqZCwGQYleLOvQMuR7vsh9VpUL0WE0OdDGWAlXTB6paIXkVpbLjJfzP1iDcMWguglX39TXU4TiYN6HIgzjXo5+g0pDoj9YqvY7ekxX2QGD0UMzXKmKJAF6S770d5R7SkgMQH9r1LYjC9DgjMEmJ1wsf81qHAxTksRGm+15XzagVcL8ZpymNwNjfA9IVYGf8nj7g5rwQCp/7xJTsiyyEgKLYPAq1SpHuthV9RA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB5402 Original-Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=arm.com; Return-Path: Grant.Likely@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT014.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: e53fadb6-070d-497b-1bba-08d8388d873d X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: FElVQ+CMj/NShueiN2oufcDVwRYA4LvGISq5uOw7GcpJIX5M00asY2ITYtBLOh0HDUODgYUDxvVtXoTrjVkwDo+qU0mMj7DidQ+pfc3UQ1cEirZ68cHVNGRInkqUcUDd2Xqz5wY4qk/qdlyz30x16pWQ9HLxeiPSwHBgDcfBtkfPaoorGQ/db2JdiT3p1W+ssIujFNDHbLSm0ETBfkef1KUnx0AMF5xZBsObQSLkRHCSd6nU/EbmLRxSqHbRKYq+CHE30230h+rh/ZEcH6EqIDyMd1v7ALktP+iBP2DBulkO4m4+22rkElEa5c9dBTfbtO3u3KogCAhUutaZLef6mxT/+SWGLXUcaJu9TDbNh2CGi2p2YE7EYtnOM05l9p6rSE9ke+sEB0Lkdp8yIdewkczUGs88YeUxr2Wg7dObdCtgv3pw6qb+e7345ty4e6UD X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFTY:;SFS:(4636009)(396003)(346002)(39850400004)(136003)(376002)(46966005)(478600001)(86362001)(81166007)(47076004)(107886003)(8676002)(82740400003)(44832011)(36906005)(316002)(16576012)(2906002)(54906003)(356005)(82310400002)(31686004)(2616005)(36756003)(4326008)(5660300002)(70586007)(70206006)(53546011)(31696002)(16526019)(956004)(26005)(336012)(186003)(8936002)(6486002)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Aug 2020 15:46:25.6760 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 903c35f2-e3fd-4606-e9ec-08d8388d8ba4 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT014.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0801MB1637 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 01/08/2020 14:54, Heinrich Schuchardt wrote: > On 7/31/20 7:19 PM, Grant Likely wrote: [...]>> diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/MiscBootServices/BlackBoxTest/MiscBootServicesBBTestFunction.c b/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/MiscBootServices/BlackBoxTest/MiscBootServicesBBTestFunction.c >> index 1d231d8c..3a530282 100644 >> --- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/MiscBootServices/BlackBoxTest/MiscBootServicesBBTestFunction.c >> +++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/MiscBootServices/BlackBoxTest/MiscBootServicesBBTestFunction.c >> @@ -27,6 +27,8 @@ Abstract: >> #include "SctLib.h" > > I tried to apply your patch with 'git am --keep-cr'. This chunk has a > problem. > > While all other lines in the file have CR LF line endings this very line > has only LF in EDK2 master. But your patch has CR LF for the line. > > Did you use Windows and not Linux to create the patch? Hahaha! No, I did not use Windows. From what I can tell, that file already had inconsisten line endings. Most of the file is crlf, but the "#include "SctLib.h" line is lf only. This confuses vim which interprets it as a unix file and shows the ^M on every line, which in turn allowed me to add additional lines with unix line endings. > I could apply your patch after removing the extraneous CR. > > With your patch applied if GetTime() returns EFI_UNSUPPORTED, the test > log is not garbled anymore: > > SetVariable_Conf: > Test Finished: 01/01/70 12:00a > Elapsed Time: 00 Days 00:00:00 > > If GetTime() is available: > > SetVariable_Conf: > Test Finished: 08/01/20 01:52p > Elapsed Time: 00 Days 00:00:04 > > Except for the line-endings: > > Reviewed-by: Heinrich Schuchardt Ace! Thanks. g.