From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.81]) by mx.groups.io with SMTP id smtpd.web10.4200.1588241172956217042 for ; Thu, 30 Apr 2020 03:06:13 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=P1ReUXWy; spf=pass (domain: redhat.com, ip: 207.211.31.81, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1588241172; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ghu4YrWT+04hHptB+Nb6c+36wUGJ3W70Q0tPXR3EJTM=; b=P1ReUXWyE+4ORpckydd5qGd/nUxQVOVoJGl9YJaRyL6aKwzQeV5hmFHcw+ixBujYVmYp9K 1W1EGVROQPbspNjiXODVIfHNocIRZwHnNaZFyrgnC8So+gYvD/BIEHaRG3xcnnNOpd9uEj +anjVorJ3q63vTmfPbsKHfnPGKRSgw4= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-481-e2eYsBahMI-Dp7Kzxpk5lQ-1; Thu, 30 Apr 2020 06:06:10 -0400 X-MC-Unique: e2eYsBahMI-Dp7Kzxpk5lQ-1 Received: by mail-wm1-f71.google.com with SMTP id d134so3866705wmd.0 for ; Thu, 30 Apr 2020 03:06:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Ghu4YrWT+04hHptB+Nb6c+36wUGJ3W70Q0tPXR3EJTM=; b=jAJerSj5hykUyffTEJCw8PlK50+Hn/CXnooOReCTau7xBkJeVSrgBX6OxDIdqHlnaO W3Vmok5pN/PF+A0RJqaEXnWVTkTX6HkyqeZEW1HImOuBM+gmLGEUvwwcKyr7ltw+p+Ut uLdrD5klYUDWzI96toWxURcL5x5rk4V+a4jdPxA1hkpSMeHX9U5fE5NcCoj5oRHItQ03 VOa+tSNj7PzUwCQzrTwBhzJ/wNltquLxsv+d7n7yXe11IMJzNQeZ6vqPbIdxa3abM7SC /wSSR7r2srBUkeJSCGYa9xmGhP26wIhvb0Yf5mN2jlvQzmOOR8uRwClw+uznCvTSMq7E mIBA== X-Gm-Message-State: AGi0PuZJ5NiKGQMd3REuYZflIwuLbZRDjupxe1DiOjLzm0fSeVt89nwo 4OTOgndDd9LYcOwyRvp/iq7MQqK1MDMBDKRVmnUnDd7wMThLTnKt8Kek459uFUwUHlIg+v6sDSk nbATZkRcDg6pUiw== X-Received: by 2002:a7b:c944:: with SMTP id i4mr2250017wml.144.1588241169390; Thu, 30 Apr 2020 03:06:09 -0700 (PDT) X-Google-Smtp-Source: APiQypLs/so3nwUHXBQ+YikdHYZNLTn5YbW5xTTZMFa74KR1XmE3kgIFJrxh0LqirylvjtRe25tUQw== X-Received: by 2002:a7b:c944:: with SMTP id i4mr2249993wml.144.1588241169145; Thu, 30 Apr 2020 03:06:09 -0700 (PDT) Return-Path: Received: from [192.168.1.39] (137.red-88-21-205.staticip.rima-tde.net. [88.21.205.137]) by smtp.gmail.com with ESMTPSA id x18sm11469005wmi.29.2020.04.30.03.06.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 Apr 2020 03:06:08 -0700 (PDT) Subject: Re: [edk2-devel] [PATCH edk2-platforms v2 1/2] Platform/ARM/VExpressPkg: incorporate PL180 driver To: devel@edk2.groups.io, ard.biesheuvel@arm.com Cc: leif@nuviainc.com References: <20200430082518.26219-1-ard.biesheuvel@arm.com> <20200430082518.26219-2-ard.biesheuvel@arm.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Message-ID: <9835345a-54a8-debe-dcb3-67be80f45df5@redhat.com> Date: Thu, 30 Apr 2020 12:06:07 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200430082518.26219-2-ard.biesheuvel@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Hi Ard, On 4/30/20 10:25 AM, Ard Biesheuvel wrote: > The PL180 SD host controller driver is only used on emulated ARM > platforms, uses an obsolete version of the MMC host protocol and > does not adhere to the UEFI driver model. > > Given the above, let's just move it into VExpressPkg where it > belongs. > > Signed-off-by: Ard Biesheuvel > --- > Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.dsc | 6 +- > Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.fdf | 2 +- > Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc | 6 +- > Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.fdf | 2 +- > Platform/ARM/VExpressPkg/ArmVExpressPkg.dec | 4 + > Platform/ARM/VExpressPkg/Drivers/PL180MciDxe/PL180Mci.c | 570 ++++++++++++++++++++ > Platform/ARM/VExpressPkg/Drivers/PL180MciDxe/PL180Mci.h | 169 ++++++ > Platform/ARM/VExpressPkg/Drivers/PL180MciDxe/PL180MciDxe.inf | 53 ++ > 8 files changed, 804 insertions(+), 8 deletions(-) > [...] > diff --git a/Platform/ARM/VExpressPkg/Drivers/PL180MciDxe/PL180Mci.c b/Platform/ARM/VExpressPkg/Drivers/PL180MciDxe/PL180Mci.c > new file mode 100644 > index 000000000000..8526bb41600e > --- /dev/null > +++ b/Platform/ARM/VExpressPkg/Drivers/PL180MciDxe/PL180Mci.c > @@ -0,0 +1,570 @@ > +/** @file > + This file implement the MMC Host Protocol for the ARM PrimeCell PL180. > + > + WARNING: > + This driver fails to follow the UEFI driver model without a good > + reason, and only remains in the tree because it is still used by > + a small number of platforms. It will removed when no longer used. I suppose "It will [be] removed"? (2 other occurrences in this patch). Otherwise: Reviewed-by: Philippe Mathieu-Daude > + New platforms should not use it, and no one should use this as > + reference code for developing new drivers. > + > + Copyright (c) 2011-2020, ARM Limited. All rights reserved. > + > + SPDX-License-Identifier: BSD-2-Clause-Patent > + > +**/ [...]