Re: [PATCH] OvmfPkg/BaseMemEncryptSevLib: Enable protection for newly added page table

[Laszlo Ersek <lersek@redhat.com>]

Hi Brijesh,

(Adding Ray, based on Jian's and Ray's feedback in another branch of
this thread.)

This time I prefer to write a shorter email:

(1) First of all, congrats on your family :)

(2) Please file a new TianoCore BZ:
- for UefiCpuPkg (for the time being),
- with the title "create page table library to abstract all page
  table manipulations",
- please assign it to Ray,
- please CC Jian and myself on it,
- please add the edk2-devel archive URL of this email thread to the BZ
- I wonder if the earlier-filed TianoCore BZ
  <https://bugzilla.tianocore.org/show_bug.cgi?id=623> should be
  associated with this new BZ somehow; e.g. in the "See Also" field.

(3) Please resubmit the patch with an updated commit message:
- the "Contributed-under" line is something that I specifically cannot /
  must not add to the commit message myself; it must come from you;
- please reference the TianoCore BZ from point (2) in the commit
  message, as expected future cleanup / refactoring;
- please do the other commit message modifications that I requested.

(4) Because Ray intends to work on the library later, I agree we
shouldn't allow SEV support to remain broken until then. So, I will ACK
and push your (upcoming) v2 patch.

(5) Adding SEV testing steps to the TianoCore Wiki, once the QEMU/KVM
patches are upstream, would be very helpful -- a great idea. I'd like
you to do that, because that could be the basis for SEV test scenarios
in avocado-vt.

The contribution process to the TianoCore Wiki hasn't been fleshed out
yet, generally speaking, to my knowledge. As far as I recall, I asked
Jordan about it last February, and he made really good points. I'll
follow up on that (off-list for now).
Thanks!
Laszlo