From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 249B22236BA95 for ; Fri, 5 Jan 2018 03:33:43 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8A18D87623; Fri, 5 Jan 2018 11:38:49 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-181.rdu2.redhat.com [10.10.120.181]) by smtp.corp.redhat.com (Postfix) with ESMTP id 72FAF5D6A6; Fri, 5 Jan 2018 11:38:47 +0000 (UTC) To: Brijesh Singh , edk2-devel@lists.01.org Cc: Tom Lendacky , Jian J Wang , Jiewen Yao , Jordan Justen , Ard Biesheuvel , "Ni, Ruiyu" References: <20180104170602.6617-1-brijesh.singh@amd.com> <016c210b-2f23-2624-fc7c-867d247521ee@redhat.com> From: Laszlo Ersek Message-ID: <9858eea4-5bcb-79f0-c91d-ffb84c720774@redhat.com> Date: Fri, 5 Jan 2018 12:38:46 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Fri, 05 Jan 2018 11:38:49 +0000 (UTC) Subject: Re: [PATCH] OvmfPkg/BaseMemEncryptSevLib: Enable protection for newly added page table X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Jan 2018 11:33:44 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Hi Brijesh, (Adding Ray, based on Jian's and Ray's feedback in another branch of this thread.) This time I prefer to write a shorter email: (1) First of all, congrats on your family :) (2) Please file a new TianoCore BZ: - for UefiCpuPkg (for the time being), - with the title "create page table library to abstract all page table manipulations", - please assign it to Ray, - please CC Jian and myself on it, - please add the edk2-devel archive URL of this email thread to the BZ - I wonder if the earlier-filed TianoCore BZ should be associated with this new BZ somehow; e.g. in the "See Also" field. (3) Please resubmit the patch with an updated commit message: - the "Contributed-under" line is something that I specifically cannot / must not add to the commit message myself; it must come from you; - please reference the TianoCore BZ from point (2) in the commit message, as expected future cleanup / refactoring; - please do the other commit message modifications that I requested. (4) Because Ray intends to work on the library later, I agree we shouldn't allow SEV support to remain broken until then. So, I will ACK and push your (upcoming) v2 patch. (5) Adding SEV testing steps to the TianoCore Wiki, once the QEMU/KVM patches are upstream, would be very helpful -- a great idea. I'd like you to do that, because that could be the basis for SEV test scenarios in avocado-vt. The contribution process to the TianoCore Wiki hasn't been fleshed out yet, generally speaking, to my knowledge. As far as I recall, I asked Jordan about it last February, and he made really good points. I'll follow up on that (off-list for now). Thanks! Laszlo