Re: [edk2-devel] [PATCH v1 3/3] uefi-sct/SctPkg: TCG2 Protocol: #pragma pack cleanup

["Heinrich Schuchardt" <heinrich.schuchardt@canonical.com>]

On 4/16/24 00:23, Stuart Yoder wrote:
> Fix compiler warning by adding #pragma pack() to close a pragma
> section.  Also delete extraneous #pragma pack(1).
> 
> Signed-off-by: Stuart Yoder <stuart.yoder@arm.com>

Reviewed-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>

> ---
>   uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/TCG2/BlackBoxTest/TCG2ProtocolBBTest.h | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/TCG2/BlackBoxTest/TCG2ProtocolBBTest.h b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/TCG2/BlackBoxTest/TCG2ProtocolBBTest.h
> index deba13f21804..95307b7fa50f 100644
> --- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/TCG2/BlackBoxTest/TCG2ProtocolBBTest.h
> +++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/TCG2/BlackBoxTest/TCG2ProtocolBBTest.h
> @@ -79,7 +79,6 @@ typedef struct {
>     UINT8  buffer[TEST_STRING_LEN];
>   } TPM2B_MAX_BUFFER;
>   
> -#pragma pack(1)
>   // TPM2B_DIGEST as defined in Table 73 of TPM Library Spec Part 2: Structures
>   typedef struct {
>     UINT16 size;
> @@ -110,7 +109,7 @@ typedef struct {
>     TPM2B_DIGEST data;
>     TPMT_TK_HASHCHECK validation;
>   } TPM2_HASH_RESPONSE;
> -#pragma
> +#pragma pack()
>   
>   EFI_STATUS
>   EFIAPI



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117851): https://edk2.groups.io/g/devel/message/117851
Mute This Topic: https://groups.io/mt/105546457/7686176
Mute #pragma:https://edk2.groups.io/g/devel/mutehashtag/pragma
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-