From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail04.groups.io (mail04.groups.io [45.79.224.9]) by spool.mail.gandi.net (Postfix) with ESMTPS id 065F6740040 for ; Tue, 16 Apr 2024 06:54:44 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=kmA6rpeL4ccQTs2TWj1PfYMWTyaf0xWFlhvSrkHvCdE=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1713250483; v=1; b=vhuZUlNkIJVwrhtclWLOZV34kPIkELf7mSKtYsieRChDulddVHanaCX+8CRRu7V8Dv3DONjJ 7S8MSEtP4IpwJGwYffltCcKhD+lDlxWYagC8SOIMpNroj2qLslly/WPLoHezrPTNZGI1NGxO+1X NQHQyUd3efatOEfzJJi8DY6F1idnMEE3Sof3Dhz5TrpsbCpw5rdCQji9ZGeDXuzzl/e3QMuqzDC /EIEIiV4rQRA7OB7Ho0rSZs6asKHtkY1RR72P+qhn6rNh1vHIDZbaH8aBr+2KWtMdgxDmIYgB+y WVXW6D+jm6KF1vx3dCCqHlBzOI/j2ZzrZm80hqM+iJMNQ== X-Received: by 127.0.0.2 with SMTP id Ksq1YY7687511xLbofoV66VO; Mon, 15 Apr 2024 23:54:43 -0700 X-Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) by mx.groups.io with SMTP id smtpd.web10.14369.1713250477770646821 for ; Mon, 15 Apr 2024 23:54:38 -0700 X-Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 839A6404A2 for ; Tue, 16 Apr 2024 06:54:35 +0000 (UTC) X-Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4187293b96fso6219055e9.0 for ; Mon, 15 Apr 2024 23:54:35 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCUoONF3i2MJ9cS3B+JOfvURXt3B5sqP9B0bRmMNMMWCwEBVmiMcjnMX0vgZkqDlLt27j/+EHD6ft1QY6Ibz0w1Hs8DPoA== X-Gm-Message-State: I7PbleKWoCSpohMegCDO4Ikjx7686176AA= X-Received: by 2002:a05:600c:511e:b0:415:5fd6:44c7 with SMTP id o30-20020a05600c511e00b004155fd644c7mr8711812wms.27.1713250474611; Mon, 15 Apr 2024 23:54:34 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHSPRLYaFD0NMdOP9WPJRlqPIUAW0MwMLfKijCZwNUuAO/nn4/Tbbv2C5Hf7R72PnaabrBU7g== X-Received: by 2002:a05:600c:511e:b0:415:5fd6:44c7 with SMTP id o30-20020a05600c511e00b004155fd644c7mr8711798wms.27.1713250474209; Mon, 15 Apr 2024 23:54:34 -0700 (PDT) X-Received: from [192.168.123.161] (ip-062-143-245-032.um16.pools.vodafone-ip.de. [62.143.245.32]) by smtp.gmail.com with ESMTPSA id f18-20020adfe912000000b00343d6c7240fsm13924967wrm.35.2024.04.15.23.54.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Apr 2024 23:54:33 -0700 (PDT) Message-ID: <985b6e6b-2f49-499a-944a-fa138cb9573d@canonical.com> Date: Tue, 16 Apr 2024 08:54:33 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH v1 3/3] uefi-sct/SctPkg: TCG2 Protocol: #pragma pack cleanup To: Stuart Yoder Cc: Alex_Fox@phoenix.com, David_Wright@phoenix.com, lichao@loongson.cn, devel@edk2.groups.io, Edhaya.Chandran@arm.com, gaojie@byosoft.com.cn References: <20240415222322.3167566-1-stuart.yoder@arm.com> <20240415222322.3167566-4-stuart.yoder@arm.com> From: "Heinrich Schuchardt" In-Reply-To: <20240415222322.3167566-4-stuart.yoder@arm.com> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Mon, 15 Apr 2024 23:54:38 -0700 Resent-From: heinrich.schuchardt@canonical.com Reply-To: devel@edk2.groups.io,heinrich.schuchardt@canonical.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=vhuZUlNk; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=canonical.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.9 as permitted sender) smtp.mailfrom=bounce@groups.io On 4/16/24 00:23, Stuart Yoder wrote: > Fix compiler warning by adding #pragma pack() to close a pragma > section. Also delete extraneous #pragma pack(1). >=20 > Signed-off-by: Stuart Yoder Reviewed-by: Heinrich Schuchardt > --- > uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/TCG2/BlackBoxTest/TCG2Protoc= olBBTest.h | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) >=20 > diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/TCG2/BlackBoxTest= /TCG2ProtocolBBTest.h b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/TCG2/Bla= ckBoxTest/TCG2ProtocolBBTest.h > index deba13f21804..95307b7fa50f 100644 > --- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/TCG2/BlackBoxTest/TCG2Pr= otocolBBTest.h > +++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/TCG2/BlackBoxTest/TCG2Pr= otocolBBTest.h > @@ -79,7 +79,6 @@ typedef struct { > UINT8 buffer[TEST_STRING_LEN]; > } TPM2B_MAX_BUFFER; > =20 > -#pragma pack(1) > // TPM2B_DIGEST as defined in Table 73 of TPM Library Spec Part 2: Stru= ctures > typedef struct { > UINT16 size; > @@ -110,7 +109,7 @@ typedef struct { > TPM2B_DIGEST data; > TPMT_TK_HASHCHECK validation; > } TPM2_HASH_RESPONSE; > -#pragma > +#pragma pack() > =20 > EFI_STATUS > EFIAPI -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117851): https://edk2.groups.io/g/devel/message/117851 Mute This Topic: https://groups.io/mt/105546457/7686176 Mute #pragma:https://edk2.groups.io/g/devel/mutehashtag/pragma Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-