From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id F2F867803DB for ; Tue, 12 Sep 2023 14:43:46 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=RnLAtwxxn5faV0p36dNCr+PvI2C9YM/dPAP57LDasYY=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1694529825; v=1; b=k+i6CFRn8kSCJLtWl1GBNg73Gd2cArIiJVV2pyKsducJdvEULhj2u1QJh0xw+PHMUWjWEl28 pBhOh3ij3MstzhoP/QWFvly4iwYFIV63qHgcuozxNkugWlgUFs1k2niYGFYedkdKZefLMrxPptD gNWFhyLF48I/gxplt0AuvSVg= X-Received: by 127.0.0.2 with SMTP id pQcbYY7687511xrQxN0WI5VG; Tue, 12 Sep 2023 07:43:45 -0700 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web11.27043.1694529825087774529 for ; Tue, 12 Sep 2023 07:43:45 -0700 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-526-XVzxF6AAOECXkbiAWXeM9w-1; Tue, 12 Sep 2023 10:43:43 -0400 X-MC-Unique: XVzxF6AAOECXkbiAWXeM9w-1 X-Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A868F101A529; Tue, 12 Sep 2023 14:43:42 +0000 (UTC) X-Received: from [10.39.193.227] (unknown [10.39.193.227]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3706310F1BE7; Tue, 12 Sep 2023 14:43:41 +0000 (UTC) Message-ID: <986e53e4-efac-3a38-5494-8da98de77d10@redhat.com> Date: Tue, 12 Sep 2023 16:43:40 +0200 MIME-Version: 1.0 Subject: Re: [edk2-devel] [PATCH 1/2] OvmfPkg/PlatformBootManagerLib: refer to virtio console subsys symbolically To: devel@edk2.groups.io Cc: Anthony Perard , Ard Biesheuvel , Gerd Hoffmann , Jiewen Yao , Jordan Justen , Julien Grall , =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= , Stefan Berger References: <20230912141714.74953-1-lersek@redhat.com> From: "Laszlo Ersek" In-Reply-To: <20230912141714.74953-1-lersek@redhat.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: sV8njJtlkVFbIJ4gOkmaDUvcx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=k+i6CFRn; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 9/12/23 16:17, Laszlo Ersek wrote: > "OvmfPkg/Include/IndustryStandard/Virtio095.h" defines the macro > VIRTIO_SUBSYSTEM_CONSOLE with value 3; other locations in the tree already > use it (such as ArmVirtPkg/PlatformBootManagerLib, > OvmfPkg/VirtioSerialDxe). We should use it in > OvmfPkg/PlatformBootManagerLib too, rather than the naked constant 3. > > Cc: Anthony Perard > Cc: Ard Biesheuvel > Cc: Gerd Hoffmann > Cc: Jiewen Yao > Cc: Jordan Justen > Cc: Julien Grall > Cc: Marc-André Lureau > Cc: Stefan Berger > Beautifies: 163083fd80d5 > Signed-off-by: Laszlo Ersek > --- > OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c b/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c > index 88c39df4aea9..d9f61757cf1b 100644 > --- a/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c > +++ b/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c > @@ -1250,7 +1250,7 @@ DetectAndPreparePlatformVirtioDevicePath ( > DEBUG ((DEBUG_INFO, "%a:%d: id %d\n", __func__, __LINE__, VirtIo->SubSystemDeviceId)); > > switch (VirtIo->SubSystemDeviceId) { > - case 3: > + case VIRTIO_SUBSYSTEM_CONSOLE: > PrepareVirtioSerialDevicePath (Handle); > break; > default: Please ignore "1/2" in the subject prefix; that was a mistake on my end (not passing "-N" to git-format-patch). This patch stands alone. Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108537): https://edk2.groups.io/g/devel/message/108537 Mute This Topic: https://groups.io/mt/101315751/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-