From: "Laszlo Ersek" <lersek@redhat.com>
To: devel@edk2.groups.io, michael.d.kinney@intel.com
Subject: Re: [edk2-devel] [Patch V2] edk2: Update additional licenses in Readme.md
Date: Tue, 4 Jun 2019 20:58:10 +0200 [thread overview]
Message-ID: <98746d69-fdc6-7860-9652-ec082869bf1c@redhat.com> (raw)
In-Reply-To: <20190604184016.23568-1-michael.d.kinney@intel.com>
Hi Mike,
On 06/04/19 20:40, Michael D Kinney wrote:
> Update the list of additional licenses in Readme.md. For additional
> licenses from a git submodule, provide a link to the license file
> in the remote git repository. This makes the links in Readme.md
> when viewed from the edk2 repository GitHub landing page
> https://github.com/tianocore/edk2/ functional from a web browser.
>
> * Remove references EdkCompatibilityPkg
> * Update link to OpenSSL to license file in the git submodule link
> to https://github.com/openssl/openssl
> * Add link to license file in the git submodule like to
> https://github.com/ucb-bar/berkeley-softfloat-3 for
> ArmSoftFloatLib
>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
> ---
> Readme.md | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Readme.md b/Readme.md
> index 1feba16075..567efe9abc 100644
> --- a/Readme.md
> +++ b/Readme.md
> @@ -12,10 +12,10 @@ contains the following components that are covered by additional licenses:
> * [MdeModulePkg/Library/LzmaCustomDecompressLib](MdeModulePkg/Library/LzmaCustomDecompressLib/LZMA-SDK-README.txt)
> * [IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/Sdk](IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/LZMA-SDK-README.txt)
> * [BaseTools/Source/C/VfrCompile/Pccts](BaseTools/Source/C/VfrCompile/Pccts/RIGHTS)
> -* [EdkCompatibilityPkg/Other/Maintained/Tools/Pccts](EdkCompatibilityPkg/Other/Maintained/Tools/Pccts/README)
> * [MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma](MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/README)
> * [OvmfPkg](OvmfPkg/License.txt)
> -* [CryptoPkg/Library/OpensslLib/openssl](CryptoPkg/Library/OpensslLib/openssl/LICENSE)
> +* [CryptoPkg/Library/OpensslLib/openssl](https://github.com/openssl/openssl/blob/151333164ece49fdba3fe5c4bbdc3333cd9ae66d/LICENSE)
> +* [ArmPkg/Library/ArmSoftFloatLib/berkeley-softfloat-3](https://github.com/ucb-bar/berkeley-softfloat-3/blob/f74b1e48110ac3a27dd49b787d164e55e42d81d1/COPYING.txt)
>
> The EDK II Project is composed of packages. The maintainers for each package
> are listed in [Maintainers.txt](Maintainers.txt).
>
The submodule commit hashes captured in the links do not seem to match our submodule references (at this point in time). With the master branch @ 7cea4d71a8a8, we have:
$ git submodule status
b64af41c3276f97f0e181920400ee056b9c88037 ArmPkg/Library/ArmSoftFloatLib/berkeley-softfloat-3 (heads/master)
50eaac9f3337667259de725451f201e784599687 CryptoPkg/Library/OpensslLib/openssl (OpenSSL_1_1_1b)
IMO, these are the commit hashes that we should include in the URLs. I suggest constructing the URLs manually, given the commit hashes, and the general structure of the URL.
https://github.com/openssl/openssl/blob/50eaac9f3337667259de725451f201e784599687/LICENSE
https://github.com/ucb-bar/berkeley-softfloat-3/blob/b64af41c3276f97f0e181920400ee056b9c88037/COPYING.txt
Thanks
Laszlo
next prev parent reply other threads:[~2019-06-04 18:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-04 18:40 [Patch V2] edk2: Update additional licenses in Readme.md Michael D Kinney
2019-06-04 18:58 ` Laszlo Ersek [this message]
2019-06-04 20:30 ` [edk2-devel] " Michael D Kinney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98746d69-fdc6-7860-9652-ec082869bf1c@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox