From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com)
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by groups.io with SMTP; Tue, 04 Jun 2019 11:58:22 -0700
Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mx1.redhat.com (Postfix) with ESMTPS id 7B98722389E;
	Tue,  4 Jun 2019 18:58:11 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-117-251.ams2.redhat.com [10.36.117.251])
	by smtp.corp.redhat.com (Postfix) with ESMTP id DF9DE5DD6D;
	Tue,  4 Jun 2019 18:58:10 +0000 (UTC)
Subject: Re: [edk2-devel] [Patch V2] edk2: Update additional licenses in Readme.md
To: devel@edk2.groups.io, michael.d.kinney@intel.com
References: <20190604184016.23568-1-michael.d.kinney@intel.com>
From: "Laszlo Ersek" <lersek@redhat.com>
Message-ID: <98746d69-fdc6-7860-9652-ec082869bf1c@redhat.com>
Date: Tue, 4 Jun 2019 20:58:10 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20190604184016.23568-1-michael.d.kinney@intel.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Tue, 04 Jun 2019 18:58:11 +0000 (UTC)
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

Hi Mike,

On 06/04/19 20:40, Michael D Kinney wrote:
> Update the list of additional licenses in Readme.md.  For additional
> licenses from a git submodule, provide a link to the license file
> in the remote git repository.  This makes the links in Readme.md
> when viewed from the edk2 repository GitHub landing page
> https://github.com/tianocore/edk2/ functional from a web browser.
> 
> * Remove references EdkCompatibilityPkg
> * Update link to OpenSSL to license file in the git submodule link
>   to https://github.com/openssl/openssl
> * Add link to license file in the git submodule like to
>   https://github.com/ucb-bar/berkeley-softfloat-3 for
>   ArmSoftFloatLib
> 
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
> ---
>  Readme.md | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Readme.md b/Readme.md
> index 1feba16075..567efe9abc 100644
> --- a/Readme.md
> +++ b/Readme.md
> @@ -12,10 +12,10 @@ contains the following components that are covered by additional licenses:
>  * [MdeModulePkg/Library/LzmaCustomDecompressLib](MdeModulePkg/Library/LzmaCustomDecompressLib/LZMA-SDK-README.txt)
>  * [IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/Sdk](IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/LZMA-SDK-README.txt)
>  * [BaseTools/Source/C/VfrCompile/Pccts](BaseTools/Source/C/VfrCompile/Pccts/RIGHTS)
> -* [EdkCompatibilityPkg/Other/Maintained/Tools/Pccts](EdkCompatibilityPkg/Other/Maintained/Tools/Pccts/README)
>  * [MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma](MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/README)
>  * [OvmfPkg](OvmfPkg/License.txt)
> -* [CryptoPkg/Library/OpensslLib/openssl](CryptoPkg/Library/OpensslLib/openssl/LICENSE)
> +* [CryptoPkg/Library/OpensslLib/openssl](https://github.com/openssl/openssl/blob/151333164ece49fdba3fe5c4bbdc3333cd9ae66d/LICENSE)
> +* [ArmPkg/Library/ArmSoftFloatLib/berkeley-softfloat-3](https://github.com/ucb-bar/berkeley-softfloat-3/blob/f74b1e48110ac3a27dd49b787d164e55e42d81d1/COPYING.txt)
>  
>  The EDK II Project is composed of packages.  The maintainers for each package
>  are listed in [Maintainers.txt](Maintainers.txt).
> 

The submodule commit hashes captured in the links do not seem to match our submodule references (at this point in time). With the master branch @ 7cea4d71a8a8, we have:

$ git submodule status
 b64af41c3276f97f0e181920400ee056b9c88037 ArmPkg/Library/ArmSoftFloatLib/berkeley-softfloat-3 (heads/master)
 50eaac9f3337667259de725451f201e784599687 CryptoPkg/Library/OpensslLib/openssl (OpenSSL_1_1_1b)

IMO, these are the commit hashes that we should include in the URLs. I suggest constructing the URLs manually, given the commit hashes, and the general structure of the URL.

https://github.com/openssl/openssl/blob/50eaac9f3337667259de725451f201e784599687/LICENSE
https://github.com/ucb-bar/berkeley-softfloat-3/blob/b64af41c3276f97f0e181920400ee056b9c88037/COPYING.txt

Thanks
Laszlo