From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.120]) by mx.groups.io with SMTP id smtpd.web11.12486.1597230116906430512 for ; Wed, 12 Aug 2020 04:01:57 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=H9Wxet1s; spf=pass (domain: redhat.com, ip: 207.211.31.120, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1597230116; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ft6WlzwwU2XyBBzInO2RfiHNM4f/6euV7liV1h6+1Wo=; b=H9Wxet1sXZcYUs9EJ7w8tdE6CszIwok0dCva5H65mUf6dK/Sh2cjfjik/oxLA2aZnl+9X5 3oX9Xc/YPiHEqd0klkMO+2nk2d+qzgAYW3nZxjybDZgTt+4o0gIjW/C0VCIYM2dgAPhjCg zlkAXH47iIJqYhSAjfAH/xqflG+97+I= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-149-eoEvOANPPdaV52UhvxqtEw-1; Wed, 12 Aug 2020 07:01:50 -0400 X-MC-Unique: eoEvOANPPdaV52UhvxqtEw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C14C5183586E; Wed, 12 Aug 2020 11:01:49 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-114-34.ams2.redhat.com [10.36.114.34]) by smtp.corp.redhat.com (Postfix) with ESMTP id D11CF4AC; Wed, 12 Aug 2020 11:01:48 +0000 (UTC) Subject: Re: [PATCH v5 4/5] ArmVirtPkg: Add RngLib based on TimerLib for CryptoPkg To: matthewfcarlson@gmail.com, devel@edk2.groups.io Cc: Ard Biesheuvel , Leif Lindholm References: <20200812022127.1205-1-matthewfcarlson@gmail.com> <20200812022127.1205-5-matthewfcarlson@gmail.com> From: "Laszlo Ersek" Message-ID: <987e2f19-d1e3-cc04-a176-c031be630540@redhat.com> Date: Wed, 12 Aug 2020 13:01:47 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20200812022127.1205-5-matthewfcarlson@gmail.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Hi Matthew, On 08/12/20 04:21, matthewfcarlson@gmail.com wrote: > From: Matthew Carlson > > Updates the DSC for the ArmVirtPkg platform to add a RngLib that uses the > TimerLib. This is due to a later change that adds TimerLib as a dependency > for OpenSSL. The TimerLib based RngLib mimics the behavior of OpenSSL > previously and it is recommended to switch to a better source of > entropy than the system's performance counter. > > Ref: https://github.com/tianocore/edk2/pull/845 > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1871 > > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Cc: Leif Lindholm > Signed-off-by: Matthew Carlson > --- > ArmVirtPkg/ArmVirt.dsc.inc | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc > index cf44fc73890b..ddfcd0cf9eee 100644 > --- a/ArmVirtPkg/ArmVirt.dsc.inc > +++ b/ArmVirtPkg/ArmVirt.dsc.inc > @@ -42,6 +42,7 @@ > DebugPrintErrorLevelLib|MdePkg/Library/BaseDebugPrintErrorLevelLib/BaseDebugPrintErrorLevelLib.inf > > BaseLib|MdePkg/Library/BaseLib/BaseLib.inf > + RngLib|MdePkg/Library/BaseRngLibTimerLib/BaseRngLibTimerLib.inf > SafeIntLib|MdePkg/Library/BaseSafeIntLib/BaseSafeIntLib.inf > BmpSupportLib|MdeModulePkg/Library/BaseBmpSupportLib/BaseBmpSupportLib.inf > SynchronizationLib|MdePkg/Library/BaseSynchronizationLib/BaseSynchronizationLib.inf > I think you must have missed my feedback on the ArmVirtPkg patch here: https://edk2.groups.io/g/devel/message/63997 http://mid.mail-archive.com/c5470af9-68a3-1d74-5cef-d88f9c54b476@redhat.com Basically, please move the RngLib class resolution just below the OpensslLib class resolution(s) in "ArmVirtPkg/ArmVirt.dsc.inc" as well, not just in the OVMF DSC files. Thank you! Laszlo