From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mx.groups.io with SMTP id smtpd.web10.74796.1674743749645141655
 for <devel@edk2.groups.io>;
 Thu, 26 Jan 2023 06:35:49 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@linux.microsoft.com header.s=default header.b=sEe1awZX;
 spf=pass (domain: linux.microsoft.com, ip: 13.77.154.182, mailfrom: mikuback@linux.microsoft.com)
Received: from [192.168.4.22] (unknown [47.201.8.94])
	by linux.microsoft.com (Postfix) with ESMTPSA id 99F0A20DFE6C;
	Thu, 26 Jan 2023 06:35:48 -0800 (PST)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 99F0A20DFE6C
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
	s=default; t=1674743749;
	bh=X8V6sHGn8o+Q5asGs8wfkxLSJSJxL3Bg39w/crGEOOU=;
	h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
	b=sEe1awZXfLxoBSsyyC2o0j1sKJm/K2N6Ouai/Wjf7y3XhqLs1ln4suU1hTdOGCOSm
	 Bx9ybjAeuXuoMACj2t2IcQhASm1vlIrYriBuwvmQccfaaSj6STD3XxB5h2hF1eGDGM
	 VLjJrrQKGyPa5mIY2xDwpRKrHAz7iF7m63wvJVko=
Message-ID: <98c976b7-8183-9d1b-994c-3e96a52d6133@linux.microsoft.com>
Date: Thu, 26 Jan 2023 09:35:47 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 6.2; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.13.1
Subject: Re: [edk2-devel] [PATCH v2 6/6] ArmVirtPkg/PlatformCI: Perform build test of ArmVirtKvmTool
To: devel@edk2.groups.io, ardb@kernel.org
Cc: Gerd Hoffmann <kraxel@redhat.com>,
 Michael Kubacki <michael.kubacki@microsoft.com>,
 Jiewen Yao <jiewen.yao@intel.com>, Oliver Steffen <osteffen@redhat.com>
References: <20230124163417.584727-1-ardb@kernel.org>
 <20230124163417.584727-7-ardb@kernel.org>
From: "Michael Kubacki" <mikuback@linux.microsoft.com>
In-Reply-To: <20230124163417.584727-7-ardb@kernel.org>
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Reviewed-by: Michael Kubacki <michael.kubacki@microsoft.com>

On 1/24/2023 11:34 AM, Ard Biesheuvel wrote:
> Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
> ---
>   ArmVirtPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml | 25 +++++++++++++++
>   ArmVirtPkg/PlatformCI/KvmToolBuild.py                 | 32 ++++++++++++++++++++
>   2 files changed, 57 insertions(+)
> 
> diff --git a/ArmVirtPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml b/ArmVirtPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml
> index 2b6cc119167b..d1772a65fc3a 100644
> --- a/ArmVirtPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml
> +++ b/ArmVirtPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml
> @@ -115,6 +115,31 @@ jobs:
>               Run.Flags: $(run_flags)
> 
>               Run: $(should_run)
> 
>   
> 
> +          KVMTOOL_AARCH64_DEBUG:
> 
> +            Build.File: "$(package)/PlatformCI/KvmToolBuild.py"
> 
> +            Build.Arch: "AARCH64"
> 
> +            Build.Flags: ""
> 
> +            Build.Target: "DEBUG"
> 
> +            Run: false
> 
> +          KVMTOOL_AARCH64_RELEASE:
> 
> +            Build.File: "$(package)/PlatformCI/KvmToolBuild.py"
> 
> +            Build.Arch: "AARCH64"
> 
> +            Build.Flags: ""
> 
> +            Build.Target: "RELEASE"
> 
> +            Run: false
> 
> +          KVMTOOL_ARM_DEBUG:
> 
> +            Build.File: "$(package)/PlatformCI/KvmToolBuild.py"
> 
> +            Build.Arch: "ARM"
> 
> +            Build.Flags: ""
> 
> +            Build.Target: "DEBUG"
> 
> +            Run: false
> 
> +          KVMTOOL_ARM_RELEASE:
> 
> +            Build.File: "$(package)/PlatformCI/KvmToolBuild.py"
> 
> +            Build.Arch: "ARM"
> 
> +            Build.Flags: ""
> 
> +            Build.Target: "RELEASE"
> 
> +            Run: false
> 
> +
> 
>       workspace:
> 
>         clean: all
> 
>   
> 
> diff --git a/ArmVirtPkg/PlatformCI/KvmToolBuild.py b/ArmVirtPkg/PlatformCI/KvmToolBuild.py
> new file mode 100644
> index 000000000000..4d02dba124ac
> --- /dev/null
> +++ b/ArmVirtPkg/PlatformCI/KvmToolBuild.py
> @@ -0,0 +1,32 @@
> +# @file
> 
> +# Script to Build ArmVirtPkg UEFI firmware
> 
> +#
> 
> +# Copyright (c) Microsoft Corporation.
> 
> +# SPDX-License-Identifier: BSD-2-Clause-Patent
> 
> +##
> 
> +import os
> 
> +import sys
> 
> +
> 
> +sys.path.append(os.path.dirname(os.path.abspath(__file__)))
> 
> +from PlatformBuildLib import SettingsManager
> 
> +from PlatformBuildLib import PlatformBuilder
> 
> +
> 
> +    # ####################################################################################### #
> 
> +    #                                Common Configuration                                     #
> 
> +    # ####################################################################################### #
> 
> +class CommonPlatform():
> 
> +    ''' Common settings for this platform.  Define static data here and use
> 
> +        for the different parts of stuart
> 
> +    '''
> 
> +    PackagesSupported = ("ArmVirtPkg",)
> 
> +    ArchSupported = ("AARCH64", "ARM")
> 
> +    TargetsSupported = ("DEBUG", "RELEASE")
> 
> +    Scopes = ('armvirt', 'edk2-build')
> 
> +    WorkspaceRoot = os.path.realpath(os.path.join(
> 
> +        os.path.dirname(os.path.abspath(__file__)), "..", ".."))
> 
> +
> 
> +    DscName = os.path.join("ArmVirtPkg", "ArmVirtKvmTool.dsc")
> 
> +    FvQemuArg = "" # ignored
> 
> +
> 
> +import PlatformBuildLib
> 
> +PlatformBuildLib.CommonPlatform = CommonPlatform
>