From: "Daniel Schaefer" <daniel.schaefer@hpe.com>
To: Abner Chang <abner.chang@hpe.com>, <devel@edk2.groups.io>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>,
Leif Lindholm <leif@nuviainc.com>,
Sami Mujawar <sami.mujawar@arm.com>,
Jiewen Yao <jiewen.yao@intel.com>,
Jordan Justen <jordan.l.justen@intel.com>,
Gerd Hoffmann <kraxel@redhat.com>,
Sunil V L <sunilvl@ventanamicro.com>
Subject: Re: [PATCH V2 8/9] ArmVirtPkg/FdtPciHostBridgeLib: Relocate FdtPciHostBridgeLib to OvmfPkg/Fdt
Date: Wed, 29 Sep 2021 07:25:35 +0800 [thread overview]
Message-ID: <98cf1905-22c1-9274-6005-8768adb67374@hpe.com> (raw)
In-Reply-To: <20210928083107.7418-9-abner.chang@hpe.com>
Looks good. Just one minor typo in the comment.
Reviewed-By: Daniel Schaefer <daniel.schaefer@hpe.com>
On 9/28/21 16:31, Abner Chang wrote:
> Relocate FdtPciHostBridgeLib to OvmfPkg/Fdt, this library is
> leverage by both ARM and RISC-V archs. Also use
> PcdPciMmio32Translation and PcdPciMmio64Translation
> PCDs provided by MdePkg instead of ArmPkg.
>
> Signed-off-by: Abner Chang <abner.chang@hpe.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Daniel Schaefer <daniel.schaefer@hpe.com>
> Cc: Sunil V L <sunilvl@ventanamicro.com>
> ---
> ArmPkg/ArmPkg.dec | 10 ++++------
> ArmVirtPkg/ArmVirtCloudHv.dsc | 2 +-
> ArmVirtPkg/ArmVirtKvmTool.dsc | 2 +-
> ArmVirtPkg/ArmVirtQemu.dsc | 2 +-
> ArmVirtPkg/ArmVirtQemuKernel.dsc | 2 +-
> .../Fdt}/FdtPciHostBridgeLib/FdtPciHostBridgeLib.inf | 8 +++-----
> .../Fdt}/FdtPciHostBridgeLib/FdtPciHostBridgeLib.c | 0
> 7 files changed, 11 insertions(+), 15 deletions(-)
> rename {ArmVirtPkg/Library => OvmfPkg/Fdt}/FdtPciHostBridgeLib/FdtPciHostBridgeLib.inf (81%)
> rename {ArmVirtPkg/Library => OvmfPkg/Fdt}/FdtPciHostBridgeLib/FdtPciHostBridgeLib.c (100%)
>
> diff --git a/ArmPkg/ArmPkg.dec b/ArmPkg/ArmPkg.dec
> index 12584fb319..8a512b7035 100644
> --- a/ArmPkg/ArmPkg.dec
> +++ b/ArmPkg/ArmPkg.dec
> @@ -338,8 +338,8 @@
> # UINT64 Mmio64CpuBase; // mapping target in 64-bit cpu-physical space
> #
> # gEfiMdePkgTokenSpaceGuid.PcdPciIoTranslation = IoCpuBase - PcdPciIoBase;
> - # PcdPciMmio32Translation = Mmio32CpuBase - (UINT64)PcdPciMmio32Base;
> - # PcdPciMmio64Translation = Mmio64CpuBase - PcdPciMmio64Base;
> + # gEfiMdePkgTokenSpaceGuid.PcdPciMmio32Translation = Mmio32CpuBase - (UINT64)PcdPciMmio32Base;
> + # gEfiMdePkgTokenSpaceGuid.PcdPciMmio64Translation = Mmio64CpuBase - PcdPciMmio64Base;
> #
> # because (a) the target address space (ie. the cpu-physical space) is
> # 64-bit, and (b) the translation values are meant as offsets for *modular*
> @@ -358,9 +358,9 @@
> # TranslatedIoAddress = UntranslatedIoAddress +
> # gEfiMdePkgTokenSpaceGuid.PcdPciIoTranslation;
> # TranslatedMmio32Address = (UINT64)UntranslatedMmio32Address +
> - # PcdPciMmio32Translation;
> + # gEfiMdePkgTokenSpaceGuid..PcdPciMmio32Translation;
Should be one period instead of two.
> # TranslatedMmio64Address = UntranslatedMmio64Address +
> - # PcdPciMmio64Translation;
> + # gEfiMdePkgTokenSpaceGuid.PcdPciMmio64Translation;
> #
> # The modular arithmetic performed in UINT64 ensures that the translation
> # works correctly regardless of the relation between IoCpuBase and
> @@ -371,10 +371,8 @@
> gArmTokenSpaceGuid.PcdPciIoSize|0x0|UINT64|0x00000051
> gArmTokenSpaceGuid.PcdPciMmio32Base|0x0|UINT32|0x00000053
> gArmTokenSpaceGuid.PcdPciMmio32Size|0x0|UINT32|0x00000054
> - gArmTokenSpaceGuid.PcdPciMmio32Translation|0x0|UINT64|0x00000055
> gArmTokenSpaceGuid.PcdPciMmio64Base|0x0|UINT64|0x00000056
> gArmTokenSpaceGuid.PcdPciMmio64Size|0x0|UINT64|0x00000057
> - gArmTokenSpaceGuid.PcdPciMmio64Translation|0x0|UINT64|0x00000058
>
> #
> # Inclusive range of allowed PCI buses.
> diff --git a/ArmVirtPkg/ArmVirtCloudHv.dsc b/ArmVirtPkg/ArmVirtCloudHv.dsc
> index 4470fa3b14..0f26c10aab 100644
> --- a/ArmVirtPkg/ArmVirtCloudHv.dsc
> +++ b/ArmVirtPkg/ArmVirtCloudHv.dsc
> @@ -51,7 +51,7 @@
> FileExplorerLib|MdeModulePkg/Library/FileExplorerLib/FileExplorerLib.inf
> PciPcdProducerLib|OvmfPkg/Fdt/FdtPciPcdProducerLib/FdtPciPcdProducerLib.inf
> PciSegmentLib|MdePkg/Library/BasePciSegmentLibPci/BasePciSegmentLibPci.inf
> - PciHostBridgeLib|ArmVirtPkg/Library/FdtPciHostBridgeLib/FdtPciHostBridgeLib.inf
> + PciHostBridgeLib|OvmfPkg/Fdt/FdtPciHostBridgeLib/FdtPciHostBridgeLib.inf
> PciHostBridgeUtilityLib|ArmVirtPkg/Library/ArmVirtPciHostBridgeUtilityLib/ArmVirtPciHostBridgeUtilityLib.inf
>
> TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf
> diff --git a/ArmVirtPkg/ArmVirtKvmTool.dsc b/ArmVirtPkg/ArmVirtKvmTool.dsc
> index 97fc98d778..0c5da4427e 100644
> --- a/ArmVirtPkg/ArmVirtKvmTool.dsc
> +++ b/ArmVirtPkg/ArmVirtKvmTool.dsc
> @@ -59,7 +59,7 @@
>
> PciPcdProducerLib|OvmfPkg/Fdt/FdtPciPcdProducerLib/FdtPciPcdProducerLib.inf
> PciSegmentLib|MdePkg/Library/BasePciSegmentLibPci/BasePciSegmentLibPci.inf
> - PciHostBridgeLib|ArmVirtPkg/Library/FdtPciHostBridgeLib/FdtPciHostBridgeLib.inf
> + PciHostBridgeLib|OvmfPkg/Fdt/FdtPciHostBridgeLib/FdtPciHostBridgeLib.inf
> PciHostBridgeUtilityLib|ArmVirtPkg/Library/ArmVirtPciHostBridgeUtilityLib/ArmVirtPciHostBridgeUtilityLib.inf
>
> TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf
> diff --git a/ArmVirtPkg/ArmVirtQemu.dsc b/ArmVirtPkg/ArmVirtQemu.dsc
> index 6c949fd559..4624b6ec36 100644
> --- a/ArmVirtPkg/ArmVirtQemu.dsc
> +++ b/ArmVirtPkg/ArmVirtQemu.dsc
> @@ -79,7 +79,7 @@
> FileExplorerLib|MdeModulePkg/Library/FileExplorerLib/FileExplorerLib.inf
> PciPcdProducerLib|OvmfPkg/Fdt/FdtPciPcdProducerLib/FdtPciPcdProducerLib.inf
> PciSegmentLib|MdePkg/Library/BasePciSegmentLibPci/BasePciSegmentLibPci.inf
> - PciHostBridgeLib|ArmVirtPkg/Library/FdtPciHostBridgeLib/FdtPciHostBridgeLib.inf
> + PciHostBridgeLib|OvmfPkg/Fdt/FdtPciHostBridgeLib/FdtPciHostBridgeLib.inf
> PciHostBridgeUtilityLib|OvmfPkg/Library/PciHostBridgeUtilityLib/PciHostBridgeUtilityLib.inf
>
> !if $(TPM2_ENABLE) == TRUE
> diff --git a/ArmVirtPkg/ArmVirtQemuKernel.dsc b/ArmVirtPkg/ArmVirtQemuKernel.dsc
> index 64035a948d..426e0ff1fd 100644
> --- a/ArmVirtPkg/ArmVirtQemuKernel.dsc
> +++ b/ArmVirtPkg/ArmVirtQemuKernel.dsc
> @@ -77,7 +77,7 @@
> FileExplorerLib|MdeModulePkg/Library/FileExplorerLib/FileExplorerLib.inf
> PciPcdProducerLib|OvmfPkg/Fdt/FdtPciPcdProducerLib/FdtPciPcdProducerLib.inf
> PciSegmentLib|MdePkg/Library/BasePciSegmentLibPci/BasePciSegmentLibPci.inf
> - PciHostBridgeLib|ArmVirtPkg/Library/FdtPciHostBridgeLib/FdtPciHostBridgeLib.inf
> + PciHostBridgeLib|OvmfPkg/Fdt/FdtPciHostBridgeLib/FdtPciHostBridgeLib.inf
> PciHostBridgeUtilityLib|OvmfPkg/Library/PciHostBridgeUtilityLib/PciHostBridgeUtilityLib.inf
> TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf
>
> diff --git a/ArmVirtPkg/Library/FdtPciHostBridgeLib/FdtPciHostBridgeLib.inf b/OvmfPkg/Fdt/FdtPciHostBridgeLib/FdtPciHostBridgeLib.inf
> similarity index 81%
> rename from ArmVirtPkg/Library/FdtPciHostBridgeLib/FdtPciHostBridgeLib.inf
> rename to OvmfPkg/Fdt/FdtPciHostBridgeLib/FdtPciHostBridgeLib.inf
> index f149693fa2..e610e3d03f 100644
> --- a/ArmVirtPkg/Library/FdtPciHostBridgeLib/FdtPciHostBridgeLib.inf
> +++ b/OvmfPkg/Fdt/FdtPciHostBridgeLib/FdtPciHostBridgeLib.inf
> @@ -20,15 +20,13 @@
> # The following information is for reference only and not required by the build
> # tools.
> #
> -# VALID_ARCHITECTURES = AARCH64 ARM
> +# VALID_ARCHITECTURES = AARCH64 ARM RISCV64
> #
>
> [Sources]
> FdtPciHostBridgeLib.c
>
> [Packages]
> - ArmPkg/ArmPkg.dec
> - ArmVirtPkg/ArmVirtPkg.dec
> EmbeddedPkg/EmbeddedPkg.dec
> MdeModulePkg/MdeModulePkg.dec
> MdePkg/MdePkg.dec
> @@ -44,8 +42,8 @@
> PciPcdProducerLib
>
> [FixedPcd]
> - gArmTokenSpaceGuid.PcdPciMmio32Translation
> - gArmTokenSpaceGuid.PcdPciMmio64Translation
> + gEfiMdePkgTokenSpaceGuid.PcdPciMmio32Translation
> + gEfiMdePkgTokenSpaceGuid.PcdPciMmio64Translation
>
> [Pcd]
> gEfiMdePkgTokenSpaceGuid.PcdPciIoTranslation
> diff --git a/ArmVirtPkg/Library/FdtPciHostBridgeLib/FdtPciHostBridgeLib.c b/OvmfPkg/Fdt/FdtPciHostBridgeLib/FdtPciHostBridgeLib.c
> similarity index 100%
> rename from ArmVirtPkg/Library/FdtPciHostBridgeLib/FdtPciHostBridgeLib.c
> rename to OvmfPkg/Fdt/FdtPciHostBridgeLib/FdtPciHostBridgeLib.c
>
next prev parent reply other threads:[~2021-09-28 23:25 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-28 8:30 [PATCH V2 0/9] Migrate ArmVirtPkg modules to OvmfPkg Abner Chang
2021-09-28 8:30 ` [PATCH V2 1/9] ArmVirtPkg/FdtClintDxe: Move FdtClientDxe to EmbeddedPkg Abner Chang
2021-09-28 23:09 ` Daniel Schaefer
2021-09-28 8:31 ` [PATCH V2 2/9] MdePkg: Add PcdPciIoTranslation PCD Abner Chang
2021-09-28 23:10 ` Daniel Schaefer
2021-09-29 0:51 ` Abner Chang
2021-09-29 1:10 ` 回复: [edk2-devel] " gaoliming
2021-09-28 8:31 ` [PATCH V2 3/9] ArmPkg: Use PcdPciIoTranslation PCD from MdePkg Abner Chang
2021-09-28 23:38 ` Daniel Schaefer
2021-09-28 8:31 ` [PATCH V2 4/9] ArmVirtPkg/FdtPciPcdProducerLib: Relocate PciPcdProducerLib to OvmfPkg Abner Chang
2021-09-28 23:16 ` Daniel Schaefer
[not found] ` <16A91FA9AD0B84BA.7073@groups.io>
2021-09-28 23:41 ` [edk2-devel] " Daniel Schaefer
2021-09-29 0:42 ` Abner Chang
2021-09-28 8:31 ` [PATCH V2 5/9] ArmVirtPkg/HighMemDxe: Relocate HighMemDxe " Abner Chang
2021-09-28 23:34 ` Daniel Schaefer
2021-09-28 8:31 ` [PATCH V2 6/9] ArmVirtPkg/QemuFwCfgLib: Relocate QemuFwCfgLib " Abner Chang
2021-09-28 11:43 ` [edk2-devel] " Gerd Hoffmann
2021-09-29 9:45 ` Sami Mujawar
2021-09-29 10:04 ` Yao, Jiewen
2021-09-29 11:33 ` Sami Mujawar
2021-09-29 12:26 ` [edk2-devel] " Yao, Jiewen
2021-09-29 12:46 ` Abner Chang
2021-09-29 12:57 ` Yao, Jiewen
2021-09-28 8:31 ` [PATCH V2 7/9] MdePkg: Add PcdPciMmio32(64)Translation PCDs Abner Chang
2021-09-28 23:36 ` Daniel Schaefer
2021-09-29 0:54 ` Abner Chang
2021-09-28 8:31 ` [PATCH V2 8/9] ArmVirtPkg/FdtPciHostBridgeLib: Relocate FdtPciHostBridgeLib to OvmfPkg/Fdt Abner Chang
2021-09-28 23:25 ` Daniel Schaefer [this message]
2021-09-28 8:31 ` [PATCH V2 9/9] ArmVirtPkg/VirtioFdtDxe: Relocate VirtioFdtDxe " Abner Chang
2021-09-28 23:36 ` Daniel Schaefer
2021-09-28 23:11 ` [PATCH V2 0/9] Migrate ArmVirtPkg modules to OvmfPkg Daniel Schaefer
2021-09-29 0:53 ` Abner Chang
2021-09-29 1:30 ` 回复: [edk2-devel] " gaoliming
2021-09-29 1:43 ` Abner Chang
2021-09-29 3:31 ` Abner Chang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98cf1905-22c1-9274-6005-8768adb67374@hpe.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox