From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web12.2514.1628213686804139497 for ; Thu, 05 Aug 2021 18:34:46 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@linux.microsoft.com header.s=default header.b=l89TYMGb; spf=pass (domain: linux.microsoft.com, ip: 13.77.154.182, mailfrom: mikuback@linux.microsoft.com) Received: from [10.124.238.202] (unknown [167.220.2.74]) by linux.microsoft.com (Postfix) with ESMTPSA id 7EC5020B36EA; Thu, 5 Aug 2021 18:34:46 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 7EC5020B36EA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1628213686; bh=g6dSm4L4PfQzcTBEZQra4rwnT/A7fj00N3xO+qEJIQA=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=l89TYMGbe4cx/m+CPAP3h43+k6mloWpCrKCkqMY4DcZr2iUmPanM2UMStHKFOPzD5 IF6KGgroy4xlGbb7HWhzcreqE5y1K21sTFyqsn3pCdCnZxEsp0m9qk4JHwe32mbMBz AB9o2BUrH2EMK6Egu5N25CijmnUxw4uN0RfOOptI= Subject: Re: [edk2-devel] [edk2-platforms][PATCH v1 0/5] MinPlatformPkg: TestPointCheckLib bug fixes and improvements To: devel@edk2.groups.io, nathaniel.l.desimone@intel.com Cc: "Chiu, Chasel" , Liming Gao , "Dong, Eric" References: <20210805145706.2470-1-mikuback@linux.microsoft.com> From: "Michael Kubacki" Message-ID: <98d4b6e3-1dda-2b02-d7ad-f4f81e77270b@linux.microsoft.com> Date: Thu, 5 Aug 2021 21:34:46 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Thanks for the feedback, I addressed it in a v2 series: https://edk2.groups.io/g/devel/message/78767 Regards, Michael On 8/5/2021 7:14 PM, Nate DeSimone wrote: > Hi Michael, > > Here is a summary of my feedback: > > 1. Patch 2/5: DxeCheckTcgTrustedBoot.c: line 44 - I think we should also have a ZeroMem ((VOID *) &ProtocolCapability, sizeof (ProtocolCapability)) before setting the size. > 2. Patch 3/5: SmmTestPointCheckLib.c: line 112 - I think we should have a #define that describes whatever "6" means in this context. > > Everything else looks good! > > Thanks, > Nate > >> -----Original Message----- >> From: devel@edk2.groups.io On Behalf Of Michael >> Kubacki >> Sent: Thursday, August 5, 2021 7:57 AM >> To: devel@edk2.groups.io >> Cc: Chiu, Chasel ; Desimone, Nathaniel L >> ; Liming Gao >> ; Dong, Eric >> Subject: [edk2-devel] [edk2-platforms][PATCH v1 0/5] MinPlatformPkg: >> TestPointCheckLib bug fixes and improvements >> >> From: Michael Kubacki >> >> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3531 >> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3518 >> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3520 >> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3521 >> >> This patch series groups together several bug fixes and improvements to >> TestPointCheckLib. The first patch is required for the others since it fixes a >> MinPlatformPkg build issue that occurs with the current edk2/master branch. >> >> Cc: Chasel Chiu >> Cc: Nate DeSimone >> Cc: Liming Gao >> Cc: Eric Dong >> Signed-off-by: Michael Kubacki >> >> Michael Kubacki (5): >> MinPlatformPkg/TestPointCheckLib: Fix MessageLength cast issue >> MinPlatformPkg/TestPointCheckLib: Set required size field in protocol >> MinPlatformPkg/TestPointCheckLib: Fix incorrect array index >> MinPlatformPkg/TestPointCheckLib: Improve adjacent region checking >> MinPlatformPkg/TestPointCheckLib: Make OutTable parameter optional >> >> >> Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckA >> cpi.c | 32 +++++------ >> >> Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckS >> miHandlerInstrument.c | 4 +- >> >> Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckS >> mmInfo.c | 56 ++++++++++---------- >> >> Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckTc >> gTrustedBoot.c | 1 + >> >> Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeTestPoi >> ntCheckLib.c | 15 +++++- >> >> Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/SmmTestPo >> intCheckLib.c | 4 +- >> Platform/Intel/MinPlatformPkg/Test/TestPointStubDxe/TestPointStubDxe.c >> | 10 ++-- >> >> Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeTestPoi >> ntCheckLib.inf | 1 + >> 8 files changed, 70 insertions(+), 53 deletions(-) >> >> -- >> 2.28.0.windows.1 >> >> >> >> -=-=-=-=-=-= >> Groups.io Links: You receive all messages sent to this group. >> View/Reply Online (#78710): https://edk2.groups.io/g/devel/message/78710 >> Mute This Topic: https://groups.io/mt/84686301/1767664 >> Group Owner: mailto:devel+owner@edk2.groups.io >> Unsubscribe: https://edk2.groups.io/g/devel/unsub >> [nathaniel.l.desimone@intel.com] >> -=-=-=-=-=-= >> > > > > >