From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.120]) by mx.groups.io with SMTP id smtpd.web12.34579.1591010276662131798 for ; Mon, 01 Jun 2020 04:17:57 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=RzSUIGNT; spf=pass (domain: redhat.com, ip: 205.139.110.120, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1591010275; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Ke9R7wqM7Y2Kn+3HUf4kG9LO0TZG7zEaVBdBv4phNFY=; b=RzSUIGNTKhs2hr9StkS/7MUPy/N6u0DpneoXX+fC65sJdLnJ+jvh+kMSkSuX+CXBpjQaLR DM2D3mtndQbj0Gz293tOWs+1aYV1WutJ9zR1plB9lIuysLVxZkNIvCFiLDVq3R5u8tYjbJ id9F4BWpKF5wWRtETuW2g4nqoUm5Yo0= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-240-_GBso86dOT-BNfgtAhdteg-1; Mon, 01 Jun 2020 07:17:54 -0400 X-MC-Unique: _GBso86dOT-BNfgtAhdteg-1 Received: by mail-wr1-f69.google.com with SMTP id h92so4744383wrh.23 for ; Mon, 01 Jun 2020 04:17:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=Ke9R7wqM7Y2Kn+3HUf4kG9LO0TZG7zEaVBdBv4phNFY=; b=QH8xOx97MapaSWjY0X3fKv5KpcOrVFriVCL7uB4Y1gP2ViC7RHEGGJ0zypiabJi6kK lLRL0pOERRpWsDvUmj1XIo1c4SfBzFG9Uida+Je/VUBPOYysgCF4QOf01uiCqcmA1kfr cs6lr/RCPlVUdf1xUrm3yw3/0ijQD6BE6mOMEvlE2PLrVaPJsCf2WSGIrvefo75AHla2 H3Rs8Nzh9cE20sZZlr5/ph2Hzgdcxfhhofby1Q2tZO3nIAtpWrfmenAOA6yiySPxpSqh 67YMBfJ9y6tNqMtWTh0k41znjRb72C0AQi/NizSy/dqb1Qj1Yc4WHFS6bpw+OgIztlB3 fzUw== X-Gm-Message-State: AOAM532mKIxAFmOx4fHU0pkDw8eLCCA3gA9vyGhKEcc4BS+PPhbMMrRq NE8uteq4AnfU05nyvQXmL0El6Nt2Qav4NkGyZHgoinoONYlW0cx8aLYzCO2b3ngpxLOEkhySLgt O0wx6rrNwLh2Xwg== X-Received: by 2002:a1c:7903:: with SMTP id l3mr13930706wme.50.1591010272984; Mon, 01 Jun 2020 04:17:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzcBYYEVWpO4eSfMtGe4vA4UjlNdM1Y5spqXlHoWFqWymhuFvr5hTixr+1TuZOiU5HsVHcv8g== X-Received: by 2002:a1c:7903:: with SMTP id l3mr13930692wme.50.1591010272786; Mon, 01 Jun 2020 04:17:52 -0700 (PDT) Return-Path: Received: from [192.168.1.34] (43.red-83-51-162.dynamicip.rima-tde.net. [83.51.162.43]) by smtp.gmail.com with ESMTPSA id z132sm13524225wmc.29.2020.06.01.04.17.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 01 Jun 2020 04:17:52 -0700 (PDT) Subject: Re: [edk2-devel] [PATCH v2] MdePkg: Include Acpi header file To: Wasim Khan , "devel@edk2.groups.io" Cc: "michael.d.kinney@intel.com" , "liming.gao@intel.com" , Varun Sethi References: <1587368881-1800-1-git-send-email-wasim.khan@nxp.com> <3b312fb3-7d9f-f951-870e-59811f2b14ba@redhat.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Autocrypt: addr=philmd@redhat.com; keydata= mQINBDXML8YBEADXCtUkDBKQvNsQA7sDpw6YLE/1tKHwm24A1au9Hfy/OFmkpzo+MD+dYc+7 bvnqWAeGweq2SDq8zbzFZ1gJBd6+e5v1a/UrTxvwBk51yEkadrpRbi+r2bDpTJwXc/uEtYAB GvsTZMtiQVA4kRID1KCdgLa3zztPLCj5H1VZhqZsiGvXa/nMIlhvacRXdbgllPPJ72cLUkXf z1Zu4AkEKpccZaJspmLWGSzGu6UTZ7UfVeR2Hcc2KI9oZB1qthmZ1+PZyGZ/Dy+z+zklC0xl XIpQPmnfy9+/1hj1LzJ+pe3HzEodtlVA+rdttSvA6nmHKIt8Ul6b/h1DFTmUT1lN1WbAGxmg CH1O26cz5nTrzdjoqC/b8PpZiT0kO5MKKgiu5S4PRIxW2+RA4H9nq7nztNZ1Y39bDpzwE5Sp bDHzd5owmLxMLZAINtCtQuRbSOcMjZlg4zohA9TQP9krGIk+qTR+H4CV22sWldSkVtsoTaA2 qNeSJhfHQY0TyQvFbqRsSNIe2gTDzzEQ8itsmdHHE/yzhcCVvlUzXhAT6pIN0OT+cdsTTfif MIcDboys92auTuJ7U+4jWF1+WUaJ8gDL69ThAsu7mGDBbm80P3vvUZ4fQM14NkxOnuGRrJxO qjWNJ2ZUxgyHAh5TCxMLKWZoL5hpnvx3dF3Ti9HW2dsUUWICSQARAQABtDJQaGlsaXBwZSBN YXRoaWV1LURhdWTDqSAoUGhpbCkgPHBoaWxtZEByZWRoYXQuY29tPokCVQQTAQgAPwIbDwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4AWIQSJweePYB7obIZ0lcuio/1u3q3A3gUCXsfWwAUJ KtymWgAKCRCio/1u3q3A3ircD/9Vjh3aFNJ3uF3hddeoFg1H038wZr/xi8/rX27M1Vj2j9VH 0B8Olp4KUQw/hyO6kUxqkoojmzRpmzvlpZ0cUiZJo2bQIWnvScyHxFCv33kHe+YEIqoJlaQc JfKYlbCoubz+02E2A6bFD9+BvCY0LBbEj5POwyKGiDMjHKCGuzSuDRbCn0Mz4kCa7nFMF5Jv piC+JemRdiBd6102ThqgIsyGEBXuf1sy0QIVyXgaqr9O2b/0VoXpQId7yY7OJuYYxs7kQoXI 6WzSMpmuXGkmfxOgbc/L6YbzB0JOriX0iRClxu4dEUg8Bs2pNnr6huY2Ft+qb41RzCJvvMyu gS32LfN0bTZ6Qm2A8ayMtUQgnwZDSO23OKgQWZVglGliY3ezHZ6lVwC24Vjkmq/2yBSLakZE 6DZUjZzCW1nvtRK05ebyK6tofRsx8xB8pL/kcBb9nCuh70aLR+5cmE41X4O+MVJbwfP5s/RW 9BFSL3qgXuXso/3XuWTQjJJGgKhB6xXjMmb1J4q/h5IuVV4juv1Fem9sfmyrh+Wi5V1IzKI7 RPJ3KVb937eBgSENk53P0gUorwzUcO+ASEo3Z1cBKkJSPigDbeEjVfXQMzNt0oDRzpQqH2vp apo2jHnidWt8BsckuWZpxcZ9+/9obQ55DyVQHGiTN39hkETy3Emdnz1JVHTU0Q== Message-ID: <98de7929-4b66-95d7-d973-064f5811fb62@redhat.com> Date: Mon, 1 Jun 2020 13:17:51 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit On 6/1/20 1:16 PM, Wasim Khan wrote: > > >> -----Original Message----- >> From: Philippe Mathieu-Daudé >> Sent: Monday, June 1, 2020 2:17 PM >> To: devel@edk2.groups.io; Wasim Khan >> Cc: michael.d.kinney@intel.com; liming.gao@intel.com; Varun Sethi >> >> Subject: Re: [edk2-devel] [PATCH v2] MdePkg: Include Acpi header file >> >> On 4/20/20 9:48 AM, Wasim Khan wrote: >>> ACPI memory mapped configuration space access (MCFG) table requires >>> defination of EFI_ACPI_DESCRIPTION_HEADER. >> >> What about: >> >> - DynamicTablesPkg/Include/Library/TableHelperLib.h >> - DynamicTablesPkg/Include/StandardNameSpaceObjects.h >> - EmbeddedPkg/Include/Library/AcpiLib.h > > EmbeddedPkg/Include/Library/AcpiLib.h => Acpi10.h is included in this file. > For other two, Acpi.h /Acpi10.h has been included in the files where above header file are used. OK, thanks Wasim. Reviewed-by: Philippe Mathieu-Daude > >> >>> >>> Signed-off-by: Wasim Khan >>> --- >>> Changes in v2: Corrected typo in subject >>> >>> .../IndustryStandard/MemoryMappedConfigurationSpaceAccessTable.h | >> 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git >>> >> a/MdePkg/Include/IndustryStandard/MemoryMappedConfigurationSpaceAccess >>> Table.h >>> >> b/MdePkg/Include/IndustryStandard/MemoryMappedConfigurationSpaceAccess >>> Table.h >>> index 3356ec9..8a4933d 100644 >>> --- >>> >> a/MdePkg/Include/IndustryStandard/MemoryMappedConfigurationSpaceAccess >>> Table.h >>> +++ >> b/MdePkg/Include/IndustryStandard/MemoryMappedConfigurationSpaceAc >>> +++ cessTable.h >>> @@ -10,6 +10,8 @@ >>> #ifndef _MEMORY_MAPPED_CONFIGURATION_SPACE_ACCESS_TABLE_H_ >>> #define _MEMORY_MAPPED_CONFIGURATION_SPACE_ACCESS_TABLE_H_ >>> >>> +#include >>> + >>> // >>> // Ensure proper structure formats >>> // >>> >