From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id F0B68211C6060 for ; Fri, 1 Feb 2019 00:56:31 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7DDB8432AE; Fri, 1 Feb 2019 08:56:31 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-49.rdu2.redhat.com [10.10.120.49]) by smtp.corp.redhat.com (Postfix) with ESMTP id 529DB608C6; Fri, 1 Feb 2019 08:56:30 +0000 (UTC) To: Shenglei Zhang , edk2-devel@lists.01.org Cc: Liming Gao References: <20190201053445.13660-1-shenglei.zhang@intel.com> <20190201053445.13660-9-shenglei.zhang@intel.com> From: Laszlo Ersek Message-ID: <9910bec4-3517-6707-2cf6-ba6220664043@redhat.com> Date: Fri, 1 Feb 2019 09:56:29 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190201053445.13660-9-shenglei.zhang@intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Fri, 01 Feb 2019 08:56:31 +0000 (UTC) Subject: Re: [PATCH 08/10] BaseTools/tools_def.template: Remove ELFGCC X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Feb 2019 08:56:32 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 02/01/19 06:34, Shenglei Zhang wrote: > ELFGCC is too old.There is no verification for it. > https://bugzilla.tianocore.org/show_bug.cgi?id=1377 > > Cc: Bob Feng > Cc: Liming Gao > Cc: Yonghong Zhu > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Shenglei Zhang > --- > BaseTools/Conf/tools_def.template | 80 ------------------------------- > 1 file changed, 80 deletions(-) > > diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def.template > index e73fec42bf..0e671d55bc 100755 > --- a/BaseTools/Conf/tools_def.template > +++ b/BaseTools/Conf/tools_def.template > @@ -136,7 +136,6 @@ DEFINE ICC11_BIN64x86 = C:\Program Files (x86)\Intel\Compiler\DEF(ICC11_VERS > DEFINE EBC_BIN = C:\Program Files\Intel\EBC\Bin > DEFINE EBC_BINx86 = C:\Program Files (x86)\Intel\EBC\Bin > > -DEFINE ELFGCC_BIN = /usr/bin > > DEFINE CYGWIN_BIN = c:/cygwin/bin > DEFINE CYGWIN_BINIA32 = c:/cygwin/opt/tiano/i386-tiano-pe/i386-tiano-pe/bin/ > @@ -296,12 +295,6 @@ DEFINE DTC_BIN = ENV(DTC_PREFIX)dtc > # Required to build platforms or ACPI tables: > # Intel(r) ACPI Compiler from > # https://acpica.org/downloads > -# ELFGCC -Linux- Requires: > -# GCC(this tool chain uses whatever version of gcc and binutils that is installed in /usr/bin) > -# Optional: > -# Required to build platforms or ACPI tables: > -# Intel(r) ACPI Compiler from > -# https://acpica.org/downloads > # CYGGCC -win32- Requires: > # CygWin, GCC 4.3.0, binutils 2.20.51.0.5 > # Microsoft Visual Studio 2005 or 2008 > @@ -3999,79 +3992,6 @@ RELEASE_CLANG38_AARCH64_DLINK_FLAGS = DEF(CLANG38_AARCH64_DLINK_FLAGS) -flto -Wl > *_CYGGCCxASL_EBC_SLINK_FLAGS = /lib /NOLOGO /MACHINE:EBC > *_CYGGCCxASL_EBC_DLINK_FLAGS = "C:\Program Files\Intel\EBC\Lib\EbcLib.lib" /NOLOGO /NODEFAULTLIB /MACHINE:EBC /OPT:REF /ENTRY:$(IMAGE_ENTRY_POINT) /SUBSYSTEM:EFI_BOOT_SERVICE_DRIVER /ALIGN:32 /DRIVER > > -#################################################################################### > -# > -# Elf GCC - This configuration is used to compile on Linux boxes to produce elf > -# binaries. > -# > -#################################################################################### > -# ELFGCC - Linux ELF GCC > -*_ELFGCC_*_*_FAMILY = GCC > -*_ELFGCC_*_*_BUILDRULEFAMILY = GCCLD > -*_ELFGCC_*_MAKE_PATH = make > - > -*_ELFGCC_*_PP_FLAGS = -E -x assembler-with-cpp -include AutoGen.h > -*_ELFGCC_*_VFRPP_FLAGS = -x c -E -P -DVFRCOMPILE --include $(MODULE_NAME)StrDefs.h > - > -################## > -# ASL definitions > -################## > -*_ELFGCC_*_ASL_PATH = DEF(UNIX_IASL_BIN) > -*_ELFGCC_*_ASL_FLAGS = DEF(IASL_FLAGS) > -*_ELFGCC_*_ASL_OUTFLAGS = DEF(IASL_OUTFLAGS) > -*_ELFGCC_*_ASLPP_FLAGS = -x c -E -include AutoGen.h > -*_ELFGCC_*_ASLCC_FLAGS = -x c > -*_ELFGCC_*_ASLDLINK_FLAGS = DEF(GCC_DLINK_FLAGS_COMMON) --entry _ReferenceAcpiTable > - > -################## > -# IA32 definitions > -################## > -*_ELFGCC_IA32_OBJCOPY_PATH = DEF(ELFGCC_BIN)/objcopy > -*_ELFGCC_IA32_CC_PATH = DEF(ELFGCC_BIN)/gcc > -*_ELFGCC_IA32_SLINK_PATH = DEF(ELFGCC_BIN)/ar > -*_ELFGCC_IA32_DLINK_PATH = DEF(ELFGCC_BIN)/ld > -*_ELFGCC_IA32_ASM_PATH = DEF(ELFGCC_BIN)/gcc > -*_ELFGCC_IA32_PP_PATH = DEF(ELFGCC_BIN)/gcc > -*_ELFGCC_IA32_VFRPP_PATH = DEF(ELFGCC_BIN)/gcc > -*_ELFGCC_IA32_ASLCC_PATH = DEF(ELFGCC_BIN)/gcc > -*_ELFGCC_IA32_ASLPP_PATH = DEF(ELFGCC_BIN)/gcc > -*_ELFGCC_IA32_ASLDLINK_PATH = DEF(ELFGCC_BIN)/ld > -*_ELFGCC_IA32_RC_PATH = DEF(ELFGCC_BIN)/objcopy > - > -*_ELFGCC_IA32_CC_FLAGS = -m32 -g -fshort-wchar -fno-strict-aliasing -Wall -malign-double -include $(DEST_DIR_DEBUG)/AutoGen.h -DSTRING_ARRAY_NAME=$(BASE_NAME)Strings > -*_ELFGCC_IA32_SLINK_FLAGS = > -*_ELFGCC_IA32_DLINK_FLAGS = -melf_i386 -nostdlib --shared --entry $(IMAGE_ENTRY_POINT) -u $(IMAGE_ENTRY_POINT) -Map $(DEST_DIR_DEBUG)/$(BASE_NAME).map > -#*_ELFGCC_IA32_DLINK_FLAGS = -melf_i386 -nostdlib -n -q -Ttext 0x220 --entry $(IMAGE_ENTRY_POINT) -u $(IMAGE_ENTRY_POINT) > -*_ELFGCC_IA32_ASM_FLAGS = -m32 -c -x assembler -imacros $(DEST_DIR_DEBUG)/AutoGen.h > -*_ELFGCC_IA32_PP_FLAGS = -m32 -E -x assembler-with-cpp -include $(DEST_DIR_DEBUG)/AutoGen.h > -*_ELFGCC_IA32_VFRPP_FLAGS = -x c -E -P -DVFRCOMPILE --include $(DEST_DIR_DEBUG)/$(MODULE_NAME)StrDefs.h > -*_ELFGCC_IA32_RC_FLAGS = DEF(GCC_IA32_RC_FLAGS) > -*_ELFGCC_IA32_OBJCOPY_FLAGS = > -*_ELFGCC_IA32_NASM_FLAGS = -f elf32 > - > -################## > -# X64 definitions > -################## > -*_ELFGCC_X64_CC_PATH = DEF(ELFGCC_BIN)/gcc > -*_ELFGCC_X64_ASLCC_PATH = DEF(ELFGCC_BIN)/gcc > -*_ELFGCC_X64_SLINK_PATH = DEF(ELFGCC_BIN)/ar > -*_ELFGCC_X64_DLINK_PATH = DEF(ELFGCC_BIN)/ld > -*_ELFGCC_X64_ASLDLINK_PATH = DEF(ELFGCC_BIN)/ld > -*_ELFGCC_X64_ASM_PATH = DEF(ELFGCC_BIN)/gcc > -*_ELFGCC_X64_PP_PATH = DEF(ELFGCC_BIN)/gcc > -*_ELFGCC_X64_ASLPP_PATH = DEF(ELFGCC_BIN)/gcc > -*_ELFGCC_X64_VFRPP_PATH = DEF(ELFGCC_BIN)/gcc > -*_ELFGCC_X64_RC_PATH = DEF(ELFGCC_BIN)/objcopy > - > -*_ELFGCC_X64_CC_FLAGS = -Os -fshort-wchar -fno-strict-aliasing -Wall -Werror -Wno-address -Wno-array-bounds -include AutoGen.h -D_EFI_P64 > -*_ELFGCC_X64_DLINK_FLAGS = -nostdlib --shared --entry $(IMAGE_ENTRY_POINT) -u $(IMAGE_ENTRY_POINT) -Map $(DEST_DIR_DEBUG)/$(BASE_NAME).map > -*_ELFGCC_X64_SLINK_FLAGS = > -*_ELFGCC_X64_ASM_FLAGS = -c -x assembler -imacros $(DEST_DIR_DEBUG)/AutoGen.h > -*_ELFGCC_X64_PP_FLAGS = -E -x assembler-with-cpp -include $(DEST_DIR_DEBUG)/AutoGen.h > -*_ELFGCC_X64_VFRPP_FLAGS = -x c -E -P -DVFRCOMPILE --include $(DEST_DIR_DEBUG)/$(MODULE_NAME)StrDefs.h > -*_ELFGCC_X64_RC_FLAGS = DEF(GCC_X64_RC_FLAGS) > -*_ELFGCC_X64_NASM_FLAGS = -f elf64 > - > #################################################################################### > # > # Intel(R) C++ Compiler Version 9.1 > Reviewed-by: Laszlo Ersek