From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id B9B04D8100D for ; Tue, 19 Sep 2023 14:53:04 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=U9weH2vY3x5zRgdg4Z/tWtJYlqKEX6z/L+HuCpqbUtA=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:CC:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1695135183; v=1; b=ZeALHKwGfdXDwEaLrvP71bULBTMBjXLZhg02k47EQP8uWwhbJ7PqTpCIpK8MdgQPiNHIQ+ag cY9WBSr8T4NTjXYEw5XajHAYxlhhZ0UAnal7wjV3pL0Fwd53Yxiz+nLX3PZNIcJ5DJ9xcYU4cAJ 0wxwXsPQsGMG47YGX5a5FyKg= X-Received: by 127.0.0.2 with SMTP id 1L0pYY7687511xvahEUzLxMi; Tue, 19 Sep 2023 07:53:03 -0700 X-Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by mx.groups.io with SMTP id smtpd.web11.11418.1695135182714471329 for ; Tue, 19 Sep 2023 07:53:02 -0700 X-Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 38JEoanJ004344; Tue, 19 Sep 2023 14:52:56 GMT X-Received: from nasanppmta03.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3t72ngs8nk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 19 Sep 2023 14:52:55 +0000 X-Received: from nasanex01c.na.qualcomm.com (nasanex01c.na.qualcomm.com [10.45.79.139]) by NASANPPMTA03.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 38JEqscP008139 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 19 Sep 2023 14:52:54 GMT X-Received: from [10.111.128.147] (10.80.80.8) by nasanex01c.na.qualcomm.com (10.45.79.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.36; Tue, 19 Sep 2023 07:52:53 -0700 Message-ID: <991610c3-8d67-40f6-affa-32ef563b5fee@quicinc.com> Date: Tue, 19 Sep 2023 15:52:50 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH v2 4/7] ArmVirtPkg.ci.yaml: Add debug macro exception To: , , Michael Kubacki , Michael Kinney , Andrew Fish CC: Sami Mujawar , Gerd Hoffmann References: <20230913170617.429-1-mikuback@linux.microsoft.com> <20230913170617.429-5-mikuback@linux.microsoft.com> <0c073095-9f42-c740-72d4-a74a8c1b4ccc@linux.microsoft.com> From: "Leif Lindholm" In-Reply-To: X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nasanex01c.na.qualcomm.com (10.45.79.139) X-QCInternal: smtphost X-Proofpoint-GUID: fkp4uVZbcKgdbxlPG8KHWN10CNknn5y_ X-Proofpoint-ORIG-GUID: fkp4uVZbcKgdbxlPG8KHWN10CNknn5y_ Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,quic_llindhol@quicinc.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: UDbLSvjMoen90WlxmA8AvVClx7686176AA= Content-Language: en-GB Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=ZeALHKwG; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=quicinc.com (policy=none) On 2023-09-19 15:46, Ard Biesheuvel wrote: > On Mon, 18 Sept 2023 at 22:35, Michael Kubacki > wrote: >> >> Thanks Ard. I still need a Reviewed-by on this patch to complete the ser= ies. >=20 > Actually, you don't but I suppose there is some difference of > interpretation here. >=20 > In the Linux community (where these tags originated), an ack from a > maintainer means 'no objections, feel free to apply this to code that > I maintain'. In this case, I am not 100% sure what the change means, > so I am not comfortable claiming that I reviewed it, but given that > this is your area of expertise rather than mine, I trust that you know > what you are doing. Hence the acked-by. >=20 > In other cases, I may rely on another person's expertise and their > reviewed-by to decide whether or not to merge something, rather than > review it myself. In this case, the acked-by is implied by the fact > that I decided to merge the PR (and therefore somewhat redundant). But > it comes down to the same thing. >=20 > If there is a Tianocore rule that says every patch needs a reviewed-by > from a maintainer, we should probably fix that. It is *not* the job of > a maintainer to review everything (and this wouldn't scale to begin > with) - rather, it is their job to ensure that everything that gets > merged has been reviewed sufficiently, either by themselves or by > other people they have confidence in. I was under the impression we had this conversation a few years ago and=20 agreed a maintainer Ack was sufficient. Have we failed to document that=20 fact? / Leif >> On 9/13/2023 1:10 PM, Ard Biesheuvel wrote: >>> On Wed, 13 Sept 2023 at 19:07, wrote: >>>> >>>> From: Michael Kubacki >>>> >>>> Adds a CI YAML entry to acknowledge a case where a macro is expanded >>>> that contains a print specifier. >>>> >>>> Cc: Ard Biesheuvel >>>> Cc: Leif Lindholm >>>> Cc: Sami Mujawar >>>> Cc: Gerd Hoffmann >>>> Signed-off-by: Michael Kubacki >>> >>> Acked-by: Ard Biesheuvel >>> >>>> --- >>>> ArmVirtPkg/ArmVirtPkg.ci.yaml | 8 ++++++++ >>>> 1 file changed, 8 insertions(+) >>>> >>>> diff --git a/ArmVirtPkg/ArmVirtPkg.ci.yaml b/ArmVirtPkg/ArmVirtPkg.ci.= yaml >>>> index 1e799dc4e194..506b0e72f0bb 100644 >>>> --- a/ArmVirtPkg/ArmVirtPkg.ci.yaml >>>> +++ b/ArmVirtPkg/ArmVirtPkg.ci.yaml >>>> @@ -125,5 +125,13 @@ >>>> ], # words to extend to the dictionary for this p= ackage >>>> "IgnoreStandardPaths": [], # Standard Plugin defined path= s that should be ignore >>>> "AdditionalIncludePaths": [] # Additional paths to spell ch= eck (wildcards supported) >>>> + }, >>>> + >>>> + "DebugMacroCheck": { >>>> + "StringSubstitutions": { >>>> + # DynamicTablesPkg/Include/ConfigurationManagerObject.h >>>> + # Reason: Expansion of macro that contains a print specifie= r. >>>> + "FMT_CM_OBJECT_ID": "0x%lx" >>>> + } >>>> } >>>> } >>>> -- >>>> 2.42.0.windows.2 >>>> >>> >>> >>> >>> >=20 >=20 >=20 >=20 >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108846): https://edk2.groups.io/g/devel/message/108846 Mute This Topic: https://groups.io/mt/101341655/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-