Re: [edk2-devel] [PATCH v1 1/3] DynamicTablesPkg: Adds ACPI FADT Table generator

["PierreGondois" <pierre.gondois@arm.com>]

Hello Abdul,

There is an ongoing effort to open the package a bit more to other
architectures (https://edk2.groups.io/g/devel/message/114790).

This patch seems to duplicate some objects from the Arm namespace:
- EArmObjPowerManagementProfileInfo
- EArmObjBootArchInfo
to the Arch namespace:
- EArchObjFadtPreferredPmProfile
- EArchObjFadtArmBootArch
and adding many objects to the common Arch namespace.

The Fadt Generator will be moved to a common folder to allow other
architectures to re-use the code. I think it might be good to put
this patch aside for now and integrate it to the (to be created)
staging branch instead,

Regards,
Pierre

On 2/20/24 07:48, Abdul Lateef Attar wrote:
> From: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>
> 
> Adds generic ACPI FADT table generator library.
> Register/Deregister FADT table.
> Adds Arch namespace ids.
> Update the FADT table during boot as per specification.
> 
> Cc: Sami Mujawar <Sami.Mujawar@arm.com>
> Cc: Pierre Gondois <pierre.gondois@arm.com>
> Signed-off-by: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>
> ---
>   DynamicTablesPkg/DynamicTables.dsc.inc        |  10 +-
>   DynamicTablesPkg/DynamicTablesPkg.ci.yaml     |   4 +-
>   .../Include/ArchNameSpaceObjects.h            | 217 ++++++
>   .../Include/ConfigurationManagerObject.h      |   6 +
>   .../Library/Acpi/AcpiFadtLib/AcpiFadtLib.inf  |  42 +
>   .../Library/Acpi/AcpiFadtLib/FadtGenerator.c  | 737 ++++++++++++++++++
>   .../Library/Acpi/AcpiFadtLib/FadtUpdate.h     |  28 +
>   .../Library/Acpi/AcpiFadtLib/X64/FadtUpdate.c |  32 +
>   8 files changed, 1074 insertions(+), 2 deletions(-)
>   create mode 100644 DynamicTablesPkg/Include/ArchNameSpaceObjects.h
>   create mode 100644 DynamicTablesPkg/Library/Acpi/AcpiFadtLib/AcpiFadtLib.inf
>   create mode 100644 DynamicTablesPkg/Library/Acpi/AcpiFadtLib/FadtGenerator.c
>   create mode 100644 DynamicTablesPkg/Library/Acpi/AcpiFadtLib/FadtUpdate.h
>   create mode 100644 DynamicTablesPkg/Library/Acpi/AcpiFadtLib/X64/FadtUpdate.c
> 

[snip]


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116052): https://edk2.groups.io/g/devel/message/116052
Mute This Topic: https://groups.io/mt/104463461/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-