From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 72950D811A4 for ; Tue, 27 Feb 2024 16:02:22 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=DZHyjiPIdqr0UACRssk89/RqCACKDf6xxAK/mP8OJSI=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1709049741; v=1; b=FzvoWAwU9YZNNe3iSgdn0rkPriwN0esTgZA3iMYS8LHWp1uw6nEqUJGw8f4beXvUWjvBxA7Q NoQPtbiklRCvcpfPBXAnF89pViKcCN/kotN+KtPUqcnIJy46w33jmEdMDmVHQzOrQRZFnE+8zkE 1TfaErCScVu5Wda/GejSz6SQ= X-Received: by 127.0.0.2 with SMTP id 18b4YY7687511xVCJnViRvdq; Tue, 27 Feb 2024 08:02:21 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web10.15924.1709049740622854493 for ; Tue, 27 Feb 2024 08:02:20 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id BD934FEC; Tue, 27 Feb 2024 08:02:58 -0800 (PST) X-Received: from [192.168.1.13] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2BDCF3F762; Tue, 27 Feb 2024 08:02:19 -0800 (PST) Message-ID: <9919792c-f705-4762-aa39-773e25921019@arm.com> Date: Tue, 27 Feb 2024 17:02:19 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH v1 1/3] DynamicTablesPkg: Adds ACPI FADT Table generator To: Abdul Lateef Attar , devel@edk2.groups.io Cc: Abdul Lateef Attar , Sami Mujawar References: From: "PierreGondois" In-Reply-To: Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: uVfAo1tW7irMreni94nsMiT2x7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=FzvoWAwU; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=arm.com (policy=none) Hello Abdul, There is an ongoing effort to open the package a bit more to other architectures (https://edk2.groups.io/g/devel/message/114790). This patch seems to duplicate some objects from the Arm namespace: - EArmObjPowerManagementProfileInfo - EArmObjBootArchInfo to the Arch namespace: - EArchObjFadtPreferredPmProfile - EArchObjFadtArmBootArch and adding many objects to the common Arch namespace. The Fadt Generator will be moved to a common folder to allow other architectures to re-use the code. I think it might be good to put this patch aside for now and integrate it to the (to be created) staging branch instead, Regards, Pierre On 2/20/24 07:48, Abdul Lateef Attar wrote: > From: Abdul Lateef Attar >=20 > Adds generic ACPI FADT table generator library. > Register/Deregister FADT table. > Adds Arch namespace ids. > Update the FADT table during boot as per specification. >=20 > Cc: Sami Mujawar > Cc: Pierre Gondois > Signed-off-by: Abdul Lateef Attar > --- > DynamicTablesPkg/DynamicTables.dsc.inc | 10 +- > DynamicTablesPkg/DynamicTablesPkg.ci.yaml | 4 +- > .../Include/ArchNameSpaceObjects.h | 217 ++++++ > .../Include/ConfigurationManagerObject.h | 6 + > .../Library/Acpi/AcpiFadtLib/AcpiFadtLib.inf | 42 + > .../Library/Acpi/AcpiFadtLib/FadtGenerator.c | 737 ++++++++++++++++++ > .../Library/Acpi/AcpiFadtLib/FadtUpdate.h | 28 + > .../Library/Acpi/AcpiFadtLib/X64/FadtUpdate.c | 32 + > 8 files changed, 1074 insertions(+), 2 deletions(-) > create mode 100644 DynamicTablesPkg/Include/ArchNameSpaceObjects.h > create mode 100644 DynamicTablesPkg/Library/Acpi/AcpiFadtLib/AcpiFadtLi= b.inf > create mode 100644 DynamicTablesPkg/Library/Acpi/AcpiFadtLib/FadtGenera= tor.c > create mode 100644 DynamicTablesPkg/Library/Acpi/AcpiFadtLib/FadtUpdate= .h > create mode 100644 DynamicTablesPkg/Library/Acpi/AcpiFadtLib/X64/FadtUp= date.c >=20 [snip] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116052): https://edk2.groups.io/g/devel/message/116052 Mute This Topic: https://groups.io/mt/104463461/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-