From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: None (no SPF record) identity=mailfrom; client-ip=192.55.52.88; helo=mga01.intel.com; envelope-from=stephano.cetola@linux.intel.com; receiver=edk2-devel@lists.01.org Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 693072096185F for ; Tue, 19 Mar 2019 08:44:57 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Mar 2019 08:44:57 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,498,1544515200"; d="scan'208";a="135603249" Received: from scetola-mobl1.amr.corp.intel.com (HELO [10.251.148.231]) ([10.251.148.231]) by fmsmga007.fm.intel.com with ESMTP; 19 Mar 2019 08:44:56 -0700 To: "Gao, Liming" , "Justen, Jordan L" , "Gao, Zhichao" , "edk2-devel@lists.01.org" Cc: "Kinney, Michael D" , Michael Turner , Bret Barkelew References: <20190315051749.6564-1-zhichao.gao@intel.com> <20190315051749.6564-2-zhichao.gao@intel.com> <155263054046.23460.7190580861275117521@jljusten-skl> <3CE959C139B4C44DBEA1810E3AA6F9000B7B0177@SHSMSX101.ccr.corp.intel.com> <155289003042.7045.9736868893658475606@jljusten-skl> <4A89E2EF3DFEDB4C8BFDE51014F606A14E4051CD@SHSMSX104.ccr.corp.intel.com> <155293406174.10930.18102544164165817771@jljusten-skl> <4A89E2EF3DFEDB4C8BFDE51014F606A14E407599@SHSMSX104.ccr.corp.intel.com> From: stephano Message-ID: <994d33cf-4302-94c8-3b0f-032f85f30065@linux.intel.com> Date: Tue, 19 Mar 2019 08:44:56 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.3 MIME-Version: 1.0 In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E407599@SHSMSX104.ccr.corp.intel.com> Subject: Re: [PATCH V2 01/17] MdePkg/DebugLib.h: Add a new api DebugVPrint for DebugLib X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Mar 2019 15:44:58 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 3/19/2019 7:45 AM, Gao, Liming wrote: > Jordan: > I suggest to add the line length discussion in edk2 community meeting. Which length is better, 80 or 120? If we expect every patch follows this rule, do we need update PatchCheck to add the checker, and notify the developer know this requirement? > I've added this discussion to the list for next month's community meeting: https://www.tianocore.org/community-meeting/ Cheers, Stephano