From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 5E1CF7803CE for ; Sun, 29 Oct 2023 13:48:33 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=Xg/2tLhUejdy/DxeMZQgQhrCNgEyFeo+CSwCYiEGJ1w=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1698587311; v=1; b=I0DgFoWvn3RlVcHtROBdDukI8VPjPD/x4tBy85JEEtUn5A40Tz/jjs29rcZo1uhQwtOexUVd 5gdKDE0ysH5/rLAOoH1C2wRz0azZyagSTTFRrhFVdb+q2MsvKCRYsOQHr15dnoGN7mqC7JfBIL9 nrcv4zguPwAzBEH1qXcxuUcQ= X-Received: by 127.0.0.2 with SMTP id DghuYY7687511xJSgnN7mhLY; Sun, 29 Oct 2023 06:48:31 -0700 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web10.72369.1698587311223102233 for ; Sun, 29 Oct 2023 06:48:31 -0700 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-563-diBDAQPnPyq2TBhEGBgiaw-1; Sun, 29 Oct 2023 09:48:25 -0400 X-MC-Unique: diBDAQPnPyq2TBhEGBgiaw-1 X-Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 65AC285A5BD; Sun, 29 Oct 2023 13:48:24 +0000 (UTC) X-Received: from [10.39.192.79] (unknown [10.39.192.79]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C45851121319; Sun, 29 Oct 2023 13:48:20 +0000 (UTC) Message-ID: <99615ab9-f669-5ac8-fafd-f154e8af5da8@redhat.com> Date: Sun, 29 Oct 2023 14:48:19 +0100 MIME-Version: 1.0 Subject: Re: [edk2-devel] [Patch 1/1] Maintainers.txt: Update based on active community members To: devel@edk2.groups.io, jiewen.yao@intel.com, "pedro.falcato@gmail.com" , "Kinney, Michael D" Cc: Andrew Fish , Leif Lindholm , "Warkentin, Andrei" , "West, Catharine" , "Bi, Dandan" , Daniel Schaefer , David Woodhouse , "De, Debkumar" , "Dong, Eric" , "Jiang, Guomin" , "Wu, Hao A" , James Bottomley , "Wang, Jian J" , "Justen, Jordan L" , Julien Grall , Peter Grehan , "Zhang, Qi1" , "Ng, Ray Han Lim" , Stefan Berger , "Hou, Wenxing" , "Lu, Xiaoyu1" References: <20231028192330.1031-1-michael.d.kinney@intel.com> From: "Laszlo Ersek" In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: RTmIjGUiZhyaj182zFmkJBdnx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=I0DgFoWv; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 10/29/23 09:05, Yao, Jiewen wrote: > Those are great questions. I also would like to understand: > > 1) What is definition of "actively participating in their roles"? Here are the definitions of Maintainer and Reviewer, from "Maintainers.txt": M: Package Maintainer: Cc address for patches and questions. Responsible for reviewing and pushing package changes to source control. R: Package Reviewer: Cc address for patches and questions. Reviewers help maintainers review code, but don't have push access. A designated Pack= age Reviewer is reasonably familiar with the Package (or some modules thereof), and/or provides testing or regression testing for the Packag= e (or some modules thereof), in certain platforms and environments. > Is there any enforcement or just volunteer work? I see the Maintainer role as a service to the community, with some benefits granted in return. The "service" part should be clear. The benefit is that you are kept in the loop, and sometimes (when you must) you *can* say "no". (According to some seasoned reviewers, the one real power of a maintainer -- not to be abused! -- is "saying no".) A maintainer that's present helps set the focus, keep regressions out, gives advice when needed, and so on. Enforcement would be nice (haha), but it never works. You can't force people to help, especially if their dayjob instructions oppose their upstream community responsibilities. That's fine; in such cases my request is always: if you can't help, then at least don't get in the way, step down. Don't block people from doing their work by having them wait for your feedback. So volunteer work is fine, but as soon as the position grows "fangs" (=3D a capacity to make others wait), then it becomes a promise, a responsibility. > > 2) What is role and *responsibility* of Reviewer role? Is it > documented somewhere? > Per my observation, some assigned reviewers have never reviewed any > patch in history or provided valuable feedback. To me, reviewer role > seems more like a notification instead of really review something. Is > that our purpose? I'd say that's pretty close. A reviewer role is a request for keeping the reviewer in the loop. Maintainers tend to appreciate that, because a long-term reviewer may provide good insights, test results, and so on. Trust is super important; a maintainer may push a patch based solely on a reviewer's positive feedback, due to the latter's experience. > While Laszlo contributed a lots in Tianocore community, he is really a > good "reviewer", although he has no such title. Thanks for the acknowledgement, I appreciate it! I don't like to hoard titles. I'm sure titles are good for one's career, but I always see the *promise* (the responsibility) to the community, first and foremost, that a title encapsulates. It weighs heavily on me. I loathe disappointing people. For me, not to bear a title is better than to bear it and not to deliver on it / not to live up to it. Laszlo -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110259): https://edk2.groups.io/g/devel/message/110259 Mute This Topic: https://groups.io/mt/102245264/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-