From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 6FF5D211B76A1 for ; Mon, 14 Jan 2019 02:08:45 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8993513AA9; Mon, 14 Jan 2019 10:08:44 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-239.rdu2.redhat.com [10.10.120.239]) by smtp.corp.redhat.com (Postfix) with ESMTP id 81A1C5C225; Mon, 14 Jan 2019 10:08:41 +0000 (UTC) To: "Feng, Bob C" , edk2-devel@lists.01.org Cc: Liming Gao , Gerd Hoffmann References: <20190114065454.15576-1-bob.c.feng@intel.com> From: Laszlo Ersek Message-ID: <996f219e-a448-e640-6582-4a0fb2e90083@redhat.com> Date: Mon, 14 Jan 2019 11:08:40 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190114065454.15576-1-bob.c.feng@intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Mon, 14 Jan 2019 10:08:44 +0000 (UTC) Subject: Re: [Patch] BaseTools: Remove unused logic for EDKI X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Jan 2019 10:08:45 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Hi Bob, On 01/14/19 07:54, Feng, Bob C wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1350 > Remove gEcpSource global variable in python tool. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Bob Feng > Cc: Liming Gao > --- > BaseTools/Source/Python/Workspace/DscBuildData.py | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/BaseTools/Source/Python/Workspace/DscBuildData.py b/BaseTools/Source/Python/Workspace/DscBuildData.py > index 93751678f9..9881dbe556 100644 > --- a/BaseTools/Source/Python/Workspace/DscBuildData.py > +++ b/BaseTools/Source/Python/Workspace/DscBuildData.py > @@ -707,11 +707,10 @@ class DscBuildData(PlatformBuildClassObject): > return self.DefaultStores > > def OverrideDuplicateModule(self): > RecordList = self._RawData[MODEL_META_DATA_COMPONENT, self._Arch] > Macros = self._Macros > - Macros["EDK_SOURCE"] = GlobalData.gEcpSource > Components = {} > for Record in RecordList: > ModuleId = Record[6] > file_guid = self._RawData[MODEL_META_DATA_HEADER, self._Arch, None, ModuleId] > file_guid_str = file_guid[0][2] if file_guid else "NULL" > this patch (commit 4523bc82ae8e) breaks (minimally) the ArmVirtPkg/ArmVirtQemu build: > build.py... > : error C0DE: Unknown fatal error when processing [OvmfPkg/Library/QemuFwCfgS3Lib/BaseQemuFwCfgS3LibNull.inf [AARCH64, GCC5, NOOPT]] > > (Please send email to edk2-devel@lists.01.org for help, attaching following call stack trace!) > > (Python 2.7.5 on linux2) Traceback (most recent call last): > File "BaseTools/BinWrappers/PosixLike/../../Source/Python/build/build.py", line 2403, in Main > MyBuild.Launch() > File "BaseTools/BinWrappers/PosixLike/../../Source/Python/build/build.py", line 2137, in Launch > self._MultiThreadBuildPlatform() > File "BaseTools/BinWrappers/PosixLike/../../Source/Python/build/build.py", line 1927, in _MultiThreadBuildPlatform > CmdListDict = self._GenFfsCmd() > File "BaseTools/BinWrappers/PosixLike/../../Source/Python/build/build.py", line 1883, in _GenFfsCmd > GenFfsDict = GenFds.GenFfsMakefile('', GlobalData.gFdfParser, self, self.ArchList, GlobalData) > File "BaseTools/Source/Python/GenFds/GenFds.py", line 544, in GenFfsMakefile > GenFdsGlobalVariable.SetEnv(FdfParserObject, WorkSpace, ArchList, GlobalData) > File "BaseTools/Source/Python/GenFds/GenFdsGlobalVariable.py", line 343, in SetEnv > GenFdsGlobalVariable.EdkSourceDir = GlobalData.gGlobalDefines["EDK_SOURCE"] > KeyError: 'EDK_SOURCE' The "EDK_SOURCE" key is no longer added to the dictionary, but "GenFds/GenFdsGlobalVariable.py" still references it. Can you please fix it quickly; the build is broken. (This was caught by Gerd's Jenkins CI setup.) ... At least I *believe* that this patch is what causes the symptom. Thanks, Laszlo