From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 92967941D3B for ; Sat, 24 Feb 2024 18:03:16 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=KEaVD0nC+0Sd7GPpmKpHztzbqwYwA0pa51YUj6sqvxI=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1708797795; v=1; b=pgGtlO1R7gESVmPwcS8LIZzFbs7DT0UNskFpnbWD7i19sRvjhUwzygNI1DkMU0yYSRHO6LZp SKiX66pXejm1C3M5TfmCHL8JsxiDpL5LnnxmMs1u/WhoV87GNbdRtum7YbUo7cnjUVC9lEcPPMZ 2GpcviGZ5iJudKkCvS5dMSnU= X-Received: by 127.0.0.2 with SMTP id qVz5YY7687511x7zhzpqumml; Sat, 24 Feb 2024 10:03:15 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web11.24315.1708797794460527514 for ; Sat, 24 Feb 2024 10:03:14 -0800 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-542-cjn9mlH6OMCueeR7gMx6og-1; Sat, 24 Feb 2024 13:03:11 -0500 X-MC-Unique: cjn9mlH6OMCueeR7gMx6og-1 X-Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0122D85A589; Sat, 24 Feb 2024 18:03:08 +0000 (UTC) X-Received: from [10.39.192.11] (unknown [10.39.192.11]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 566DD401546D; Sat, 24 Feb 2024 18:02:59 +0000 (UTC) Message-ID: <997ccb2c-e374-b9c3-9031-c6cf37ec3b38@redhat.com> Date: Sat, 24 Feb 2024 19:02:57 +0100 MIME-Version: 1.0 Subject: Re: [edk2-devel] BaseTools/AutoGen: declare ProcessLibraryConstructorList() for SEC modules To: devel@edk2.groups.io, michael.d.kinney@intel.com Cc: Abdul Lateef Attar , Abner Chang , "Warkentin, Andrei" , Andrew Fish , Ard Biesheuvel , "S, Ashraf Ali" , Bibo Mao , "Feng, Bob C" , "West, Catharine" , Chao Li , "Chiu, Chasel" , "Duggapu, Chinni B" , Duke Zhai , "Aktas, Erdem" , Eric Xing , Gerd Hoffmann , "Guo, Gua" , "Dong, Guo" , Igniculus Fu , "Lu, James" , "Yao, Jiewen" , Kelly Steele , Ken Yao , Leif Lindholm , Liming Gao , Michael Roth , "Xu, Min M" , "Desimone, Nathaniel L" , Paul Grimes , "Kumar, Rahul R" , "Ni, Ray" , Rebecca Cran , "Chaganty, Rangasai V" , Sami Mujawar , "Rhodes, Sean" , "Zeng, Star" , Sunil V L , "Mohapatra, Susovan" , "Kuo, Ted" , Tom Lendacky , USER0FISH , Xianglai li , "Chen, Christine" , caiyuqing379 , dahogn , meng-cz References: <36593e23-d3e8-b71a-808d-ef94260b5fd0@redhat.com> <17be8fb9-914b-d428-6db4-dcd4d108932e@redhat.com> From: "Laszlo Ersek" In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: Ua3mDDIHlIv5ggnnzGG8aMDDx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=pgGtlO1R; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hi Mike, On 2/15/24 18:29, Michael D Kinney wrote: > Hi Laszlo, >=20 > I was also thinking the INF Version would be best approach. >=20 > I recommend we identify the EDK II Build Specification and > EDK II INF Specification changes required to resolve this=20 > issue. >=20 > https://github.com/tianocore-docs/edk2-BuildSpecification > https://github.com/tianocore-docs/edk2-InfSpecification I've reviewed both of these (their latest drafts). I've prepared patches for the Build spec -- they affect section "8.3 Auto-generated code". I'm going to post the patches soon. The INF spec seems to need no updates, *except* for the revision history in the README. I've checked all INF_VERSION instances in the spec, and neither looks relevant. In "2.1 Processing Overview": https://tianocore-docs.github.io/edk2-InfSpecification/draft/2_inf_overview= /21_processing_overview.html we already state: [...] The EDK II utilities check EDK II INF files, and, if required, generate C code files based on the content of the EDK II INF. Refer to the EDK II Build Specification for more information regarding these autogenerated files. and in "2.4 [Defines] Section": https://tianocore-docs.github.io/edk2-InfSpecification/draft/2_inf_overview= /24_[defines]_section.html we state [...] The EDK II parsing utilities will use some of this section's information for generating AutoGen.c and AutoGen.h files. [...] which looks sufficient to me. So I plan to post just a README update for the INF spec. Thanks, Laszlo >=20 >=20 > The current INF Spec uses INF_VERSION of 1.27. >=20 > Should the new version be 1.28, or is there something I am > missing where 1.30 would be required? Or are you wanting > to jump from 1.2x to 1.3x to indicate a behavior change? >=20 > Thanks, >=20 > Mike >=20 >=20 >> -----Original Message----- >> From: Laszlo Ersek >> Sent: Wednesday, February 14, 2024 11:58 PM >> To: devel@edk2.groups.io; Kinney, Michael D >> >> Cc: Abdul Lateef Attar ; Abner Chang >> ; Warkentin, Andrei ; >> Andrew Fish ; Ard Biesheuvel >> ; S, Ashraf Ali ; >> Bibo Mao ; Feng, Bob C ; >> West, Catharine ; Chao Li >> ; Chiu, Chasel ; Duggapu, >> Chinni B ; Duke Zhai ; >> Aktas, Erdem ; Eric Xing ; >> Gerd Hoffmann ; Guo, Gua ; Dong, >> Guo ; Igniculus Fu ; Lu, >> James ; Yao, Jiewen ; Kelly >> Steele ; Ken Yao ; Leif >> Lindholm ; Liming Gao >> ; Michael Roth ; Xu, >> Min M ; Desimone, Nathaniel L >> ; Paul Grimes ; >> Kumar, Rahul R ; Ni, Ray ; >> Rebecca Cran ; Chaganty, Rangasai V >> ; Sami Mujawar ; >> Rhodes, Sean ; Zeng, Star ; >> Sunil V L ; Mohapatra, Susovan >> ; Kuo, Ted ; Tom >> Lendacky ; USER0FISH ; >> Xianglai li ; Chen, Christine >> ; caiyuqing379 ; dahogn >> ; meng-cz >> Subject: Re: [edk2-devel] BaseTools/AutoGen: declare >> ProcessLibraryConstructorList() for SEC modules >> >> On 2/8/24 17:40, Michael D Kinney wrote: >>> Hi Laszlo, >>> >>> I need to review the proposed BaseTools/AutoGen change to see what >> options >>> are available for compatibility. >>> >>> My main concern is downstream consumers that may break immediately >> with >>> a change like this and we need a way for them to be informed and have >>> time to update their components just like you outline a sequence to >> update >>> the edk2 repo components. >> >> Should AutoGen declare ProcessLibraryConstructorList() for a SEC module >> if INF_VERSION >=3D 1.30? >> >> Or should we introduce a new macro in [Defines]? >> >> https://tianocore-docs.github.io/edk2- >> InfSpecification/draft/2_inf_overview/24_[defines]_section.html >> >> "EDK II parsing utilities will use some of this section's information >> for generating AutoGen.c and AutoGen.h files." >> >> I'd prefer (INF_VERSION >=3D 1.30) over a dedicated macro. We should >> ensure, over time, that ProcessLibraryConstructorList() is declared by >> default, for SEC modules. If that declaration depended on an explicit >> new macro in [Defines], it would much less likely become the default. >> >> Laszlo >=20 >=20 >=20 >=20 >=20 >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115907): https://edk2.groups.io/g/devel/message/115907 Mute This Topic: https://groups.io/mt/104210524/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-