From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web11.1829.1584404094173610171 for ; Mon, 16 Mar 2020 17:14:54 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: liming.gao@intel.com) IronPort-SDR: UT8hbmrCSyOJ3b2AmsyxOTUSwMs4t0j2fJ/1Gk+smfA8a1NZcdBgp8YcfExKRumCHukAyfKM8K zUabf9iyk3xw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Mar 2020 17:14:53 -0700 IronPort-SDR: fd5GoacwcKci9Y31A4EjTlA1TCUZhZlpwOL7A3BP5CAUNw4OymaMUyUn215rntowSSmNxvvKr2 aofrLhXRzGQg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,562,1574150400"; d="scan'208";a="323666947" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga001.jf.intel.com with ESMTP; 16 Mar 2020 17:14:53 -0700 Received: from shsmsx605.ccr.corp.intel.com (10.109.6.215) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 16 Mar 2020 17:14:53 -0700 Received: from shsmsx606.ccr.corp.intel.com (10.109.6.216) by SHSMSX605.ccr.corp.intel.com (10.109.6.215) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 17 Mar 2020 08:14:51 +0800 Received: from shsmsx606.ccr.corp.intel.com ([10.109.6.216]) by SHSMSX606.ccr.corp.intel.com ([10.109.6.216]) with mapi id 15.01.1713.004; Tue, 17 Mar 2020 08:14:51 +0800 From: "Liming Gao" To: "devel@edk2.groups.io" , "Zhang, Shenglei" , "newexplorerj@gmail.com" CC: "Wang, Jian J" , "Lu, XiaoyuX" Subject: Re: [edk2-devel] [PATCH v2 1/2] CryptoPkg/BaseCryptLibOnProtocolPpi: Add missing comments Thread-Topic: [edk2-devel] [PATCH v2 1/2] CryptoPkg/BaseCryptLibOnProtocolPpi: Add missing comments Thread-Index: AQHV8rkvbBAo+L+bnkmTZgYiVgLdOKhD+F6AgAgENIA= Date: Tue, 17 Mar 2020 00:14:50 +0000 Message-ID: <99809744c7864caf9bb838cafa66fbbd@intel.com> References: <2731dd841ca22bf605f0c115ff779cb1e6f7b926.1583390439.git.newexplorerj@gmail.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.2.0.6 dlp-product: dlpe-windows dlp-reaction: no-action x-originating-ip: [10.239.127.36] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable @Jian, Xiao, can you review this change also? Reviewed-by: Liming Gao -----Original Message----- From: devel@edk2.groups.io On Behalf Of Zhang, Shen= glei Sent: 2020=1B$BG/=1B(B3=1B$B7n=1B(B12=1B$BF|=1B(B 13:49 To: devel@edk2.groups.io; newexplorerj@gmail.com Cc: Wang, Jian J ; Lu, XiaoyuX Subject: Re: [edk2-devel] [PATCH v2 1/2] CryptoPkg/BaseCryptLibOnProtocolP= pi: Add missing comments Reviewed-by: Shenglei Zhang > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of=20 > GuoMinJ > Sent: Thursday, March 5, 2020 2:41 PM > To: devel@edk2.groups.io > Cc: GuoMinJ ; Wang, Jian J=20 > ; Lu, XiaoyuX > Subject: [edk2-devel] [PATCH v2 1/2] CryptoPkg/BaseCryptLibOnProtocolPpi= : > Add missing comments >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2552 >=20 > DxeCryptLibConstructor have no comments for it, add comments for it. >=20 > Cc: Jian J Wang > Cc: Xiaoyu Lu > Signed-off-by: GuoMinJ > --- > .../Library/BaseCryptLibOnProtocolPpi/DxeCryptLib.c | 9 +++++++++ > 1 file changed, 9 insertions(+) >=20 > diff --git a/CryptoPkg/Library/BaseCryptLibOnProtocolPpi/DxeCryptLib.c > b/CryptoPkg/Library/BaseCryptLibOnProtocolPpi/DxeCryptLib.c > index 34d5f410b0..b503a5708b 100644 > --- a/CryptoPkg/Library/BaseCryptLibOnProtocolPpi/DxeCryptLib.c > +++ b/CryptoPkg/Library/BaseCryptLibOnProtocolPpi/DxeCryptLib.c > @@ -32,6 +32,15 @@ GetCryptoServices ( > return (VOID *)mCryptoProtocol; > } >=20 > +/** > + Locate the valid Crypto Protocol. > + > + @param ImageHandle The firmware allocated handle for the EFI image= . > + @param SystemTable A pointer to the EFI System Table. > + > + @retval EFI_SUCCESS The constructor executed correctly. > + @retval EFI_NOT_FOUND Found no valid Crypto Protocol. > +**/ > EFI_STATUS > EFIAPI > DxeCryptLibConstructor ( > -- > 2.17.1 >=20 >=20 >=20