From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (NAM10-BN7-obe.outbound.protection.outlook.com [40.107.92.109]) by mx.groups.io with SMTP id smtpd.web11.22541.1679754002047899230 for ; Sat, 25 Mar 2023 07:20:02 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="no key for verify" header.i=@amperemail.onmicrosoft.com header.s=selector1-amperemail-onmicrosoft-com header.b=Y3ihRxFp; spf=pass (domain: os.amperecomputing.com, ip: 40.107.92.109, mailfrom: tinhnguyen@os.amperecomputing.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Sr7NnWKxY1jf8xMnjswABqm8HIwpN0qt60L6tcd8C0dPJDT8KntrWBvEban3mIJtL4fK88hjAxBSVpb5F2rUDyYksmcUueAMhiGrKMilWM30Baq/pZJF/5NZhtUYxUCgarEoYz+RYjs8dvRn++8325QXJeEDWqTVCWkHL6+ywQ2TWFb5fSAWwuZ5szkVBxiA40GvvX5cnUMuhGtg+T37uxyUKQY7Fdx4vtQ44vIa9i2Z+qGEf8/xB8iH9UTqbDsPMA2NbcSJ9XubbHqW96ud23N7Obqoc4WJKKrK26xDAVPVNp75Xwu4CU6/IdOA3dGzabdVGNfaOx2Vf0PWuMTXiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rB1PJ0II67wqIHOO+HSQIvocJkzMNpeuCY3nL2kTNhA=; b=lRe4UefGCYXH0jfEzdf5vshXSXdBIvSsYshqGDFDhfs5OzGId0/w5ws4cxnnt4uQY1EAgtGoNdPYlwsKOtCW/b1diQLY9rSMWeNiXKI8bQYwldFRdTzlxw2hdRXHu52NIpOqg+Uz119kIGn0hUDPvoHwvnaV4GM3nxuYJjd+zN8mGNIrCR3au0FraPx9wOK6l6JZWmA77TEg7M6zzvAdEollKbT8W3BpuvHBFyscf1PBy2UaxYvijK0eOoayon2lwQ7S3mE9NIq7RRU8Psu0H94iYZyOgmuSm7iPC3sA+I5MXBPi5iQ5pZV4focQ6s9GrV1tWMLyKX03GZEbBJyArQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=amperemail.onmicrosoft.com; dkim=pass header.d=amperemail.onmicrosoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amperemail.onmicrosoft.com; s=selector1-amperemail-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rB1PJ0II67wqIHOO+HSQIvocJkzMNpeuCY3nL2kTNhA=; b=Y3ihRxFp9foKN16WYGNuYJWLpPWIStJTMGV4czzTZ6YKvM9IFDoReofbhv30O0jnzHqDIxpCSUTA2MWtFzwSjeOGnIbLVPNnfBNdO1ytgX1yLu62TcoYxHy4rsIcKG7VhgjNuGmTHMarsQdxX9s6TtcI5DaYiPuSQhAT7PdTc4I= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amperemail.onmicrosoft.com; Received: from DM5PR0101MB2937.prod.exchangelabs.com (2603:10b6:4:34::24) by CY4PR01MB2695.prod.exchangelabs.com (2603:10b6:903:e8::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6222.8; Sat, 25 Mar 2023 14:19:58 +0000 Received: from DM5PR0101MB2937.prod.exchangelabs.com ([fe80::d653:dad3:4cc2:a290]) by DM5PR0101MB2937.prod.exchangelabs.com ([fe80::d653:dad3:4cc2:a290%3]) with mapi id 15.20.6178.037; Sat, 25 Mar 2023 14:19:57 +0000 Message-ID: <999a617b-b107-fea8-8640-2e1ab7a9b5a5@amperemail.onmicrosoft.com> Date: Sat, 25 Mar 2023 21:19:48 +0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH v4] MdePkg/Include: Add IPMI KCS definitions To: "Chang, Abner" , "Kinney, Michael D" , "devel@edk2.groups.io" Cc: "Gao, Liming" , "Liu, Zhiguang" , Nickle Wang , Igor Kulchytskyy , "Oram, Isaac W" , "Attar, AbdulLateef (Abdul Lateef)" References: <20230324031554.264-1-abner.chang@amd.com> From: "Tinh Nguyen" In-Reply-To: X-ClientProxiedBy: SI1PR02CA0040.apcprd02.prod.outlook.com (2603:1096:4:1f6::7) To DM5PR0101MB2937.prod.exchangelabs.com (2603:10b6:4:34::24) Return-Path: tinhnguyen@os.amperecomputing.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM5PR0101MB2937:EE_|CY4PR01MB2695:EE_ X-MS-Office365-Filtering-Correlation-Id: a4321143-4c50-4a2e-b6fb-08db2d3c02db X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Gygx1mpekT0f7DOsER0td+9FcSemIOamHnZfBqhQlTU3SK/ZyKGqIMVmx2LWjmQYC8L3lXcUfVq0TvwNgL5vOvSQnW0QUtdwdtGe2U540zQafggfvbmaoNyeKL9tj+AONWwvB+D1vaxFkTB6WF+dIs05h/IFGZtlvYWffG04dO2G/ZRSUsph6ratnK2PHEk85yBytVZ2G8NVdwKnR8RtcySsXEDMLVC51TvKHBezz1GRHn3O2gee2s1skkfe5XGHQs3Wi0wVfdqLEOe8ypgSA3emoghkRU3hhMJRxwVqAIuRtY8CLV5Vl6xHCQCaUcmnVegEm0H1yVsSn9TZa1+Tooe1nee/xV3IcQMxPVjc/g4b3rNIcN0VFihNv1gfZg2oD4kCFQ0C8nhY/+UO8ArhP4w7uMkD+x3+HYbWGO/TDHXBcQ+e2gbgdUmqKo2RANIdrvog9X5zr1uUQYBoxv/7cRXeSKxwBREzC89MdjjCaSR/rMGE3C81LSl6yZ45DWU7/MZzcUDpttuChUoUpjg6WfFGNyyjv4XCNmmHtprShMKz7xr4dllfHo+MDmHFpitU3ETnIBhzEOFZEQ9yFJzsaA7yyPJQWG0xJ8PmlRNHx0WbnwVTI/jrU0iYoVknpnERCKi1E+QEQGuJwoFqITZMyxgHiZ0TTLF8fXkuyzrBLmlu2T3t836FJtAvH02jGOC/ X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR0101MB2937.prod.exchangelabs.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(346002)(39850400004)(396003)(136003)(376002)(366004)(451199021)(83170400001)(186003)(316002)(2616005)(31696002)(6512007)(6666004)(8676002)(42882007)(2906002)(66476007)(4326008)(26005)(66946007)(966005)(110136005)(6486002)(54906003)(38100700002)(8936002)(83380400001)(6506007)(31686004)(478600001)(66556008)(5660300002)(41300700001)(53546011)(43740500002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N0ZqWER5MlFxUitNbytsQno2bHlQanVGenBCeW4zcnk0ZFpwQVM1Z3lodHFQ?= =?utf-8?B?WENNWS9KckUxckxPVE5FNmJpRzhFQU1PUGpQc2h6SWxOSkhLTDVrMW1PZkI2?= =?utf-8?B?ZE1hRTd3Z25NeTFlUFljZzgwWkNTYVNCbElPWHI5d09VUkJ4aGdMa2JlYmFU?= =?utf-8?B?OFdVVkpnbVZTcW1zUmtsYlpEUTRxVHRsbGFTbXZGeU54WkdNSFpaTndTK01p?= =?utf-8?B?M0lseHVKdHErOVBETG9iWVhKWXFTQ1RDNmpXOW9DU0pOc09JM1RWMXdQUmFX?= =?utf-8?B?THVNamVoRjJVaTdrdVdLRXZNckY1dER2S1RzZ092T2sxOWRUZUdnQmIrOEI2?= =?utf-8?B?Zkw0WENwSDhkb1VPWHBLY2NRWUZPWmlrTGNpSWNqZDNmbUlsMWpuTGs0NExC?= =?utf-8?B?ekdTL2JNMEpHTm9yamxscmRYMXZhRHg4eUk1QmgzdXJTeEJhd1ZKcFdlVXVV?= =?utf-8?B?ZnBRbExHelJLbjkzSHBsZFgzU25PL3BvS2l3K0V6QWpYS3V1NDc1MmZQbkx6?= =?utf-8?B?eDVna1pzb295R0JvcDEva2lOZXRvaTYySGNCQ0dyNVZzcWQyYTliY3lJdld0?= =?utf-8?B?ZUt3VkFRQzQ2NmhEZC8xTEFQNEJaMkRrODl0Z3RqUmc3MWNwMGx6Q3pvVzR1?= =?utf-8?B?U3JMeG9sMENRa1Q2allxOVNzZWlNMjhZc2d0NzEyWGhsVi9jcDVYNzgyY3ha?= =?utf-8?B?TTN1Y1NPYmNQdUFnSzNNaWd1MXV1RU8xSDh1cXhxSWtRcEhTdWlFTGdnb3V6?= =?utf-8?B?SjRmcDdLbCtQTHhBOCtXNjB1Y0lMYmlPZ1NKclQzY1BzWFp1Nm9BYWgzd1Mv?= =?utf-8?B?WVJmMmFkTmdqY2c5U2cwc1VyZHJRMjMzNUhVMmZZYjU0T2hmbi9nOTZBeFZz?= =?utf-8?B?L2R0NGdYNndaUjBXdkR0TU55eXJsNnpreHVkK3F4TlZ6dDkvOFV6WWZhSlJp?= =?utf-8?B?R0lOd3Z5VEZjdG1DcEN5aWNJYnlLcmFBM1hPZmFpeFBWLzhwT1h2c0JZR0d2?= =?utf-8?B?VkpoRVg2VUVwZzFxZUpVN3NZc3F6ekRzNjlNdjBMdkVWejZqUnlaRGFDbmky?= =?utf-8?B?Vkk5cUlrc1RqamRpNzdYWFZJMllsa1BVMHVQeUgyTjZsWEhTNlNwQWpVZkdB?= =?utf-8?B?dHZET1ZVclVSd3VaTjNkaXppd2xnUjcyVktNbTVpcjBYRmJOM3ZaRTlhMFNG?= =?utf-8?B?TDJSalVaWTY0ckF6UldRdldNU3UwRjJoYmtsTkFjeGtTRjVnZ3JCcHRBamZW?= =?utf-8?B?UjJkelNFL05NbVFYd1RGUUpMbVZSTWhkN2lpYnNPZUlNTXpZc0xqbjJidHQr?= =?utf-8?B?NGU5VTRvOURZQnREbTUyMDMrNW9GR1hBMk5WWStTNC9VZkE2UFNESVh1YXIv?= =?utf-8?B?eEN0Y1lpUHd2RmVKVDdIcE9HZU8zL2Y1RUpSWnFkSEdieG5MZHBMT01vV3R4?= =?utf-8?B?L1k5Q3RsY1N3dER3MGtRMG02UDYxWXI0VC9KM29wbENhMG9wN1kybnV2bk9w?= =?utf-8?B?ZVV0aHVBOWI3THczZmwrMUl1UERJVUtnTUVzRWltNXFRcGt5aW1SNWtjWEpJ?= =?utf-8?B?Q3crNG9oQk8xTEZPL0F0Tnl4Q0VrS1FhL3lIcWhOQzhIQTRHdFJjenBRWlNM?= =?utf-8?B?SllwbGxDY2dnTmJORi8wcGZmZjgrYUN2ZlB3SDFTZE90YUM2RXkrcHRsKzlJ?= =?utf-8?B?ZUd4aGFhQ0FCZlkvNHYvRWxVSUcxL0VWbm9QR2ZNVTBYYXU3ZUcrd1YwWjQw?= =?utf-8?B?UmIvanFobi8yVWpuSEt5Z1RhWDFrdzVNTHB1bTFVSk1BSmtDcTlOQ1M5UTls?= =?utf-8?B?V3BQeXEwRGxaNHBoNzFLVlhJRUUvOEd3T044SDl6V1IxTm9meEVXQmZ2cGVD?= =?utf-8?B?R2Y1NUN4bGpObDJKU1VRL1V0VDFSSW4zS2daY1FPMlB3enNOOFZCRkJ2aUY2?= =?utf-8?B?eWZxS2xqck9iOVhFUHFDOVFad1EzTFBqVmVLUXNsdGNSZ3gvWGU1TkNOMEFB?= =?utf-8?B?akx0STdVQm5icHVjczFjMEVsVFJWK1V6dHdMa2h5SFpySS9iUDFuK2lLQ3g3?= =?utf-8?B?dHVlbHNjelZ3QjJjdlpZUG1JdFZieFA5akVSVUtsNm9KZUVQb2dxaGtIVDdC?= =?utf-8?B?UDRQQnNQN243Sm0wOHRDRERUR2VIcUlYS1dleXZUUTY1d044VGtDQSswZ0lI?= =?utf-8?Q?UBF38uDPmeGmBjwYxCJ4vpApKo/tI8dQYVD39yabHfby?= X-OriginatorOrg: amperemail.onmicrosoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: a4321143-4c50-4a2e-b6fb-08db2d3c02db X-MS-Exchange-CrossTenant-AuthSource: DM5PR0101MB2937.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Mar 2023 14:19:57.5579 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: EYb916Wi/TOKkAmTwP+6edYArqiQiIxY36bCwYE0Cq+7MhfcSTA0l5/Vxi9hPvLVFAP4XdQedwqiCcK65OuR8AyLx8AEMqiBUoyW3Y3qZ3NgdGn7bzgXuURoEjw28OP9 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR01MB2695 Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Thank you for your hard work Reviewed-by: Tinh Nguyen On 3/25/2023 8:46 PM, Chang, Abner wrote: > [EXTERNAL EMAIL NOTICE: This email originated from an external sender. Please be mindful of safe email handling and proprietary information protection practices.] > > > [AMD Official Use Only - General] > > Hi Mike, please note there is V5 of IPMI KCS that fixes a typo found by Tinh. > Thanks > > @Tinh, would you like to provide your R-B or Acked-by tag for V5? > > Thanks > Abner > >> -----Original Message----- >> From: Kinney, Michael D >> Sent: Saturday, March 25, 2023 3:37 AM >> To: Chang, Abner ; devel@edk2.groups.io >> Cc: Gao, Liming ; Liu, Zhiguang >> ; Nickle Wang ; Igor >> Kulchytskyy ; Oram, Isaac W ; >> Attar, AbdulLateef (Abdul Lateef) ; Kinney, >> Michael D >> Subject: RE: [PATCH v4] MdePkg/Include: Add IPMI KCS definitions >> >> Caution: This message originated from an External Source. Use proper >> caution when opening attachments, clicking links, or responding. >> >> >> Reviewed-by: Michael D Kinney >> >>> -----Original Message----- >>> From: abner.chang@amd.com >>> Sent: Thursday, March 23, 2023 8:16 PM >>> To: devel@edk2.groups.io >>> Cc: Kinney, Michael D ; Gao, Liming >>> ; Liu, Zhiguang ; >>> Nickle Wang ; Igor Kulchytskyy ; >>> Oram, Isaac W ; Abdul Lateef Attar >>> >>> Subject: [PATCH v4] MdePkg/Include: Add IPMI KCS definitions >>> >>> From: Abner Chang >>> >>> BZ #4354 >>> This change adds definitions for IPMI KCS. >>> >>> Spec ref: >>> >> https://www.intel.com/content/www/us/en/products/docs/servers/ipmi/i >> pm >>> i-second-gen-interface-spec-v2-rev1-1.html >>> >>> Signed-off-by: Abner Chang >>> Cc: Michael D Kinney >>> Cc: Liming Gao >>> Cc: Zhiguang Liu >>> Cc: Nickle Wang >>> Cc: Igor Kulchytskyy >>> Cc: Isaac Oram >>> Cc: Abdul Lateef Attar >>> Acked-by: Isaac Oram >>> --- >>> MdePkg/MdePkg.dec | 6 ++ >>> MdePkg/Include/IndustryStandard/IpmiKcs.h | 76 >>> +++++++++++++++++++++++ >>> 2 files changed, 82 insertions(+) >>> create mode 100644 MdePkg/Include/IndustryStandard/IpmiKcs.h >>> >>> diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec index >>> 2d643bede1d..5cf04bc0cb6 100644 >>> --- a/MdePkg/MdePkg.dec >>> +++ b/MdePkg/MdePkg.dec >>> @@ -9,6 +9,7 @@ >>> # (C) Copyright 2016 - 2021 Hewlett Packard Enterprise Development >>> LP
# Copyright (c) 2022, Loongson Technology Corporation Limited. >>> All rights reserved.
# Copyright (c) 2021 - 2022, Arm Limited. >>> All rights reserved.
>>> +# Copyright (C) 2023 Advanced Micro Devices, Inc. All rights >>> +reserved.
>>> # >>> # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -2342,6 +2343,11 >>> @@ >>> # @Prompt Memory Address of GuidedExtractHandler Table. >>> >>> >> gEfiMdePkgTokenSpaceGuid.PcdGuidedExtractHandlerTableAddress|0x1000 >> 000 >>> |UINT64|0x30001015 >>> >>> + ## This value is the IPMI KCS Interface I/O base address used to transmit >> IPMI commands. >>> + # The value of 0xca2 is the default I/O base address defined in IPMI >> specification. >>> + # @Prompt IPMI KCS Interface I/O Base Address >>> + >>> + >> gEfiMdePkgTokenSpaceGuid.PcdIpmiKcsIoBaseAddress|0xca2|UINT16|0x00 >> 00 >>> + 0031 >>> + >>> [PcdsFixedAtBuild, PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx] >>> ## This value is used to set the base address of PCI express hierarchy. >>> # @Prompt PCI Express Base Address. >>> diff --git a/MdePkg/Include/IndustryStandard/IpmiKcs.h >>> b/MdePkg/Include/IndustryStandard/IpmiKcs.h >>> new file mode 100644 >>> index 00000000000..1e1be787617 >>> --- /dev/null >>> +++ b/MdePkg/Include/IndustryStandard/IpmiKcs.h >>> @@ -0,0 +1,76 @@ >>> +/** @file >>> + IPMI KCS Register Definitions >>> + >>> + Copyright (C) 2023 Advanced Micro Devices, Inc. All rights >>> + reserved.
>>> + SPDX-License-Identifier: BSD-2-Clause-Patent >>> + >>> + @par Revision Reference: >>> + IPMI Specification >>> + Version 2.0, Rev. 1.1 >>> + >>> >> +https://www.intel.com/content/www/us/en/products/docs/servers/ipmi/ >> ip >>> +mi-second-gen-interface-spec-v2-rev1-1.html >>> +**/ >>> + >>> +#ifndef IPMI_KCS_H_ >>> +#define IPMI_KCS_H_ >>> + >>> +#define IPMI_KCS_STATUS_REGISTER_OFFSET 1 >>> +#define IPMI_KCS_COMMAND_REGISTER_OFFSET 1 >>> +#define IPMI_KCS_DATA_OUT_REGISTER_OFFSET 0 >>> +#define IPMI_KCS_DATA_IN_REGISTER_OFFSET 0 >>> + >>> +/// >>> +/// IPMI KCS Interface Status Bits >>> +/// >>> +#define IPMI_KCS_OBF BIT0 >>> +#define IPMI_KCS_IBF BIT1 >>> +#define IPMI_KCS_SMS_ATN BIT2 >>> +#define IPMI_KCS_COMMAND_DATA BIT3 >>> +#define IPMI_KCS_OEM1 BIT4 >>> +#define IPMI_KCS_OEM2 BIT5 >>> +#define IPMI_KCS_S0 BIT6 >>> +#define IPMI_KCS_S1 BIT7 >>> + >>> +/// >>> +/// IPMI KCS Interface Control Codes >>> +/// >>> +#define IPMI_KCS_CONTROL_CODE_GET_STATUS_ABORT 0x60 >>> +#define IPMI_KCS_CONTROL_CODE_WRITE_START 0x61 >>> +#define IPMI_KCS_CONTROL_CODE_WRITE_END 0x62 >>> +#define IPMI_KCS_CONTROL_CODE_READ 0x68 >>> + >>> +/// >>> +/// Status Codes >>> +/// >>> +#define IPMI_KCS_STATUS_NO_ERROR 0x00 >>> +#define IPMI_KCS_STATUS_ABORT 0x01 >>> +#define IPMI_KCS_STATUS_ILLEGAL 0x02 >>> +#define IPMI_KCS_STATUS_LENGTH_ERROR 0x06 >>> +#define IPMI_KCS_STATUS_UNSPECIFIED 0xFF >>> + >>> +/// >>> +/// KCS Interface State Bit >>> +/// >>> +typedef enum { >>> + IPMI_KCS_IDLE_STATE = 0, >>> + IPMI_KCS_READ_STATE, >>> + IPMI_KCS_WRITE_STATE, >>> + IPMI_KCS_ERROR_STATE >>> +} IPMI_KCS_STATE; >>> + >>> +/// >>> +/// IPMI KCS Interface Request Format /// typedef struct { >>> + UINT8 NetFunc; >>> + UINT8 Command; >>> + UINT8 Data[]; >>> +} IPMI_KCS_RESQUEST_HEADER; >>> + >>> +/// >>> +/// IPMI KCS Interface Response Format /// typedef struct { >>> + UINT8 NetFunc; >>> + UINT8 Command; >>> +} IPMI_KCS_RESPONSE_HEADER; >>> +#endif >>> -- >>> 2.37.1.windows.1