From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.groups.io with SMTP id smtpd.web11.2110.1610502678225206669 for ; Tue, 12 Jan 2021 17:51:18 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=i/+ufxbS; spf=pass (domain: redhat.com, ip: 63.128.21.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1610502677; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+GJ1XwJH0XC0Tx/39L7Jt6EmvDINQw3/JTEejdlJDdg=; b=i/+ufxbSgWGZVrx4eIhGIuMsQB0IumDfmhtjcAGk5hXBR4T4Y+RGNaKl+TUO6pXAzk/CZx zMpqpBXwHHJsPiMqy4smyBqQ0uSgmsArI7g4atzxwhpGBtcjz4rgz4UwSzx7gayL8JE/64 nTL+urJ/lwbm5TOlF33NR9cbSwi+Po0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-478-BlWDTp1jMNSXuxUzMoyZKA-1; Tue, 12 Jan 2021 20:51:13 -0500 X-MC-Unique: BlWDTp1jMNSXuxUzMoyZKA-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 190A0800050; Wed, 13 Jan 2021 01:51:11 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-112-31.ams2.redhat.com [10.36.112.31]) by smtp.corp.redhat.com (Postfix) with ESMTP id F2AC7100164C; Wed, 13 Jan 2021 01:51:07 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH v4 4/9] OvmfPkg/PciHostBridgeUtilityLib: Extend parameter list of InitRootBridge To: devel@edk2.groups.io, cenjiahui@huawei.com Cc: Jordan Justen , Ard Biesheuvel , Rebecca Cran , Peter Grehan , Anthony Perard , Julien Grall , Leif Lindholm , Sami Mujawar , xieyingtai@huawei.com, wu.wubin@huawei.com, Yubo Miao References: <20210112094549.10238-1-cenjiahui@huawei.com> <20210112094549.10238-5-cenjiahui@huawei.com> From: "Laszlo Ersek" Message-ID: <999d1820-08b7-5f57-75bc-2311b93f4b7d@redhat.com> Date: Wed, 13 Jan 2021 02:51:06 +0100 MIME-Version: 1.0 In-Reply-To: <20210112094549.10238-5-cenjiahui@huawei.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 01/12/21 10:45, Jiahui Cen via groups.io wrote: > Extend parameter list of PciHostBridgeUtilityInitRootBridge() with > DmaAbove4G and NoExtendedConfigSpace to prepare for support of ArmVirtPkg. > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3059 > > Cc: Jordan Justen > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Cc: Anthony Perard > Cc: Julien Grall > Signed-off-by: Jiahui Cen > Signed-off-by: Yubo Miao > --- > OvmfPkg/Library/PciHostBridgeLib/PciHostBridgeLib.inf | 1 + > OvmfPkg/Library/PciHostBridgeUtilityLib/PciHostBridgeUtilityLib.inf | 3 - > OvmfPkg/Include/Library/PciHostBridgeUtilityLib.h | 56 ++++++++++-------- > OvmfPkg/Library/PciHostBridgeLib/PciHostBridgeLib.c | 5 ++ > OvmfPkg/Library/PciHostBridgeLib/XenSupport.c | 1 + > OvmfPkg/Library/PciHostBridgeUtilityLib/PciHostBridgeUtilityLib.c | 62 +++++++++++--------- > 6 files changed, 73 insertions(+), 55 deletions(-) > > diff --git a/OvmfPkg/Library/PciHostBridgeLib/PciHostBridgeLib.inf b/OvmfPkg/Library/PciHostBridgeLib/PciHostBridgeLib.inf > index d09429d9f0fb..463c05c94b07 100644 > --- a/OvmfPkg/Library/PciHostBridgeLib/PciHostBridgeLib.inf > +++ b/OvmfPkg/Library/PciHostBridgeLib/PciHostBridgeLib.inf > @@ -49,4 +49,5 @@ [Pcd] > gUefiOvmfPkgTokenSpaceGuid.PcdPciMmio32Size > gUefiOvmfPkgTokenSpaceGuid.PcdPciMmio64Base > gUefiOvmfPkgTokenSpaceGuid.PcdPciMmio64Size > + gUefiOvmfPkgTokenSpaceGuid.PcdOvmfHostBridgePciDevId > gEfiMdeModulePkgTokenSpaceGuid.PcdPciDisableBusEnumeration > diff --git a/OvmfPkg/Library/PciHostBridgeUtilityLib/PciHostBridgeUtilityLib.inf b/OvmfPkg/Library/PciHostBridgeUtilityLib/PciHostBridgeUtilityLib.inf > index 32a10e99c3e0..4d6764b702f4 100644 > --- a/OvmfPkg/Library/PciHostBridgeUtilityLib/PciHostBridgeUtilityLib.inf > +++ b/OvmfPkg/Library/PciHostBridgeUtilityLib/PciHostBridgeUtilityLib.inf > @@ -39,6 +39,3 @@ [LibraryClasses] > DebugLib > DevicePathLib > MemoryAllocationLib > - > -[Pcd] > - gUefiOvmfPkgTokenSpaceGuid.PcdOvmfHostBridgePciDevId (1) According to my feedback under patch#3 in this series, I think the present patch will have to undo the PcdLib dependency as well(both INF file and #include). Please extend this patch accordingly; I'm ready to R-b then. Thanks Laszlo